getModifierState should always return a boolean

syranide · zpao · commit 030071dd8b1e · 2014-07-23T10:01:22.000-07:00
diff --git a/src/browser/ui/dom/getEventModifierState.js b/src/browser/ui/dom/getEventModifierState.js
@@ -42,7 +42,7 @@ function modifierStateGetter(keyArg) {
     return nativeEvent.getModifierState(keyArg);
   }
   var keyProp = modifierKeyToProp[keyArg];
-  return keyProp && nativeEvent[keyProp];
+  return keyProp ? !!nativeEvent[keyProp] : false;
 }
 
 function getEventModifierState(nativeEvent) {

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ function modifierStateGetter(keyArg) {`
`42`	`42`	`return nativeEvent.getModifierState(keyArg);`
`43`	`43`	`}`
`44`	`44`	`var keyProp = modifierKeyToProp[keyArg];`
`45`		`- return keyProp && nativeEvent[keyProp];`
	`45`	`+ return keyProp ? !!nativeEvent[keyProp] : false;`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`function getEventModifierState(nativeEvent) {`