Skip to content

Commit 06de43d

Browse files
committed
Remove line length lint warning
...because the current situation isn't helpful; no one looks at the list. Our style guide hasn't changed.
1 parent 806ff23 commit 06de43d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.eslintrc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@ rules:
4343
no-shadow: 2
4444
no-multi-spaces: 2
4545

46-
# WARNINGS
47-
# This is the only one that's hard to track since we don't lint just changes.
48-
max-len: [1, 80]
49-
5046
# WISHLIST. One day...
5147
# We'll need a custom version of this that does a subset of the whole rule.
5248
# Otherwise this is just too noisy.
5349
# valid-jsdoc: 1
50+
# Ideally, we could just warn when *new* lines are added that exceed 80 chars
51+
# while not warning about existing ones (often URLs, etc. which are
52+
# necessarily long), but we don't have a good way to do so.
53+
# max-len: [0, 80]
5454

5555
# DISABLED. These aren't compatible with our style
5656
# We use this for private/internal variables

grunt/tasks/eslint.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ module.exports = function() {
1212
if (err) {
1313
grunt.log.error('Lint failed');
1414
} else {
15-
grunt.log.ok('Lint passed (but may contain warnings)');
15+
grunt.log.ok('Lint passed');
1616
}
1717

1818
done(code === 0);

0 commit comments

Comments
 (0)