Check warning/invariant calls have good messages

The `warning` implementation checked that the message is long enough to
be useful. See commit f503882 for more information.

It makes more sense to move this into a lint rule, and also to apply it
for both `warning` and `invariant`. We can safely remove stuff from the
`warning` implementation as we replace the function internally anyways.

facebook#4021 (comment)
@spicyj

Author: bgw

eslint-rules/__tests__/warning-and-invariant-args-test.js

@@ -58,7 +58,7 @@ eslintTester.addRuleTest('eslint-rules/warning-and-invariant-args', {
       ],
     },
     {
-      code: "warning(true, 'foobar', 'junk argument');",
+      code: "warning(true, 'foo is a bar under foobar', 'junk argument');",
       errors: [
         {
           message:
@@ -67,6 +67,37 @@ eslintTester.addRuleTest('eslint-rules/warning-and-invariant-args', {
         },
       ],
     },
+    {
+      code: "invariant(true, 'error!');",
+      errors: [
+        {
+          message:
+            'The invariant format should be able to uniquely identify this ' +
+            'invariant. Please, use a more descriptive format than: error!',
+        },
+      ],
+    },
+    {
+      code: "warning(true, 'error!');",
+      errors: [
+        {
+          message:
+            'The warning format should be able to uniquely identify this ' +
+            'warning. Please, use a more descriptive format than: error!',
+        },
+      ],
+    },
+    {
+      code: "warning(true, '%s %s, %s %s: %s (%s)', 1, 2, 3, 4, 5, 6);",
+      errors: [
+        {
+          message:
+            'The warning format should be able to uniquely identify this ' +
+            'warning. Please, use a more descriptive format than: ' +
+            '%s %s, %s %s: %s (%s)',
+        },
+      ],
+    },
   ],
 });
 

eslint-rules/warning-and-invariant-args.js

@@ -49,17 +49,26 @@ module.exports = function(context) {
         );
         return;
       }
-      var str = getLiteralString(node.arguments[1]);
-      if (str === null) {
+      var format = getLiteralString(node.arguments[1]);
+      if (format === null) {
         context.report(
           node,
           'The second argument to {{name}} must be a string literal',
           {name: node.callee.name}
         );
         return;
       }
-      // count the number of string substitutions, plus the first two args
-      var expectedNArgs = (str.match(/%s/g) || []).length + 2;
+      if (format.length < 10 || /^[s\W]*$/.test(format)) {
+        context.report(
+          node,
+          'The {{name}} format should be able to uniquely identify this ' +
+          '{{name}}. Please, use a more descriptive format than: {{format}}',
+          {name: node.callee.name, format: format}
+        );
+        return;
+      }
+      // count the number of formating substitutions, plus the first two args
+      var expectedNArgs = (format.match(/%s/g) || []).length + 2;
       if (node.arguments.length !== expectedNArgs) {
         context.report(
           node,

src/shared/vendor/core/warning.js

@@ -31,13 +31,6 @@ if (__DEV__) {
       );
     }
 
-    if (format.length < 10 || /^[s\W]*$/.test(format)) {
-      throw new Error(
-        'The warning format should be able to uniquely identify this ' +
-        'warning. Please, use a more descriptive format than: ' + format
-      );
-    }
-
     if (format.indexOf('Failed Composite propType: ') === 0) {
       return; // Ignore CompositeComponent proptype check.
     }