Skip to content

Commit e27da99

Browse files
committed
[lint] Fix majority of issues eslint found
1 parent df2ddc5 commit e27da99

30 files changed

+78
-51
lines changed

src/addons/ReactRAFBatchingStrategy.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
* @typechecks static-only
1111
*/
1212

13+
/* global requestAnimationFrame:true */
14+
1315
'use strict';
1416

1517
var ExecutionEnvironment = require('ExecutionEnvironment');

src/addons/transitions/ReactCSSTransitionGroupChild.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ var ReactCSSTransitionGroupChild = React.createClass({
6464

6565
// Usually this optional callback is used for informing an owner of
6666
// a leave animation and telling it to remove the child.
67-
finishCallback && finishCallback();
67+
if (finishCallback) {
68+
finishCallback();
69+
}
6870
};
6971

7072
ReactTransitionEvents.addEndEventListener(node, endListener);

src/browser/__tests__/findDOMNode-test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,3 @@ describe('findDOMNode', function() {
4848
});
4949

5050
});
51-

src/browser/eventPlugins/BeforeInputEventPlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ var BeforeInputEventPlugin = {
490490
topLevelTarget,
491491
topLevelTargetID,
492492
nativeEvent
493-
),
493+
)
494494
];
495495
}
496496
};

src/browser/eventPlugins/FallbackCompositionState.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,19 +58,21 @@ assign(FallbackCompositionState.prototype, {
5858
return this._fallbackText;
5959
}
6060

61-
var endValue = this.getText();
61+
var start;
6262
var startValue = this._startText;
6363
var startLength = startValue.length;
64+
var end;
65+
var endValue = this.getText();
6466
var endLength = endValue.length;
6567

66-
for (var start = 0; start < startLength; start++) {
68+
for (start = 0; start < startLength; start++) {
6769
if (startValue[start] !== endValue[start]) {
6870
break;
6971
}
7072
}
7173

7274
var minEnd = startLength - start;
73-
for (var end = 1; end <= minEnd; end++) {
75+
for (end = 1; end <= minEnd; end++) {
7476
if (startValue[startLength - end] !== endValue[endLength - end]) {
7577
break;
7678
}

src/browser/eventPlugins/SelectEventPlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ function constructSelectEvent(nativeEvent) {
9494
// won't dispatch.
9595
if (mouseDown ||
9696
activeElement == null ||
97-
activeElement != getActiveElement()) {
97+
activeElement !== getActiveElement()) {
9898
return;
9999
}
100100

src/browser/findDOMNode.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ function findDOMNode(componentOrElement) {
3535
}
3636
invariant(
3737
componentOrElement.render == null ||
38-
typeof(componentOrElement.render) !== 'function',
39-
'Component (with keys: %s) contains `render` method '
40-
+'but is not mounted in the DOM',
38+
typeof componentOrElement.render !== 'function',
39+
'Component (with keys: %s) contains `render` method ' +
40+
'but is not mounted in the DOM',
4141
Object.keys(componentOrElement)
4242
);
4343
invariant(

src/browser/syntheticEvents/SyntheticClipboardEvent.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,3 @@ function SyntheticClipboardEvent(dispatchConfig, dispatchMarker, nativeEvent) {
4141
SyntheticEvent.augmentClass(SyntheticClipboardEvent, ClipboardEventInterface);
4242

4343
module.exports = SyntheticClipboardEvent;
44-

src/browser/syntheticEvents/SyntheticCompositionEvent.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,3 @@ SyntheticEvent.augmentClass(
4141
);
4242

4343
module.exports = SyntheticCompositionEvent;
44-

src/browser/syntheticEvents/SyntheticEvent.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,21 @@ assign(SyntheticEvent.prototype, {
8888
preventDefault: function() {
8989
this.defaultPrevented = true;
9090
var event = this.nativeEvent;
91-
event.preventDefault ? event.preventDefault() : event.returnValue = false;
91+
if (event.preventDefault) {
92+
event.preventDefault();
93+
} else {
94+
event.returnValue = false;
95+
}
9296
this.isDefaultPrevented = emptyFunction.thatReturnsTrue;
9397
},
9498

9599
stopPropagation: function() {
96100
var event = this.nativeEvent;
97-
event.stopPropagation ? event.stopPropagation() : event.cancelBubble = true;
101+
if (event.stopPropagation) {
102+
event.stopPropagation();
103+
} else {
104+
event.cancelBubble = true;
105+
}
98106
this.isPropagationStopped = emptyFunction.thatReturnsTrue;
99107
},
100108

0 commit comments

Comments
 (0)