Skip to content

Commit fdd7fab

Browse files
committed
Merge pull request facebook#5728 from spicyj/input-gc
Remove now-unused instancesByReactID in DOMInput
2 parents 9494ec8 + d9dabac commit fdd7fab

File tree

2 files changed

+1
-24
lines changed

2 files changed

+1
-24
lines changed

src/renderers/dom/client/wrappers/ReactDOMInput.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ var assign = require('Object.assign');
2020
var invariant = require('invariant');
2121
var warning = require('warning');
2222

23-
var instancesByReactID = {};
24-
2523
var didWarnValueLink = false;
2624
var didWarnCheckedLink = false;
2725
var didWarnValueNull = false;
@@ -148,15 +146,6 @@ var ReactDOMInput = {
148146
};
149147
},
150148

151-
mountReadyWrapper: function(inst) {
152-
// Can't be in mountWrapper or else server rendering leaks.
153-
instancesByReactID[inst._rootNodeID] = inst;
154-
},
155-
156-
unmountWrapper: function(inst) {
157-
delete instancesByReactID[inst._rootNodeID];
158-
},
159-
160149
updateWrapper: function(inst) {
161150
var props = inst._currentElement.props;
162151

src/renderers/dom/shared/ReactDOMComponent.js

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -333,10 +333,6 @@ function trapBubbledEventsLocal() {
333333
}
334334
}
335335

336-
function mountReadyInputWrapper() {
337-
ReactDOMInput.mountReadyWrapper(this);
338-
}
339-
340336
function postUpdateSelectWrapper() {
341337
ReactDOMSelect.postUpdateWrapper(this);
342338
}
@@ -582,13 +578,8 @@ ReactDOMComponent.Mixin = {
582578
}
583579

584580
switch (this._tag) {
585-
case 'input':
586-
transaction.getReactMountReady().enqueue(
587-
mountReadyInputWrapper,
588-
this
589-
);
590-
// falls through
591581
case 'button':
582+
case 'input':
592583
case 'select':
593584
case 'textarea':
594585
if (props.autoFocus) {
@@ -1033,9 +1024,6 @@ ReactDOMComponent.Mixin = {
10331024
}
10341025
}
10351026
break;
1036-
case 'input':
1037-
ReactDOMInput.unmountWrapper(this);
1038-
break;
10391027
case 'html':
10401028
case 'head':
10411029
case 'body':

0 commit comments

Comments
 (0)