[CLI-214] Added method Options.addOption(String, String), thanks to Alexandru Mocanu for the patch.

netomi · netomi · commit b2fa954b483f · 2013-02-06T14:27:48.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/trunk@1442985 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pom.xml b/pom.xml
@@ -127,6 +127,9 @@
         <role>unit tests</role>
       </roles>
     </contributor>
+    <contributor>
+      <name>Alexandru Mocanu</name>
+    </contributor>
     
   </contributors>
 
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -23,6 +23,9 @@
   <body>
     
     <release version="1.3" date="in SVN">
+      <action type="add" dev="tn" issue="CLI-214" due-to="Alexandru Mocanu">
+        Added new method Options.addOption(String, String).
+      </action>
       <action type="fix" dev="tn" issue="CLI-227" due-to="Duncan Jones">
         Changed unit tests to junit 4 annotation style.
       </action>
diff --git a/src/main/java/org/apache/commons/cli/Option.java b/src/main/java/org/apache/commons/cli/Option.java
@@ -79,6 +79,7 @@ public class Option implements Cloneable, Serializable
 
     /**
      * Creates an Option using the specified parameters.
+     * The option does not take an argument.
      *
      * @param opt short representation of the option
      * @param description describes the function of the option
diff --git a/src/main/java/org/apache/commons/cli/Options.java b/src/main/java/org/apache/commons/cli/Options.java
@@ -99,6 +99,21 @@ Collection<OptionGroup> getOptionGroups()
         return new HashSet<OptionGroup>(optionGroups.values());
     }
 
+    /**
+     * Add an option that only contains a short name.
+     * The option does not take an argument.
+     *
+     * @param opt Short single-character name of the option.
+     * @param description Self-documenting description
+     * @return the resulting Options instance
+     * @since 1.3
+     */
+    public Options addOption(String opt, String description)
+    {
+        addOption(opt, null, false, description);
+        return this;
+    }
+
     /**
      * Add an option that only contains a short-name.
      * It may be specified as requiring an argument.
@@ -111,7 +126,6 @@ Collection<OptionGroup> getOptionGroups()
     public Options addOption(String opt, boolean hasArg, String description)
     {
         addOption(opt, null, hasArg, description);
-
         return this;
     }
 
@@ -128,7 +142,6 @@ public Options addOption(String opt, boolean hasArg, String description)
     public Options addOption(String opt, String longOpt, boolean hasArg, String description)
     {
         addOption(new Option(opt, longOpt, hasArg, description));
-
         return this;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,7 @@ public class Option implements Cloneable, Serializable`
`79`	`79`
`80`	`80`	`/**`
`81`	`81`	`* Creates an Option using the specified parameters.`
	`82`	`+ * The option does not take an argument.`
`82`	`83`	`*`
`83`	`84`	`* @param opt short representation of the option`
`84`	`85`	`* @param description describes the function of the option`