Lint js files

Author: kswedberg

.eslintrc.js

@@ -1,3 +1,6 @@
 module.exports = {
-  extends: 'kswedberg/es5'
+  extends: 'kswedberg/es5',
+  rules: {
+    'comma-dangle': ['warn', 'never']
+  }
 };

Gruntfile.js

@@ -5,10 +5,9 @@ module.exports = function(grunt) {
 
   marked.setOptions({
     highlight: function(code, lang) {
-      lang = lang || 'javascript';
-      lang = hl.getLanguage(lang);
+      var language = hl.getLanguage(lang || 'javascript');
 
-      return hl.highlight(code, lang);
+      return hl.highlight(code, language);
     },
     gfm: true
   });
@@ -40,11 +39,11 @@ module.exports = function(grunt) {
           var umdHead = grunt.file.read('lib/tmpl/umdhead.tpl');
           var umdFoot = grunt.file.read('lib/tmpl/umdfoot.tpl');
 
-          src = src
+          var ret = src
           .replace('(function($) {', umdHead)
           .replace('})(jQuery);', umdFoot);
 
-          return src;
+          return ret;
         }
       }
     },
@@ -54,7 +53,7 @@ module.exports = function(grunt) {
           'jquery.<%= pluginName %>.min.js': ['<%= concat.all.dest %>']
         },
         options: {
-          banner: '<%= meta.banner %>',
+          banner: '<%= meta.banner %>'
           // preserveComments: /\/\*[\s\S]*/
         }
       }
@@ -95,8 +94,8 @@ module.exports = function(grunt) {
     eslint: {
       target: ['Gruntfile.js', 'src/**/*.js', 'test/**/*.js'],
       options: {
-        fix: true,
-        configFile: '.eslintrc.js',
+        fix: true
+        // configFile: '.eslintrc.js',
       }
     },
     version: {
@@ -115,7 +114,7 @@ module.exports = function(grunt) {
       },
       package: {
         src: ['package.json']
-      },
+      }
     }
   });
 

src/jquery.smooth-scroll.js

@@ -25,11 +25,11 @@
 
     // fn(opts) function to be called before scrolling occurs.
     // `this` is the element(s) being scrolled
-    beforeScroll: function() {},
+    beforeScroll: function() {/* empty by default */},
 
     // fn(opts) function to be called after scrolling occurs.
     // `this` is the triggering element
-    afterScroll: function() {},
+    afterScroll: function() {/* empty by default */},
 
     // easing name. jQuery comes with "swing" and "linear." For others, you'll need an easing plugin
     // from jQuery UI or elsewhere
@@ -108,7 +108,7 @@
     return scrollable;
   };
 
-  var rRelative = /^([\-\+]=)(\d+)/;
+  var rRelative = /^([-+]=)(\d+)/;
 
   $.fn.extend({
     scrollable: function(dir) {
@@ -123,9 +123,9 @@
     },
 
     smoothScroll: function(options, extra) {
-      options = options || {};
+      var userOptions = options || {};
 
-      if (options === 'options') {
+      if (userOptions === 'options') {
         if (!extra) {
           return this.first().data('ssOpts');
         }
@@ -138,7 +138,7 @@
         });
       }
 
-      var opts = $.extend({}, $.fn.smoothScroll.defaults, options);
+      var opts = $.extend({}, $.fn.smoothScroll.defaults, userOptions);
 
       var clickHandler = function(event) {
         var escapeSelector = function(str) {
@@ -324,12 +324,10 @@
 
   $.smoothScroll.version = version;
   $.smoothScroll.filterPath = function(string) {
-    string = string || '';
-
-    return string
-      .replace(/^\//, '')
-      .replace(/(?:index|default).[a-zA-Z]{3,4}$/, '')
-      .replace(/\/$/, '');
+    return (string || '')
+    .replace(/^\//, '')
+    .replace(/(?:index|default).[a-zA-Z]{3,4}$/, '')
+    .replace(/\/$/, '');
   };
 
   // default options