Remove leading slash trim in base resolver

code-asher · code-asher · commit 10c2b956ac7d · 2020-08-05T13:00:35.000-05:00
It's not necessary since we return early if the path starts with a
slash.
diff --git a/src/common/util.ts b/src/common/util.ts
@@ -48,7 +48,7 @@ export const resolveBase = (base?: string): string => {
   if (!base || base.startsWith("/")) {
     return base || ""
   }
-  const parts = location.pathname.replace(/^\//g, "").split("/")
+  const parts = location.pathname.split("/")
   parts[parts.length - 1] = base
   const url = new URL(location.origin + "/" + parts.join("/"))
   return normalize(url.pathname)

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ export const resolveBase = (base?: string): string => {`
`48`	`48`	`if (!base \|\| base.startsWith("/")) {`
`49`	`49`	`return base \|\| ""`
`50`	`50`	`}`
`51`		`- const parts = location.pathname.replace(/^\//g, "").split("/")`
	`51`	`+ const parts = location.pathname.split("/")`
`52`	`52`	`parts[parts.length - 1] = base`
`53`	`53`	`const url = new URL(location.origin + "/" + parts.join("/"))`
`54`	`54`	`return normalize(url.pathname)`