Skip to content

Commit 4685f67

Browse files
committed
Pass product configuration
1 parent 2e77c9d commit 4685f67

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

channel.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { IEnvironmentService } from "vs/platform/environment/common/environment"
1313
import { IExtensionDescription, ExtensionIdentifier } from "vs/platform/extensions/common/extensions";
1414
import { FileDeleteOptions, FileOverwriteOptions, FileType, IStat, IWatchOptions, FileOpenOptions } from "vs/platform/files/common/files";
1515
import { ILogService } from "vs/platform/log/common/log";
16+
import { IProductService } from "vs/platform/product/common/product";
1617
import { IRemoteAgentEnvironment } from "vs/platform/remote/common/remoteAgentEnvironment";
1718
import { ExtensionScanner, ExtensionScannerInput } from "vs/workbench/services/extensions/node/extensionPoints";
1819
import { DiskFileSystemProvider } from "vs/workbench/services/files/node/diskFileSystemProvider";
@@ -199,14 +200,14 @@ export class ExtensionEnvironmentChannel implements IServerChannel {
199200

200201
private async scanExtensions(locale: string): Promise<IExtensionDescription[]> {
201202
const root = getPathFromAmdModule(require, "");
202-
const pkg = require.__$__nodeRequire(path.resolve(root, "../package.json")) as any;
203+
const product = require.__$__nodeRequire(path.resolve(root, "../package.json")) as IProductService;
203204

204205
const translations = {}; // TODO: translations
205206

206207
// TODO: there is also this.environment.extensionDevelopmentLocationURI to look into.
207208
const scanBuiltin = async (): Promise<IExtensionDescription[]> => {
208209
const input = new ExtensionScannerInput(
209-
pkg.version, pkg.commit, locale, !!process.env.VSCODE_DEV,
210+
product.version, product.commit, locale, !!process.env.VSCODE_DEV,
210211
path.resolve(root, "../extensions"),
211212
true,
212213
false,
@@ -219,7 +220,7 @@ export class ExtensionEnvironmentChannel implements IServerChannel {
219220

220221
const scanInstalled = async (): Promise<IExtensionDescription[]> => {
221222
const input = new ExtensionScannerInput(
222-
pkg.version, pkg.commit, locale, !!process.env.VSCODE_DEV,
223+
product.version, product.commit, locale, !!process.env.VSCODE_DEV,
223224
this.environment.extensionsPath, false, true, translations,
224225
);
225226
return ExtensionScanner.scanExtensions(input, this.log);

server.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import * as path from "path";
55
import * as util from "util";
66
import * as url from "url";
77

8+
import { getPathFromAmdModule } from "vs/base/common/amd";
89
import { Emitter } from "vs/base/common/event";
910
import { sanitizeFilePath } from "vs/base/common/extpath";
1011
import { getMediaMime } from "vs/base/common/mime";
@@ -164,7 +165,7 @@ export class Server {
164165
remoteAuthority,
165166
},
166167
REMOTE_USER_DATA_URI: transformer.transformOutgoing(this.environmentService.webUserDataHome),
167-
PRODUCT_CONFIGURATION: null,
168+
PRODUCT_CONFIGURATION: require.__$__nodeRequire(path.resolve(getPathFromAmdModule(require, ""), "../product.json")),
168169
CONNECTION_AUTH_TOKEN: "",
169170
};
170171

0 commit comments

Comments
 (0)