Skip to content

Commit 557247a

Browse files
author
Joe Previte
committed
chore: update github-auth patch
They completely changed how auth is handled for GitHub in microsoft/vscode#145424 so our patch may not work. Will need to test and revisit.
1 parent a34e57c commit 557247a

1 file changed

Lines changed: 1 addition & 14 deletions

File tree

patches/github-auth.diff

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,11 @@ Microsoft's does not work with self-hosted instances so we run our own.
55
Also add an extra set of scopes so that tokens provided via --github-auth will
66
work for the PR extension.
77

8-
Index: code-server/lib/vscode/extensions/github-authentication/src/githubServer.ts
9-
===================================================================
10-
--- code-server.orig/lib/vscode/extensions/github-authentication/src/githubServer.ts
11-
+++ code-server/lib/vscode/extensions/github-authentication/src/githubServer.ts
12-
@@ -17,7 +17,7 @@ const localize = nls.loadMessageBundle()
13-
const CLIENT_ID = '01ab8ac9400c4e429b23';
14-
15-
const NETWORK_ERROR = 'network error';
16-
-const AUTH_RELAY_SERVER = 'vscode-auth.github.com';
17-
+const AUTH_RELAY_SERVER = 'auth.code-server.dev';
18-
// const AUTH_RELAY_STAGING_SERVER = 'client-auth-staging-14a768b.herokuapp.com';
19-
20-
class UriEventHandler extends vscode.EventEmitter<vscode.Uri> implements vscode.UriHandler {
218
Index: code-server/lib/vscode/src/vs/server/node/webClientServer.ts
229
===================================================================
2310
--- code-server.orig/lib/vscode/src/vs/server/node/webClientServer.ts
2411
+++ code-server/lib/vscode/src/vs/server/node/webClientServer.ts
25-
@@ -274,7 +274,7 @@ export class WebClientServer {
12+
@@ -277,7 +277,7 @@ export class WebClientServer {
2613
id: generateUuid(),
2714
providerId: 'github',
2815
accessToken: this._environmentService.args['github-auth'],

0 commit comments

Comments
 (0)