Bump clippy, actually run UI tests

Author: sgrif

.travis.yml

@@ -43,7 +43,7 @@ matrix:
     - rust: nightly
     - rust: beta
   include:
-  - rust: nightly-2017-11-28
+  - rust: nightly-2018-02-02
     env: CLIPPY_AND_COMPILE_TESTS=YESPLEASE
     script:
     - (cd diesel && cargo rustc --no-default-features --features "lint unstable sqlite postgres mysql extras" -- -Zno-trans)

diesel/Cargo.toml

@@ -16,7 +16,7 @@ byteorder = "1.0"
 diesel_derives = { version = "1.1.0" }
 diesel_derives2 = { path = "../diesel_derives2" }
 chrono = { version = "0.4", optional = true }
-clippy = { optional = true, version = "=0.0.174" }
+clippy = { optional = true, version = "=0.0.185" }
 libc = { version = "0.2.0", optional = true }
 libsqlite3-sys = { version = ">=0.8.0, <0.10.0", optional = true, features = ["min_sqlite_version_3_7_16"] }
 mysqlclient-sys = { version = ">=0.1.0, <0.3.0", optional = true }

diesel/src/connection/statement_cache.rs

@@ -108,15 +108,14 @@ pub struct StatementCache<DB: Backend, Statement> {
     pub cache: RefCell<HashMap<StatementCacheKey<DB>, Statement>>,
 }
 
-#[cfg_attr(feature = "clippy", allow(len_without_is_empty))]
+#[cfg_attr(feature = "clippy", allow(len_without_is_empty, new_without_default_derive))]
 impl<DB, Statement> StatementCache<DB, Statement>
 where
     DB: Backend,
     DB::TypeMetadata: Clone,
     DB::QueryBuilder: Default,
     StatementCacheKey<DB>: Hash + Eq,
 {
-    #[cfg_attr(feature = "clippy", allow(new_without_default_derive))]
     pub fn new() -> Self {
         StatementCache {
             cache: RefCell::new(HashMap::new()),

diesel/src/pg/types/uuid.rs

@@ -31,14 +31,14 @@ impl ToSql<Uuid, Pg> for uuid::Uuid {
 #[test]
 fn uuid_to_sql() {
     let mut bytes = Output::test();
-    let test_uuid = uuid::Uuid::from_fields(4_294_967_295, 65_535, 65_535, b"abcdef12").unwrap();
+    let test_uuid = uuid::Uuid::from_fields(0xFFFF_FFFF, 0xFFFF, 0xFFFF, b"abcdef12").unwrap();
     ToSql::<Uuid, Pg>::to_sql(&test_uuid, &mut bytes).unwrap();
     assert_eq!(bytes, test_uuid.as_bytes());
 }
 
 #[test]
 fn some_uuid_from_sql() {
-    let input_uuid = uuid::Uuid::from_fields(4_294_967_295, 65_535, 65_535, b"abcdef12").unwrap();
+    let input_uuid = uuid::Uuid::from_fields(0xFFFF_FFFF, 0xFFFF, 0xFFFF, b"abcdef12").unwrap();
     let output_uuid = FromSql::<Uuid, Pg>::from_sql(Some(input_uuid.as_bytes())).unwrap();
     assert_eq!(input_uuid, output_uuid);
 }

diesel/src/query_builder/bind_collector.rs

@@ -42,8 +42,8 @@ pub struct RawBytesBindCollector<DB: Backend + TypeMetadata> {
     pub binds: Vec<Option<Vec<u8>>>,
 }
 
+#[cfg_attr(feature = "clippy", allow(new_without_default_derive))]
 impl<DB: Backend + TypeMetadata> RawBytesBindCollector<DB> {
-    #[cfg_attr(feature = "clippy", allow(new_without_default_derive))]
     /// Construct an empty `RawBytesBindCollector`
     pub fn new() -> Self {
         RawBytesBindCollector {

diesel_cli/Cargo.toml

@@ -20,7 +20,7 @@ clap = "2.27"
 diesel = { version = "1.1.0", default-features = false }
 dotenv = ">=0.8, <0.11"
 infer_schema_internals = { version = "1.1.0" }
-clippy = { optional = true, version = "=0.0.174" }
+clippy = { optional = true, version = "=0.0.185" }
 migrations_internals = { version = "1.1.0" }
 url = { version = "1.4.0", optional = true }
 

diesel_compile_tests/Cargo.toml

@@ -6,8 +6,8 @@ authors = ["Sean Griffin <sean@seantheprogrammer.com>"]
 [workspace]
 
 [dependencies]
-diesel = { version = "1.1.0", features = ["extras", "sqlite", "postgres", "mysql"] }
-compiletest_rs = "=0.3.3"
+diesel = { version = "1.1.0", features = ["extras", "sqlite", "postgres", "mysql", "unstable"] }
+compiletest_rs = "=0.3.6"
 
 [replace]
 "diesel:1.1.1" = { path = "../diesel" }

diesel_compile_tests/tests/compile_tests.rs

@@ -21,6 +21,11 @@ fn run_mode(mode: &'static str) {
 }
 
 #[test]
-fn compile_test() {
+fn compile_fail() {
     run_mode("compile-fail");
 }
+
+#[test]
+fn ui() {
+    run_mode("ui")
+}

diesel_derives/Cargo.toml

@@ -11,7 +11,7 @@ repository = "https://github.com/diesel-rs/diesel/tree/master/diesel_derives"
 [dependencies]
 syn = { version = "0.11.4", features = ["aster"] }
 quote = "0.3.12"
-clippy = { optional = true, version = "=0.0.174" }
+clippy = { optional = true, version = "=0.0.185" }
 
 [dev-dependencies]
 dotenv = { version = ">=0.8, <0.11", default-features = false }

diesel_derives2/Cargo.toml

@@ -11,7 +11,7 @@ repository = "https://github.com/diesel-rs/diesel/tree/master/diesel_derives"
 [dependencies]
 syn = { version = "0.12.0", features = ["full"] }
 quote = "0.4"
-clippy = { optional = true, version = "=0.0.174" }
+clippy = { optional = true, version = "=0.0.185" }
 proc-macro2 = "0.2.0"
 
 [dev-dependencies]