Skip to content

Commit db0f20a

Browse files
authored
Apply suggestions from code review
1 parent a93fc70 commit db0f20a

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

diesel_derives/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ mod valid_grouping;
6262
/// `#[diesel(column_name = some_column_name)]`.
6363
///
6464
/// To provide custom serialization behavior for a field, you can use
65-
/// `#[diesel(serialize_as = "SomeType")]`. If this attribute is present, Diesel
65+
/// `#[diesel(serialize_as = SomeType)]`. If this attribute is present, Diesel
6666
/// will call `.into` on the corresponding field and serialize the instance of `SomeType`,
6767
/// rather than the actual field on your struct. This can be used to add custom behavior for a
6868
/// single field, or use types that are otherwise unsupported by Diesel.
@@ -97,7 +97,7 @@ mod valid_grouping;
9797
/// * `#[diesel(column_name = some_column_name)]`, overrides the column name
9898
/// of the current field to `some_column_name`. By default the field
9999
/// name is used as column name.
100-
/// * `#[diesel(serialize_as = "SomeType")]`, instead of serializing the actual
100+
/// * `#[diesel(serialize_as = SomeType)]`, instead of serializing the actual
101101
/// field type, Diesel will convert the field into `SomeType` using `.into` and
102102
/// serialize that instead. By default this derive will serialize directly using
103103
/// the actual field type.

diesel_derives/tests/as_changeset.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ fn with_explicit_column_names() {
221221
#[test]
222222
fn with_serialize_as() {
223223
#[derive(Debug, FromSqlRow, AsExpression)]
224-
#[sql_type = "sql_types::Text"]
224+
#[diesel(sql_type = sql_types::Text)]
225225
struct UppercaseString(pub String);
226226

227227
impl Into<UppercaseString> for String {

0 commit comments

Comments
 (0)