Skip to content

Commit e1777a2

Browse files
committed
fix build
1 parent 9f4b607 commit e1777a2

16 files changed

Lines changed: 16 additions & 25 deletions

diesel/src/doctest_setup.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,18 +256,22 @@ mod schema {
256256
body -> VarChar,
257257
}
258258
}
259+
259260
table! {
260261
posts {
261262
id -> Integer,
262263
user_id -> Integer,
263264
title -> VarChar,
264265
}
265266
}
267+
266268
table! {
267269
users {
268270
id -> Integer,
269271
name -> VarChar,
270272
}
271273
}
274+
275+
joinable!(posts -> users (user_id));
276+
allow_tables_to_appear_in_same_query!(comments, posts, users);
272277
}
273-
joinable!(schema::posts -> schema::users(user_id));

diesel/src/macros/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -907,8 +907,10 @@ macro_rules! __diesel_table_query_source_impl {
907907
/// # include!("../doctest_setup.rs");
908908
/// use schema::*;
909909
///
910+
/// # /*
910911
/// joinable!(posts -> users (user_id));
911912
/// allow_tables_to_appear_in_same_query!(posts, users);
913+
/// # */
912914
///
913915
/// # fn main() {
914916
/// let implicit_on_clause = users::table.inner_join(posts::table);

diesel_codegen/tests/associations.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ fn simple_belongs_to() {
2626
}
2727
}
2828

29+
allow_tables_to_appear_in_same_query!(users, posts);
30+
2931
#[derive(Identifiable)]
3032
pub struct User {
3133
id: i32,
@@ -91,6 +93,8 @@ fn custom_foreign_key() {
9193
}
9294
}
9395

96+
allow_tables_to_appear_in_same_query!(users, posts);
97+
9498
#[derive(Identifiable)]
9599
pub struct User {
96100
id: i32,
@@ -148,7 +152,6 @@ fn self_referential() {
148152
}
149153
}
150154

151-
152155
#[derive(Associations, Identifiable)]
153156
#[belongs_to(Tree, foreign_key = "parent_id")]
154157
pub struct Tree {

diesel_compile_tests/tests/compile-fail/aggregate_expression_requires_column_from_same_table.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,13 @@ fn main() {
2020
let source = users::table.select(sum(posts::id));
2121
//~^ ERROR E0277
2222
//~| ERROR AppearsInFromClause
23-
//~| ERROR E0277
2423
let source = users::table.select(avg(posts::id));
2524
//~^ ERROR E0277
2625
//~| ERROR AppearsInFromClause
27-
//~| ERROR E0277
2826
let source = users::table.select(max(posts::id));
2927
//~^ ERROR E0277
3028
//~| ERROR AppearsInFromClause
31-
//~| ERROR E0277
3229
let source = users::table.select(min(posts::id));
3330
//~^ ERROR E0277
3431
//~| ERROR AppearsInFromClause
35-
//~| ERROR E0277
3632
}

diesel_compile_tests/tests/compile-fail/any_is_only_selectable_if_inner_expr_is_selectable.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ fn main() {
3030

3131
let _ = LoadDsl::load::<Stuff>(
3232
//~^ ERROR E0277
33-
//~| ERROR E0271
3433
stuff.filter(name.eq(any(more_stuff::names))),
3534
&conn,
3635
);

diesel_compile_tests/tests/compile-fail/boxed_queries_require_selectable_expression_for_filter.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,4 @@ table! {
2121
fn main() {
2222
users::table.into_boxed::<Pg>().filter(posts::title.eq("Hello"));
2323
//~^ ERROR AppearsInFromClause
24-
//~| ERROR E0277
2524
}

diesel_compile_tests/tests/compile-fail/boxed_queries_require_selectable_expression_for_order.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,4 @@ table! {
2121
fn main() {
2222
users::table.into_boxed::<Pg>().order(posts::title.desc());
2323
//~^ ERROR AppearsInFromClause
24-
//~| ERROR E0277
2524
}

diesel_compile_tests/tests/compile-fail/cannot_join_to_non_joinable_table.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ table! {
2525
}
2626

2727
joinable!(comments -> posts (post_id));
28-
allow_tables_to_appear_in_same_query!(users, posts);
29-
allow_tables_to_appear_in_same_query!(users, comments);
28+
allow_tables_to_appear_in_same_query!(comments, posts, users);
3029

3130
fn main() {
3231
let _ = users::table.inner_join(posts::table);

diesel_compile_tests/tests/compile-fail/custom_returning_requires_selectable_expression.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,4 @@ fn main() {
3737
let stmt = insert_into(users).values(&new_user).returning((name, bad::age));
3838
//~^ ERROR SelectableExpression
3939
//~| ERROR AppearsInFromClause
40-
//~| ERROR E0277
4140
}

diesel_compile_tests/tests/compile-fail/order_requires_column_from_same_table.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,4 @@ table! {
1818
fn main() {
1919
let source = users::table.order(posts::id);
2020
//~^ ERROR E0277
21-
//~| ERROR E0271
2221
}

0 commit comments

Comments
 (0)