Skip to content

Commit 1350315

Browse files
Merge pull request dotnet-architecture#110 from BillWagner/update-to-csharp-7
Update Compiler package
2 parents 9ea27ad + 74fbbec commit 1350315

5 files changed

Lines changed: 6 additions & 9 deletions

File tree

src/Web/Catalog.WebForms/Catalog.WebForms/Catalog.WebForms.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
3+
<Import Project="..\packages\Microsoft.Net.Compilers.2.0.1\build\Microsoft.Net.Compilers.props" Condition="Exists('..\packages\Microsoft.Net.Compilers.2.0.1\build\Microsoft.Net.Compilers.props')" />
34
<Import Project="..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.1.0.3\build\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props" Condition="Exists('..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.1.0.3\build\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props')" />
4-
<Import Project="..\packages\Microsoft.Net.Compilers.1.3.2\build\Microsoft.Net.Compilers.props" Condition="Exists('..\packages\Microsoft.Net.Compilers.1.3.2\build\Microsoft.Net.Compilers.props')" />
55
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
66
<PropertyGroup>
77
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
@@ -292,8 +292,8 @@
292292
<PropertyGroup>
293293
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
294294
</PropertyGroup>
295-
<Error Condition="!Exists('..\packages\Microsoft.Net.Compilers.1.3.2\build\Microsoft.Net.Compilers.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.Net.Compilers.1.3.2\build\Microsoft.Net.Compilers.props'))" />
296295
<Error Condition="!Exists('..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.1.0.3\build\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.1.0.3\build\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props'))" />
296+
<Error Condition="!Exists('..\packages\Microsoft.Net.Compilers.2.0.1\build\Microsoft.Net.Compilers.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.Net.Compilers.2.0.1\build\Microsoft.Net.Compilers.props'))" />
297297
</Target>
298298
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
299299
Other similar extension points exist, see Microsoft.Common.targets.

src/Web/Catalog.WebForms/Catalog.WebForms/Default.aspx.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ namespace Microsoft.eShopOnContainers.Catalog.WebForms
1414
{
1515
public partial class _Default : Page
1616
{
17-
private ILifetimeScope scope;
18-
1917
private ICatalogService catalog;
2018

2119
protected _Default() { }

src/Web/Catalog.WebForms/Catalog.WebForms/Modules/AutoFacHttpModule.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,8 @@ public void Init(HttpApplication context)
5353

5454
private void InjectDependencies()
5555
{
56-
if (HttpContext.Current.CurrentHandler is Page)
56+
if (HttpContext.Current.CurrentHandler is Page page)
5757
{
58-
var page = HttpContext.Current.CurrentHandler as Page;
5958
// Get the code-behind class that we may have written
6059
var pageType = page.GetType().BaseType;
6160

src/Web/Catalog.WebForms/Catalog.WebForms/Web.config

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
-->
66
<configuration>
77
<appSettings>
8-
<add key="usefake" value="true"/>
8+
<add key="usefake" value="true" />
99
</appSettings>
1010
<system.web>
1111
<compilation debug="true" targetFramework="4.5.2" />
@@ -21,7 +21,7 @@
2121
<httpModules>
2222
<add name="ApplicationInsightsWebTracking" type="Microsoft.ApplicationInsights.Web.ApplicationInsightsHttpModule, Microsoft.AI.Web" />
2323
<!-- Use this if you are on IIS 7 and earlier -->
24-
<add name="InjectModule" type="Microsoft.eShopOnContainers.Catalog.WebForms.Modules.AutoFacHttpModule, Catalog.WebForms"/>
24+
<add name="InjectModule" type="Microsoft.eShopOnContainers.Catalog.WebForms.Modules.AutoFacHttpModule, Catalog.WebForms" />
2525
</httpModules>
2626
</system.web>
2727
<runtime>

src/Web/Catalog.WebForms/Catalog.WebForms/packages.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<package id="Microsoft.AspNet.Web.Optimization" version="1.1.3" targetFramework="net452" />
2121
<package id="Microsoft.AspNet.Web.Optimization.WebForms" version="1.1.3" targetFramework="net452" />
2222
<package id="Microsoft.CodeDom.Providers.DotNetCompilerPlatform" version="1.0.3" targetFramework="net452" />
23-
<package id="Microsoft.Net.Compilers" version="1.3.2" targetFramework="net452" developmentDependency="true" />
23+
<package id="Microsoft.Net.Compilers" version="2.0.1" targetFramework="net452" developmentDependency="true" />
2424
<package id="Microsoft.Web.Infrastructure" version="1.0.0.0" targetFramework="net452" />
2525
<package id="Modernizr" version="2.6.2" targetFramework="net452" />
2626
<package id="Newtonsoft.Json" version="6.0.4" targetFramework="net452" />

0 commit comments

Comments
 (0)