Add exceptions filters

Author: christian147

src/Services/Marketing/Marketing.API/Infrastructure/ActionResult/InternalServerErrorObjectResult.cs

@@ -0,0 +1,14 @@
+namespace Microsoft.eShopOnContainers.Services.Marketing.API.Infrastructure.ActionResults
+{
+    using AspNetCore.Http;
+    using Microsoft.AspNetCore.Mvc;
+
+    public class InternalServerErrorObjectResult : ObjectResult
+    {
+        public InternalServerErrorObjectResult(object error)
+            : base(error)
+        {
+            StatusCode = StatusCodes.Status500InternalServerError;
+        }
+    }
+}

src/Services/Marketing/Marketing.API/Infrastructure/Exceptions/MarketingDomainException.cs

@@ -0,0 +1,21 @@
+namespace Microsoft.eShopOnContainers.Services.Marketing.API.Infrastructure.Exceptions
+{
+    using System;
+
+    /// <summary>
+    /// Exception type for app exceptions
+    /// </summary>
+    public class MarketingDomainException : Exception
+    {
+        public MarketingDomainException()
+        { }
+
+        public MarketingDomainException(string message)
+            : base(message)
+        { }
+
+        public MarketingDomainException(string message, Exception innerException)
+            : base(message, innerException)
+        { }
+    }
+}

src/Services/Marketing/Marketing.API/Infrastructure/Filters/HttpGlobalExceptionFilter.cs

@@ -0,0 +1,67 @@
+namespace Microsoft.eShopOnContainers.Services.Marketing.API.Infrastructure.Filters
+{
+    using AspNetCore.Mvc;
+    using global::Microsoft.eShopOnContainers.Services.Marketing.API.Infrastructure.Exceptions;
+    using Microsoft.AspNetCore.Hosting;
+    using Microsoft.AspNetCore.Mvc.Filters;
+    using Microsoft.eShopOnContainers.Services.Marketing.API.Infrastructure.ActionResults;
+    using Microsoft.Extensions.Logging;
+    using System.Net;
+
+    public class HttpGlobalExceptionFilter : IExceptionFilter
+    {
+        private readonly IHostingEnvironment env;
+        private readonly ILogger<HttpGlobalExceptionFilter> logger;
+
+        public HttpGlobalExceptionFilter(IHostingEnvironment env, ILogger<HttpGlobalExceptionFilter> logger)
+        {
+            this.env = env;
+            this.logger = logger;
+        }
+
+        public void OnException(ExceptionContext context)
+        {
+            logger.LogError(new EventId(context.Exception.HResult),
+                context.Exception,
+                context.Exception.Message);
+
+            if (context.Exception.GetType() == typeof(MarketingDomainException)) 
+            {
+                var json = new JsonErrorResponse
+                {
+                    Messages = new[] { context.Exception.Message }
+                };
+
+                // Result asigned to a result object but in destiny the response is empty. This is a known bug of .net core 1.1
+                //It will be fixed in .net core 1.1.2. See https://github.com/aspnet/Mvc/issues/5594 for more information
+                context.Result = new BadRequestObjectResult(json);
+                context.HttpContext.Response.StatusCode = (int)HttpStatusCode.BadRequest;
+            }
+            else
+            {
+                var json = new JsonErrorResponse
+                {
+                    Messages = new[] { "An error occur.Try it again." }
+                };
+
+                if (env.IsDevelopment())
+                {
+                    json.DeveloperMessage = context.Exception;
+                }
+
+                // Result asigned to a result object but in destiny the response is empty. This is a known bug of .net core 1.1
+                // It will be fixed in .net core 1.1.2. See https://github.com/aspnet/Mvc/issues/5594 for more information
+                context.Result = new InternalServerErrorObjectResult(json);
+                context.HttpContext.Response.StatusCode = (int)HttpStatusCode.InternalServerError;                
+            }
+            context.ExceptionHandled = true;
+        }
+
+        private class JsonErrorResponse
+        {
+            public string[] Messages { get; set; }
+
+            public object DeveloperMessage { get; set; }
+        }
+    }
+}

src/Services/Marketing/Marketing.API/Startup.cs

@@ -10,6 +10,7 @@
     using Microsoft.Extensions.Logging;
     using System.Reflection;
     using System;
+    using Microsoft.eShopOnContainers.Services.Marketing.API.Infrastructure.Filters;
 
     public class Startup
     {
@@ -37,7 +38,10 @@ public Startup(IHostingEnvironment env)
         public void ConfigureServices(IServiceCollection services)
         {
             // Add framework services.
-            services.AddMvc();
+            services.AddMvc(options =>
+            {
+                options.Filters.Add(typeof(HttpGlobalExceptionFilter));
+            }).AddControllersAsServices();  //Injecting Controllers themselves thru DIFor further info see: http://docs.autofac.org/en/latest/integration/aspnetcore.html#controllers-as-services
 
             services.AddDbContext<MarketingContext>(options =>
             {