Skip to content

Commit 49c825d

Browse files
committed
Added BasePath to swagger endpoint
Override environment variables urls
1 parent 5ac3df9 commit 49c825d

18 files changed

Lines changed: 79 additions & 23 deletions

File tree

ServiceFabric/eShopOnServiceFabric/ApplicationPackageRoot/ApplicationManifest.xml

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<Parameter Name="OrderingApi_InstanceCount" DefaultValue="-1" />
1919
<Parameter Name="CatalogApi_InstanceCount" DefaultValue="-1" />
2020
<Parameter Name="BasketApi_InstanceCount" DefaultValue="-1" />
21+
<Parameter Name="IdentityUrlExternal" DefaultValue="" />
2122
</Parameters>
2223
<!-- Import the ServiceManifest from the ServicePackage. The ServiceManifestName and ServiceManifestVersion
2324
should match the Name and Version attributes of the ServiceManifest element defined in the
@@ -33,7 +34,10 @@
3334
</ServiceManifestImport>
3435
<ServiceManifestImport>
3536
<ServiceManifestRef ServiceManifestName="MarketingApiPkg" ServiceManifestVersion="1.0.0" />
36-
<ConfigOverrides />
37+
<!-- Override external urls depending on environment -->
38+
<EnvironmentOverrides CodePackageRef="Code">
39+
<EnvironmentVariable Name="IdentityUrlExternal" Value="[IdentityUrlExternal]"/>
40+
</EnvironmentOverrides>
3741
<Policies>
3842
<ContainerHostPolicies CodePackageRef="Code">
3943
<PortBinding ContainerPort="80" EndpointRef="MarketingApiTypeEndpoint"/>
@@ -51,7 +55,9 @@
5155
</ServiceManifestImport>
5256
<ServiceManifestImport>
5357
<ServiceManifestRef ServiceManifestName="LocationsApiPkg" ServiceManifestVersion="1.0.0" />
54-
<ConfigOverrides />
58+
<EnvironmentOverrides CodePackageRef="Code">
59+
<EnvironmentVariable Name="IdentityUrlExternal" Value="[IdentityUrlExternal]"/>
60+
</EnvironmentOverrides>
5561
<Policies>
5662
<ContainerHostPolicies CodePackageRef="Code">
5763
<PortBinding ContainerPort="80" EndpointRef="LocationsApiTypeEndpoint"/>
@@ -87,7 +93,9 @@
8793
</ServiceManifestImport>
8894
<ServiceManifestImport>
8995
<ServiceManifestRef ServiceManifestName="OrderingApiPkg" ServiceManifestVersion="1.0.0" />
90-
<ConfigOverrides />
96+
<EnvironmentOverrides CodePackageRef="Code">
97+
<EnvironmentVariable Name="IdentityUrlExternal" Value="[IdentityUrlExternal]"/>
98+
</EnvironmentOverrides>
9199
<Policies>
92100
<ContainerHostPolicies CodePackageRef="Code">
93101
<PortBinding ContainerPort="80" EndpointRef="OrderingApiTypeEndpoint"/>
@@ -105,7 +113,9 @@
105113
</ServiceManifestImport>
106114
<ServiceManifestImport>
107115
<ServiceManifestRef ServiceManifestName="BasketApiPkg" ServiceManifestVersion="1.0.0" />
108-
<ConfigOverrides />
116+
<EnvironmentOverrides CodePackageRef="Code">
117+
<EnvironmentVariable Name="IdentityUrlExternal" Value="[IdentityUrlExternal]"/>
118+
</EnvironmentOverrides>
109119
<Policies>
110120
<ContainerHostPolicies CodePackageRef="Code">
111121
<PortBinding ContainerPort="80" EndpointRef="BasketApiTypeEndpoint"/>

ServiceFabric/eShopOnServiceFabric/ApplicationPackageRoot/CatalogApiPkg/ServiceManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<EnvironmentVariable Name="ASPNETCORE_ENVIRONMENT" Value="Development"/>
2424
<EnvironmentVariable Name="ASPNETCORE_URLS" Value="http://0.0.0.0:80"/>
2525
<EnvironmentVariable Name="ConnectionString" Value="Data Source=sqlserver.eshoponservicefabric,5433;Database=Microsoft.eShopOnContainers.Services.CatalogDb;User Id=sa;Password=Pass@word"/>
26-
<EnvironmentVariable Name="PicBaseUrl" Value="http://your_sf_dns:19081/eShopOnServiceFabric/CatalogApi/api/v1/catalog/items/[0]/pic/"/>
26+
<EnvironmentVariable Name="PicBaseUrl" Value="http://catalogapi.eshoponservicefabric:5101/api/v1/catalog/items/[0]/pic/"/>
2727
<EnvironmentVariable Name="AzureStorageAccountName" Value=""/>
2828
<EnvironmentVariable Name="AzureStorageAccountKey" Value=""/>
2929
<EnvironmentVariable Name="UseCustomizationData" Value="True"/>

ServiceFabric/eShopOnServiceFabric/ApplicationPackageRoot/LocationsApiPkg/ServiceManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<EnvironmentVariable Name="ConnectionString" Value="mongodb://mongodb.eshoponservicefabric"/>
2626
<EnvironmentVariable Name="Database" Value="LocationsDb"/>
2727
<EnvironmentVariable Name="identityUrl" Value="http://identityapi.eshoponservicefabric:5105"/>
28-
<EnvironmentVariable Name="IdentityUrlExternal" Value="http://your_sf_dns:5105"/>
28+
<EnvironmentVariable Name="IdentityUrlExternal" Value=""/>
2929
<EnvironmentVariable Name="EventBusConnection" Value="rabbitmq.eshoponservicefabric"/>
3030
<EnvironmentVariable Name="AzureServiceBusEnabled" Value="False"/>
3131
<EnvironmentVariable Name="EventBusUserName" Value="admin"/>

ServiceFabric/eShopOnServiceFabric/ApplicationPackageRoot/MarketingApiPkg/ServiceManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<EnvironmentVariable Name="ASPNETCORE_ENVIRONMENT" Value="Development"/>
2424
<EnvironmentVariable Name="ASPNETCORE_URLS" Value="http://0.0.0.0:80"/>
2525
<EnvironmentVariable Name="ConnectionString" Value="Data Source=sqlserver.eshoponservicefabric,5433;Database=Microsoft.eShopOnContainers.Services.MarketingDb;User Id=sa;Password=Pass@word"/>
26-
<EnvironmentVariable Name="IdentityUrlExternal" Value="http://your_sf_dns:5105"/>
26+
<EnvironmentVariable Name="IdentityUrlExternal" Value=""/>
2727
<EnvironmentVariable Name="EventBusConnection" Value="rabbitmq.eshoponservicefabric"/>
2828
<EnvironmentVariable Name="AzureServiceBusEnabled" Value="False"/>
2929
<EnvironmentVariable Name="CampaignDetailFunctionUri" Value=""/>

ServiceFabric/eShopOnServiceFabric/ApplicationPackageRoot/OrderingApiPkg/ServiceManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<EnvironmentVariable Name="ASPNETCORE_URLS" Value="http://0.0.0.0:80"/>
2525
<EnvironmentVariable Name="ConnectionString" Value="Data Source=sqlserver.eshoponservicefabric,5433;Database=Microsoft.eShopOnContainers.Services.OrderingDb;User Id=sa;Password=Pass@word"/>
2626
<EnvironmentVariable Name="identityUrl" Value="http://identityapi.eshoponservicefabric:5105"/>
27-
<EnvironmentVariable Name="IdentityUrlExternal" Value="http://your_sf_dns:5105"/>
27+
<EnvironmentVariable Name="IdentityUrlExternal" Value=""/>
2828
<EnvironmentVariable Name="EventBusConnection" Value="rabbitmq.eshoponservicefabric"/>
2929
<EnvironmentVariable Name="AzureServiceBusEnabled" Value="False"/>
3030
<EnvironmentVariable Name="UseCustomizationData" Value="True"/>

ServiceFabric/eShopOnServiceFabric/ApplicationParameters/Cloud.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,6 @@
1212
<Parameter Name="OrderingApi_InstanceCount" Value="-1" />
1313
<Parameter Name="CatalogApi_InstanceCount" Value="-1" />
1414
<Parameter Name="BasketApi_InstanceCount" Value="-1" />
15+
<Parameter Name="IdentityUrlExternal" Value="http://your_sf_dns:5105" />
1516
</Parameters>
1617
</Application>

ServiceFabric/eShopOnServiceFabricIdSrv/eShopOnServiceFabricIdSrv/ApplicationPackageRoot/ApplicationManifest.xml

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,29 @@
66
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
77
<Parameters>
88
<Parameter Name="IdentityApi_InstanceCount" DefaultValue="-1" />
9+
<Parameter Name="SpaClient" DefaultValue="" />
10+
<Parameter Name="XamarinCallback" DefaultValue="" />
11+
<Parameter Name="MvcClient" DefaultValue="" />
12+
<Parameter Name="LocationApiClient" DefaultValue="" />
13+
<Parameter Name="MarketingApiClient" DefaultValue="" />
14+
<Parameter Name="BasketApiClient" DefaultValue="" />
15+
<Parameter Name="OrderingApiClient" DefaultValue="" />
916
</Parameters>
1017
<!-- Import the ServiceManifest from the ServicePackage. The ServiceManifestName and ServiceManifestVersion
1118
should match the Name and Version attributes of the ServiceManifest element defined in the
1219
ServiceManifest.xml file. -->
1320
<ServiceManifestImport>
1421
<ServiceManifestRef ServiceManifestName="IdentityApiPkg" ServiceManifestVersion="1.0.0" />
15-
<ConfigOverrides />
22+
<!-- Override external urls depending on environment -->
23+
<EnvironmentOverrides CodePackageRef="Code">
24+
<EnvironmentVariable Name="SpaClient" Value="[SpaClient]"/>
25+
<EnvironmentVariable Name="XamarinCallback" Value="[XamarinCallback]"/>
26+
<EnvironmentVariable Name="MvcClient" Value="[MvcClient]"/>
27+
<EnvironmentVariable Name="LocationApiClient" Value="[LocationApiClient]"/>
28+
<EnvironmentVariable Name="MarketingApiClient" Value="[MarketingApiClient]"/>
29+
<EnvironmentVariable Name="BasketApiClient" Value="[BasketApiClient]"/>
30+
<EnvironmentVariable Name="OrderingApiClient" Value="[OrderingApiClient]"/>
31+
</EnvironmentOverrides>
1632
<Policies>
1733
<ContainerHostPolicies CodePackageRef="Code">
1834
<PortBinding ContainerPort="80" EndpointRef="IdentityApiTypeEndpoint"/>

ServiceFabric/eShopOnServiceFabricIdSrv/eShopOnServiceFabricIdSrv/ApplicationPackageRoot/IdentityApiPkg/ServiceManifest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,21 @@
1919
</ContainerHost>
2020
</EntryPoint>
2121
<!-- Pass environment variables to your container: -->
22-
22+
2323
<EnvironmentVariables>
2424
<EnvironmentVariable Name="ASPNETCORE_ENVIRONMENT" Value="Development"/>
2525
<EnvironmentVariable Name="ASPNETCORE_URLS" Value="http://0.0.0.0:80"/>
26-
<EnvironmentVariable Name="SpaClient" Value="http://your_sf_dns:5104"/>
27-
<EnvironmentVariable Name="XamarinCallback" Value="http://your_sf_dns:5105/xamarincallback"/>
26+
<EnvironmentVariable Name="SpaClient" Value=""/>
27+
<EnvironmentVariable Name="XamarinCallback" Value=""/>
2828
<EnvironmentVariable Name="ConnectionString" Value="Data Source=sqlserver.eshoponservicefabric,5433;Database=Microsoft.eShopOnContainers.Service.IdentityDb;User Id=sa;Password=Pass@word"/>
29-
<EnvironmentVariable Name="MvcClient" Value="http://your_sf_dns:5100"/>
29+
<EnvironmentVariable Name="MvcClient" Value=""/>
3030
<EnvironmentVariable Name="LocationApiClient" Value=""/>
3131
<EnvironmentVariable Name="MarketingApiClient" Value=""/>
3232
<EnvironmentVariable Name="BasketApiClient" Value=""/>
3333
<EnvironmentVariable Name="OrderingApiClient" Value=""/>
3434
<EnvironmentVariable Name="UseCustomizationData" Value="True"/>
3535
</EnvironmentVariables>
36-
36+
3737
</CodePackage>
3838

3939
<!-- Config package is the contents of the Config directoy under PackageRoot that contains an

ServiceFabric/eShopOnServiceFabricIdSrv/eShopOnServiceFabricIdSrv/ApplicationParameters/Cloud.xml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,12 @@
22
<Application Name="fabric:/eShopOnServiceFabricIdSrv" xmlns="http://schemas.microsoft.com/2011/01/fabric" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
33
<Parameters>
44
<Parameter Name="IdentityApi_InstanceCount" Value="-1" />
5+
<Parameter Name="SpaClient" Value="http://your_sf_dns:5104" />
6+
<Parameter Name="XamarinCallback" Value="http://your_sf_dns:5105/xamarincallback" />
7+
<Parameter Name="MvcClient" Value="http://your_sf_dns:5100" />
8+
<Parameter Name="LocationApiClient" Value="http://your_sf_dns:19081/eShopOnServiceFabric/LocationsApi" />
9+
<Parameter Name="MarketingApiClient" Value="http://your_sf_dns:19081/eShopOnServiceFabric/MarketingApi" />
10+
<Parameter Name="BasketApiClient" Value="http://your_sf_dns:19081/eShopOnServiceFabric/BasketApi" />
11+
<Parameter Name="OrderingApiClient" Value="http://your_sf_dns:19081/eShopOnServiceFabric/OrderingApi" />
512
</Parameters>
6-
</Application>
13+
</Application>

ServiceFabric/eShopOnServiceFabricWebMVC/eShopOnServiceFabricWebMVC/ApplicationPackageRoot/ApplicationManifest.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,17 @@
66
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
77
<Parameters>
88
<Parameter Name="WebMVC_InstanceCount" DefaultValue="-1" />
9+
<Parameter Name="IdentityUrl" DefaultValue="" />
910
</Parameters>
1011
<!-- Import the ServiceManifest from the ServicePackage. The ServiceManifestName and ServiceManifestVersion
1112
should match the Name and Version attributes of the ServiceManifest element defined in the
1213
ServiceManifest.xml file. -->
1314
<ServiceManifestImport>
1415
<ServiceManifestRef ServiceManifestName="WebMVCPkg" ServiceManifestVersion="1.0.0" />
15-
<ConfigOverrides />
16+
<!-- Override external urls depending on environment -->
17+
<EnvironmentOverrides CodePackageRef="Code">
18+
<EnvironmentVariable Name="IdentityUrl" Value="[IdentityUrl]"/>
19+
</EnvironmentOverrides>
1620
<Policies>
1721
<ContainerHostPolicies CodePackageRef="Code">
1822
<PortBinding ContainerPort="80" EndpointRef="WebMVCTypeEndpoint"/>

0 commit comments

Comments
 (0)