Merge pull request dotnet-architecture#396 from bgrainger/fix-build

Fix build errors & warnings

Author: CESARDELATORRE

test/Services/IntegrationTests/Services/Basket/RedisBasketRepositoryTests.cs

@@ -31,7 +31,7 @@ public async Task UpdateBasket_return_and_add_basket()
             });
 
             Assert.NotNull(basket);
-            Assert.Equal(1, basket.Items.Count);
+            Assert.Single(basket.Items);
         }
 
         [Fact]

test/Services/IntegrationTests/Services/Catalog/CatalogScenarios.cs

@@ -41,7 +41,7 @@ public async Task Get_get_catalogitem_by_id_and_response_bad_request_status_code
                 var response = await server.CreateClient()
                     .GetAsync(Get.ItemById(int.MinValue));
 
-                Assert.Equal(response.StatusCode, HttpStatusCode.BadRequest);
+                Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
             }
         }
 
@@ -53,7 +53,7 @@ public async Task Get_get_catalogitem_by_id_and_response_not_found_status_code()
                 var response = await server.CreateClient()
                     .GetAsync(Get.ItemById(int.MaxValue));
 
-                Assert.Equal(response.StatusCode, HttpStatusCode.NotFound);
+                Assert.Equal( HttpStatusCode.NotFound, response.StatusCode);
             }
         }
 

test/Services/UnitTest/Ordering/Application/OrdersWebApiTest.cs

@@ -93,7 +93,7 @@ public async Task Ship_order_bad_request()
         public async Task Get_orders_success()
         {
             //Arrange
-            var fakeDynamicResult = Enumerable.Empty<object>();
+            var fakeDynamicResult = Enumerable.Empty<OrderSummary>();
             _orderQueriesMock.Setup(x => x.GetOrdersAsync())
                 .Returns(Task.FromResult(fakeDynamicResult));
 
@@ -110,7 +110,7 @@ public async Task Get_order_success()
         {
             //Arrange
             var fakeOrderId = 123;
-            var fakeDynamicResult = new Object();
+            var fakeDynamicResult = new Order();
             _orderQueriesMock.Setup(x => x.GetOrderAsync(It.IsAny<int>()))
                 .Returns(Task.FromResult(fakeDynamicResult));
 
@@ -126,7 +126,7 @@ public async Task Get_order_success()
         public async Task Get_cardTypes_success()
         {
             //Arrange
-            var fakeDynamicResult = Enumerable.Empty<object>();
+            var fakeDynamicResult = Enumerable.Empty<CardType>();
             _orderQueriesMock.Setup(x => x.GetCardTypesAsync())
                 .Returns(Task.FromResult(fakeDynamicResult));
 

test/Services/UnitTest/Ordering/Domain/OrderAggregateTest.cs

@@ -111,7 +111,6 @@ public void when_add_two_times_on_the_same_item_then_the_total_of_order_should_b
     public void Add_new_Order_raises_new_event()
     {
         //Arrange
-        var userId = new Guid();
         var street = "fakeStreet";
         var city = "FakeCity";
         var state = "fakeState";
@@ -135,7 +134,6 @@ public void Add_new_Order_raises_new_event()
     public void Add_event_Order_explicitly_raises_new_event()
     {
         //Arrange   
-        var userId = new Guid();
         var street = "fakeStreet";
         var city = "FakeCity";
         var state = "fakeState";
@@ -159,7 +157,6 @@ public void Add_event_Order_explicitly_raises_new_event()
     public void Remove_event_Order_explicitly()
     {
         //Arrange    
-        var userId = new Guid();
         var street = "fakeStreet";
         var city = "FakeCity";
         var state = "fakeState";