- Remove unused IntegrationCommands folders

- minor name changes

Author: christian147

src/Services/Catalog/Catalog.API/Catalog.API.csproj

@@ -74,9 +74,4 @@
     </None>
   </ItemGroup>
 
-  <ItemGroup>
-    <Folder Include="IntegrationCommands\CommandHandlers\" />
-    <Folder Include="IntegrationCommands\Commands\" />
-  </ItemGroup>
-
 </Project>

src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderStockRejectedIntegrationEventHandler.cs

@@ -19,11 +19,11 @@ public async Task Handle(OrderStockRejectedIntegrationEvent @event)
         {
             var orderToUpdate = await _orderRepository.GetAsync(@event.OrderId);
 
-            var orderStockNotConfirmedItems = @event.OrderStockItems
+            var orderStockRejectedItems = @event.OrderStockItems
                 .FindAll(c => !c.HasStock)
                 .Select(c => c.ProductId);
 
-            orderToUpdate.SetCancelledStatusWhenStockIsRejected(orderStockNotConfirmedItems);
+            orderToUpdate.SetCancelledStatusWhenStockIsRejected(orderStockRejectedItems);
 
             await _orderRepository.UnitOfWork.SaveEntitiesAsync();
         }

src/Services/Ordering/Ordering.API/Application/Sagas/OrderSaga.cs

@@ -17,13 +17,11 @@ public OrderSaga(OrderingContext orderingContext) : base(orderingContext)
 
         public override Order FindSagaById(int id)
         {
-            var order = _orderingContext.Orders
+            return _orderingContext.Orders
                 .Include(c => c.OrderStatus)
                 .Include(c => c.OrderItems)
                 .Include(c => c.Address)
                 .Single(c => c.Id == id);
-
-            return order;
         }
 
         public override async Task<bool> SaveChangesAsync()

src/Services/Ordering/Ordering.API/Ordering.API.csproj

@@ -79,8 +79,6 @@
   </ItemGroup>
 
   <ItemGroup>
-    <Folder Include="Application\IntegrationCommands\CommandHandlers\" />
-    <Folder Include="Application\IntegrationCommands\Commands\" />
     <Folder Include="Infrastructure\IntegrationEventMigrations\" />
   </ItemGroup>
 

src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs

@@ -156,7 +156,7 @@ public void SetCancelledStatus()
             _description = $"The order was cancelled.";
         }
 
-        public void SetCancelledStatusWhenStockIsRejected(IEnumerable<int> orderStockNotConfirmedItems)
+        public void SetCancelledStatusWhenStockIsRejected(IEnumerable<int> orderStockRejectedItems)
         {
             if (_orderStatusId != OrderStatus.AwaitingValidation.Id)
             {
@@ -165,12 +165,12 @@ public void SetCancelledStatusWhenStockIsRejected(IEnumerable<int> orderStockNot
 
             _orderStatusId = OrderStatus.Cancelled.Id;
 
-            var itemsStockNotConfirmedProductNames = OrderItems
-                .Where(c => orderStockNotConfirmedItems.Contains(c.ProductId))
+            var itemsStockRejectedProductNames = OrderItems
+                .Where(c => orderStockRejectedItems.Contains(c.ProductId))
                 .Select(c => c.GetOrderItemProductName());
 
-            var itemsStockNotConfirmedDescription = string.Join(", ", itemsStockNotConfirmedProductNames);
-            _description = $"The product items don't have stock: ({itemsStockNotConfirmedDescription}).";
+            var itemsStockRejectedDescription = string.Join(", ", itemsStockRejectedProductNames);
+            _description = $"The product items don't have stock: ({itemsStockRejectedDescription}).";
         }
 
         private void AddOrderStartedDomainEvent(string userId, int cardTypeId, string cardNumber,