Replaced async void methods with async Task methods, where appropriate.

Also removed AnimationExtensions as it’s not used.

Author: David Britch

src/Mobile/eShopOnContainers/eShopOnContainers.Core/Extensions/AnimationExtension.cs

@@ -59,7 +59,7 @@ public decimal Total
             }
         }
 
-        public ICommand AddCommand => new Command<BasketItem>(AddItem);
+        public ICommand AddCommand => new Command<BasketItem>(async (item) => await AddItemAsync(item));
 
         public ICommand CheckoutCommand => new Command(async () => await CheckoutAsync());
 
@@ -80,22 +80,22 @@ public override async Task InitializeAsync(object navigationData)
                 foreach (var basketItem in basket.Items)
                 {
                     BadgeCount += basketItem.Quantity;
-                    AddBasketItem(basketItem);
+                    await AddBasketItemAsync(basketItem);
                 }
             }
 
             MessagingCenter.Unsubscribe<CatalogViewModel, CatalogItem>(this, MessengerKeys.AddProduct);
-            MessagingCenter.Subscribe<CatalogViewModel, CatalogItem>(this, MessengerKeys.AddProduct, (sender, arg) =>
+            MessagingCenter.Subscribe<CatalogViewModel, CatalogItem>(this, MessengerKeys.AddProduct, async (sender, arg) =>
             {
                 BadgeCount++;
 
-                AddCatalogItem(arg);
+                await AddCatalogItemAsync(arg);
             });
 
             await base.InitializeAsync(navigationData);
         }
 
-        private void AddCatalogItem(CatalogItem item)
+        private async Task AddCatalogItemAsync(CatalogItem item)
         {
             BasketItems.Add(new BasketItem
             {
@@ -106,26 +106,23 @@ private void AddCatalogItem(CatalogItem item)
                 Quantity = 1
             });
 
-            ReCalculateTotal();
+            await ReCalculateTotal();
         }
 
-        private void AddItem(BasketItem item)
+        private async Task AddItemAsync(BasketItem item)
         {
             BadgeCount++;
-
-            AddBasketItem(item);
-
+            await AddBasketItemAsync(item);
             RaisePropertyChanged(() => BasketItems);
         }
 
-        private void AddBasketItem(BasketItem item)
+        private async Task AddBasketItemAsync(BasketItem item)
         {
             BasketItems.Add(item);
-
-            ReCalculateTotal();
+            await ReCalculateTotal();
         }
 
-        private async void ReCalculateTotal()
+        private async Task ReCalculateTotal()
         {
             Total = 0;
 

src/Mobile/eShopOnContainers/eShopOnContainers.Core/ViewModels/BasketViewModel.cs

@@ -88,9 +88,9 @@ public CatalogType Type
 
         public ICommand AddCatalogItemCommand => new Command<CatalogItem>(AddCatalogItem);
 
-        public ICommand FilterCommand => new Command(Filter);
+        public ICommand FilterCommand => new Command(async () => await FilterAsync());
 
-        public ICommand ClearFilterCommand => new Command(ClearFilter);
+		public ICommand ClearFilterCommand => new Command(async () => await ClearFilterAsync());
 
         public override async Task InitializeAsync(object navigationData)
         {
@@ -110,7 +110,7 @@ private void AddCatalogItem(CatalogItem catalogItem)
             MessagingCenter.Send(this, MessengerKeys.AddProduct, catalogItem);
         }
 
-        private async void Filter()
+        private async Task FilterAsync()
         {
             if (Brand == null && Type == null)
             {
@@ -126,7 +126,7 @@ private async void Filter()
             IsBusy = false;
         }
 
-        private async void ClearFilter()
+        private async Task ClearFilterAsync()
         {
             IsBusy = true;
 

src/Mobile/eShopOnContainers/eShopOnContainers.Core/ViewModels/CatalogViewModel.cs

@@ -60,7 +60,6 @@
     <Compile Include="Converters\ToUpperConverter.cs" />
     <Compile Include="Effects\LineColorEffect.cs" />
     <Compile Include="Exceptions\ServiceAuthenticationException.cs" />
-    <Compile Include="Extensions\AnimationExtension.cs" />
     <Compile Include="Extensions\ObservableExtension.cs" />
     <Compile Include="GlobalSettings.cs" />
     <Compile Include="Helpers\EasingHelper.cs" />