Skip to content

Commit 8b3bd3b

Browse files
David BritchDavid Britch
authored andcommitted
Ensured that calls to NavigationService.NavigateAsync are awaited.
1 parent 4299c05 commit 8b3bd3b

5 files changed

Lines changed: 19 additions & 19 deletions

File tree

src/Mobile/eShopOnContainers/eShopOnContainers.Core/ViewModels/BasketViewModel.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public decimal Total
6363

6464
public ICommand AddCommand => new Command<BasketItem>(AddItem);
6565

66-
public ICommand CheckoutCommand => new Command(Checkout);
66+
public ICommand CheckoutCommand => new Command(async () => await CheckoutAsync());
6767

6868
public override async Task InitializeAsync(object navigationData)
6969
{
@@ -151,11 +151,11 @@ await _basketService.UpdateBasketAsync(new CustomerBasket
151151
}, authToken);
152152
}
153153

154-
private void Checkout()
154+
private async Task CheckoutAsync()
155155
{
156156
if (BasketItems.Any())
157157
{
158-
NavigationService.NavigateToAsync<CheckoutViewModel>(BasketItems);
158+
await NavigationService.NavigateToAsync<CheckoutViewModel>(BasketItems);
159159
}
160160
}
161161
}

src/Mobile/eShopOnContainers/eShopOnContainers.Core/ViewModels/CheckoutViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public Address ShippingAddress
6666
}
6767
}
6868

69-
public ICommand CheckoutCommand => new Command(Checkout);
69+
public ICommand CheckoutCommand => new Command(async () => await CheckoutAsync());
7070

7171
public override async Task InitializeAsync(object navigationData)
7272
{
@@ -125,7 +125,7 @@ public override async Task InitializeAsync(object navigationData)
125125
}
126126
}
127127

128-
private async void Checkout()
128+
private async Task CheckoutAsync()
129129
{
130130
try
131131
{

src/Mobile/eShopOnContainers/eShopOnContainers.Core/ViewModels/LoginViewModel.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,15 @@ public string LoginUrl
121121
}
122122
}
123123

124-
public ICommand MockSignInCommand => new Command(MockSignInAsync);
124+
public ICommand MockSignInCommand => new Command(async () => await MockSignInAsync());
125125

126126
public ICommand SignInCommand => new Command(async () => await SignInAsync());
127127

128128
public ICommand RegisterCommand => new Command(Register);
129129

130-
public ICommand NavigateCommand => new Command<string>(NavigateAsync);
130+
public ICommand NavigateCommand => new Command<string>(async (url) => await NavigateAsync(url));
131131

132-
public ICommand SettingsCommand => new Command(SettingsAsync);
132+
public ICommand SettingsCommand => new Command(async () => await SettingsAsync());
133133

134134
public override Task InitializeAsync(object navigationData)
135135
{
@@ -146,7 +146,7 @@ public override Task InitializeAsync(object navigationData)
146146
return base.InitializeAsync(navigationData);
147147
}
148148

149-
private async void MockSignInAsync()
149+
private async Task MockSignInAsync()
150150
{
151151
IsBusy = true;
152152
IsValid = true;
@@ -219,7 +219,7 @@ private void Logout()
219219
}
220220
}
221221

222-
private async void NavigateAsync(string url)
222+
private async Task NavigateAsync(string url)
223223
{
224224
if (url.Equals(GlobalSetting.Instance.LogoutCallback))
225225
{
@@ -246,7 +246,7 @@ private async void NavigateAsync(string url)
246246
}
247247
}
248248

249-
private async void SettingsAsync()
249+
private async Task SettingsAsync()
250250
{
251251
await NavigationService.NavigateToAsync<SettingsViewModel>();
252252
}

src/Mobile/eShopOnContainers/eShopOnContainers.Core/ViewModels/MainViewModel.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace eShopOnContainers.Core.ViewModels
99
{
1010
public class MainViewModel : ViewModelBase
1111
{
12-
public ICommand SettingsCommand => new Command(Settings);
12+
public ICommand SettingsCommand => new Command(async () => await SettingsAsync());
1313

1414
public override Task InitializeAsync(object navigationData)
1515
{
@@ -25,9 +25,9 @@ public override Task InitializeAsync(object navigationData)
2525
return base.InitializeAsync(navigationData);
2626
}
2727

28-
private void Settings()
28+
private async Task SettingsAsync()
2929
{
30-
NavigationService.NavigateToAsync<SettingsViewModel>();
30+
await NavigationService.NavigateToAsync<SettingsViewModel>();
3131
}
3232
}
3333
}

src/Mobile/eShopOnContainers/eShopOnContainers.Core/ViewModels/ProfileViewModel.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ public ObservableCollection<Order> Orders
3232
}
3333
}
3434

35-
public ICommand LogoutCommand => new Command(LogoutAsync);
35+
public ICommand LogoutCommand => new Command(async () => await LogoutAsync());
3636

37-
public ICommand OrderDetailCommand => new Command<Order>(OrderDetail);
37+
public ICommand OrderDetailCommand => new Command<Order>(async (order) => await OrderDetailAsync(order));
3838

3939
public override async Task InitializeAsync(object navigationData)
4040
{
@@ -48,7 +48,7 @@ public override async Task InitializeAsync(object navigationData)
4848
IsBusy = false;
4949
}
5050

51-
private async void LogoutAsync()
51+
private async Task LogoutAsync()
5252
{
5353
IsBusy = true;
5454

@@ -59,9 +59,9 @@ private async void LogoutAsync()
5959
IsBusy = false;
6060
}
6161

62-
private void OrderDetail(Order order)
62+
private async Task OrderDetailAsync(Order order)
6363
{
64-
NavigationService.NavigateToAsync<OrderDetailViewModel>(order);
64+
await NavigationService.NavigateToAsync<OrderDetailViewModel>(order);
6565
}
6666
}
6767
}

0 commit comments

Comments
 (0)