minor changes

christian147 · christian147 · commit 8b80eeae5237 · 2017-05-17T00:40:40.000+02:00
diff --git a/src/Services/Basket/Basket.API/Startup.cs b/src/Services/Basket/Basket.API/Startup.cs
@@ -165,12 +165,6 @@ protected virtual void ConfigureAuth(IApplicationBuilder app)
 
         protected virtual void ConfigureEventBus(IApplicationBuilder app)
         {
-            var catalogPriceHandler = app.ApplicationServices
-                .GetService<IIntegrationEventHandler<ProductPriceChangedIntegrationEvent>>();
-
-            var orderStartedHandler = app.ApplicationServices
-                .GetService<IIntegrationEventHandler<OrderStartedIntegrationEvent>>();
-
             var eventBus = app.ApplicationServices.GetRequiredService<IEventBus>();
 
             eventBus.Subscribe<ProductPriceChangedIntegrationEvent, ProductPriceChangedIntegrationEventHandler>();
diff --git a/src/Services/Catalog/Catalog.API/IntegrationCommands/CommandHandlers/DecrementOrderStockCommandMsgHandler.cs b/src/Services/Catalog/Catalog.API/IntegrationCommands/CommandHandlers/DecrementOrderStockCommandMsgHandler.cs
@@ -3,9 +3,6 @@
     using BuildingBlocks.EventBus.Abstractions;
     using System.Threading.Tasks;
     using Infrastructure;
-    using global::Catalog.API.Infrastructure.Exceptions;
-    using global::Catalog.API.IntegrationEvents;
-    using Model;
     using Commands;
 
     public class DecrementOrderStockCommandMsgHandler : IIntegrationEventHandler<DecrementOrderStockCommandMsg>
diff --git a/src/Services/Catalog/Catalog.API/Startup.cs b/src/Services/Catalog/Catalog.API/Startup.cs
@@ -121,10 +121,7 @@ public IServiceProvider ConfigureServices(IServiceCollection services)
                 return new DefaultRabbitMQPersistentConnection(factory, logger);
             });
 
-            services.AddSingleton<IEventBusSubscriptionsManager, InMemoryEventBusSubscriptionsManager>();
-            services.AddSingleton<IEventBus, EventBusRabbitMQ>();
-            services.AddTransient<IIntegrationEventHandler<ConfirmOrderStockCommandMsg>, ConfirmOrderStockCommandMsgHandler>();
-            services.AddTransient<IIntegrationEventHandler<DecrementOrderStockCommandMsg>, DecrementOrderStockCommandMsgHandler>();
+            RegisterServiceBus(services);
 
             var container = new ContainerBuilder();
             container.Populate(services);
@@ -188,6 +185,18 @@ private void WaitForSqlAvailability(CatalogContext ctx, ILoggerFactory loggerFac
             }
         }
 
+        private void RegisterServiceBus(IServiceCollection services)
+        {
+            services.AddSingleton<IEventBusSubscriptionsManager, InMemoryEventBusSubscriptionsManager>();
+            services.AddSingleton<IEventBus, EventBusRabbitMQ>();
+
+            services.AddTransient<IIntegrationEventHandler<ConfirmOrderStockCommandMsg>,
+                ConfirmOrderStockCommandMsgHandler>();
+            services.AddTransient<IIntegrationEventHandler<DecrementOrderStockCommandMsg>,
+                DecrementOrderStockCommandMsgHandler>();
+
+        }
+
         private void ConfigureEventBus(IApplicationBuilder app)
         {
             var eventBus = app.ApplicationServices.GetRequiredService<IEventBus>();
diff --git a/src/Services/Ordering/Ordering.API/Application/Commands/CreateOrderCommandHandler.cs b/src/Services/Ordering/Ordering.API/Application/Commands/CreateOrderCommandHandler.cs
@@ -43,7 +43,7 @@ public async Task<bool> Handle(CreateOrderCommand message)
             // make sure that consistency is preserved across the whole aggregate
             var address = new Address(message.Street, message.City, message.State, message.Country, message.ZipCode);
             var order = new Order(message.UserId, address, message.CardTypeId, message.CardNumber, message.CardSecurityNumber, message.CardHolderName, message.CardExpiration);
-            order.SetSubmitedStatus();
+            
             foreach (var item in message.OrderItems)
             {
                 order.AddOrderItem(item.ProductId, item.ProductName, item.UnitPrice, item.Discount, item.PictureUrl, item.Units);
diff --git a/src/Services/Ordering/Ordering.API/Application/DomainEventHandlers/OrderGracePeriodConfirmed/OrderStatusChangedToAwaitingValidationDomainEventHandler.cs b/src/Services/Ordering/Ordering.API/Application/DomainEventHandlers/OrderGracePeriodConfirmed/OrderStatusChangedToAwaitingValidationDomainEventHandler.cs
@@ -28,8 +28,6 @@ public OrderStatusChangedToAwaitingValidationDomainEventHandler(
 
         public async Task Handle(OrderStatusChangedToAwaitingValidationDomainEvent orderStatusChangedToAwaitingValidationDomainEvent)
         {
-            await _orderRepository.UnitOfWork.SaveEntitiesAsync();
-
             _logger.CreateLogger(nameof(OrderStatusChangedToAwaitingValidationDomainEvent))
                 .LogTrace($"Order with Id: {orderStatusChangedToAwaitingValidationDomainEvent.OrderId} has been successfully updated with " +
                           $"a status order id: {OrderStatus.AwaitingValidation.Id}");
diff --git a/src/Services/Ordering/Ordering.API/Application/DomainEventHandlers/OrderPaid/OrderStatusChangedToPaidDomainEventHandler.cs b/src/Services/Ordering/Ordering.API/Application/DomainEventHandlers/OrderPaid/OrderStatusChangedToPaidDomainEventHandler.cs
@@ -28,8 +28,6 @@ public OrderStatusChangedToPaidDomainEventHandler(
 
         public async Task Handle(OrderStatusChangedToPaidDomainEvent orderStatusChangedToPaidDomainEvent)
         {
-            await _orderRepository.UnitOfWork.SaveEntitiesAsync();
-
             _logger.CreateLogger(nameof(OrderStatusChangedToPaidDomainEventHandler))
                 .LogTrace($"Order with Id: {orderStatusChangedToPaidDomainEvent.OrderId} has been successfully updated with " +
                           $"a status order id: {OrderStatus.Paid.Id}");
diff --git a/src/Services/Ordering/Ordering.API/Application/DomainEventHandlers/OrderStockConfirmed/OrderStatusChangedToStockConfirmedDomainEventHandler.cs b/src/Services/Ordering/Ordering.API/Application/DomainEventHandlers/OrderStockConfirmed/OrderStatusChangedToStockConfirmedDomainEventHandler.cs
@@ -27,8 +27,6 @@ public OrderStatusChangedToStockConfirmedDomainEventHandler(
 
         public async Task Handle(OrderStatusChangedToStockConfirmedDomainEvent orderStatusChangedToStockConfirmedDomainEvent)
         {
-            await _orderRepository.UnitOfWork.SaveEntitiesAsync();
-
             _logger.CreateLogger(nameof(OrderStatusChangedToStockConfirmedDomainEventHandler))
                 .LogTrace($"Order with Id: {orderStatusChangedToStockConfirmedDomainEvent.OrderId} has been successfully updated with " +
                           $"a status order id: {OrderStatus.StockConfirmed.Id}");
diff --git a/src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderPaymentFailedIntegrationEventHandler.cs b/src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderPaymentFailedIntegrationEventHandler.cs
@@ -21,7 +21,7 @@ public async Task Handle(OrderPaymentFailedIntegrationEvent @event)
 
             orderToUpdate.SetCancelledStatus();
 
-            await _orderRepository.UnitOfWork.SaveChangesAsync();
+            await _orderRepository.UnitOfWork.SaveEntitiesAsync();
         }
     }
 }
diff --git a/src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderPaymentSuccededIntegrationEventHandler.cs b/src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderPaymentSuccededIntegrationEventHandler.cs
@@ -21,7 +21,7 @@ public async Task Handle(OrderPaymentSuccededIntegrationEvent @event)
 
             orderToUpdate.SetPaidStatus();
 
-            await _orderRepository.UnitOfWork.SaveChangesAsync();
+            await _orderRepository.UnitOfWork.SaveEntitiesAsync();
         }
     }
 }
diff --git a/src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderStockConfirmedIntegrationEventHandler.cs b/src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderStockConfirmedIntegrationEventHandler.cs
@@ -21,7 +21,7 @@ public async Task Handle(OrderStockConfirmedIntegrationEvent @event)
 
             orderToUpdate.SetStockConfirmedStatus();
 
-            await _orderRepository.UnitOfWork.SaveChangesAsync();
+            await _orderRepository.UnitOfWork.SaveEntitiesAsync();
         }
     }
 }
diff --git a/src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderStockNotConfirmedIntegrationEventHandler.cs b/src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderStockNotConfirmedIntegrationEventHandler.cs
@@ -27,7 +27,7 @@ public async Task Handle(OrderStockNotConfirmedIntegrationEvent @event)
 
             orderToUpdate.SetStockConfirmedStatus(orderStockNotConfirmedItems);
 
-            await _orderRepository.UnitOfWork.SaveChangesAsync();
+            await _orderRepository.UnitOfWork.SaveEntitiesAsync();
         }
     }
 }
diff --git a/src/Services/Ordering/Ordering.API/Application/Sagas/OrderProcessSaga.cs b/src/Services/Ordering/Ordering.API/Application/Sagas/OrderProcessSaga.cs
@@ -48,11 +48,8 @@ public async Task Handle(ConfirmGracePeriodCommandMsg command)
             var orderSaga = FindSagaById(command.OrderId);
             CheckValidSagaId(orderSaga);
 
-            if (orderSaga.OrderStatus != OrderStatus.Cancelled)
-            {
-                orderSaga.SetAwaitingValidationStatus();
-                await SaveChangesAsync();
-            }
+            orderSaga.SetAwaitingValidationStatus();
+            await SaveChangesAsync();
         }
         
         /// <summary>
@@ -67,14 +64,9 @@ public async Task<bool> Handle(CancelOrderCommand command)
             var orderSaga = FindSagaById(command.OrderNumber);
             CheckValidSagaId(orderSaga);
 
-            // Not possible to cancel order when 
-            // it has already been shipped
-            if (orderSaga.GetOrderStatusId() != OrderStatus.Cancelled.Id
-                || orderSaga.GetOrderStatusId() != OrderStatus.Shipped.Id)
-            {
-                orderSaga.SetCancelledStatus();
-                result = await SaveChangesAsync();
-            }
+            orderSaga.SetCancelledStatus();
+            result = await SaveChangesAsync();
+            
             return result;
         }
 
@@ -90,13 +82,9 @@ public async Task<bool> Handle(ShipOrderCommand command)
             var orderSaga = FindSagaById(command.OrderNumber);
             CheckValidSagaId(orderSaga);
 
-            // Only ship order when 
-            // its status is paid
-            if (orderSaga.GetOrderStatusId() == OrderStatus.Paid.Id)
-            {
-                orderSaga.SetShippedStatus();
-                result = await SaveChangesAsync();
-            }
+            orderSaga.SetShippedStatus();
+            result = await SaveChangesAsync();
+            
             return result;
         }
 
diff --git a/src/Services/Ordering/Ordering.API/Startup.cs b/src/Services/Ordering/Ordering.API/Startup.cs
@@ -8,8 +8,6 @@
     using global::Ordering.API.Application.IntegrationEvents.Events;
     using global::Ordering.API.Application.Sagas;
     using global::Ordering.API.Infrastructure.Middlewares;
-    using global::Ordering.API.Application.IntegrationCommands.Commands;
-    using global::Ordering.API.Application.Sagas;
     using Infrastructure;
     using Infrastructure.Auth;
     using Infrastructure.AutofacModules;
@@ -126,18 +124,7 @@ public IServiceProvider ConfigureServices(IServiceCollection services)
                 return new DefaultRabbitMQPersistentConnection(factory, logger);
             });
 
-            services.AddSingleton<IEventBus, EventBusRabbitMQ>();
-            services.AddSingleton<IEventBusSubscriptionsManager, InMemoryEventBusSubscriptionsManager>();
-            services.AddTransient<IIntegrationEventHandler<UserCheckoutAcceptedIntegrationEvent>>();
-            services.AddTransient<IIntegrationEventHandler<ConfirmGracePeriodCommandMsg>, OrderProcessSaga>();
-            services.AddTransient<IIntegrationEventHandler<OrderStockConfirmedIntegrationEvent>, 
-                OrderStockConfirmedIntegrationEventHandler>();
-            services.AddTransient<IIntegrationEventHandler<OrderStockNotConfirmedIntegrationEvent>, 
-                OrderStockNotConfirmedIntegrationEventHandler>();
-            services.AddTransient<IIntegrationEventHandler<OrderPaymentFailedIntegrationEvent>,
-                OrderPaymentFailedIntegrationEventHandler>();
-            services.AddTransient<IIntegrationEventHandler<OrderPaymentSuccededIntegrationEvent>,
-                OrderPaymentSuccededIntegrationEventHandler>();
+            RegisterServiceBus(services);
             services.AddOptions();
 
             //configure autofac
@@ -178,6 +165,23 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerF
 
         }
 
+        private void RegisterServiceBus(IServiceCollection services)
+        {
+            services.AddSingleton<IEventBus, EventBusRabbitMQ>();
+            services.AddSingleton<IEventBusSubscriptionsManager, InMemoryEventBusSubscriptionsManager>();
+
+            services.AddTransient<IIntegrationEventHandler<UserCheckoutAcceptedIntegrationEvent>>();
+            services.AddTransient<IIntegrationEventHandler<ConfirmGracePeriodCommandMsg>, OrderProcessSaga>();
+            services.AddTransient<IIntegrationEventHandler<OrderStockConfirmedIntegrationEvent>,
+                OrderStockConfirmedIntegrationEventHandler>();
+            services.AddTransient<IIntegrationEventHandler<OrderStockNotConfirmedIntegrationEvent>,
+                OrderStockNotConfirmedIntegrationEventHandler>();
+            services.AddTransient<IIntegrationEventHandler<OrderPaymentFailedIntegrationEvent>,
+                OrderPaymentFailedIntegrationEventHandler>();
+            services.AddTransient<IIntegrationEventHandler<OrderPaymentSuccededIntegrationEvent>,
+                OrderPaymentSuccededIntegrationEventHandler>();
+        }
+
         private void ConfigureEventBus(IApplicationBuilder app)
         {
             var eventBus = app.ApplicationServices.GetRequiredService<IEventBus>();
diff --git a/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs b/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs
@@ -95,14 +95,11 @@ public void SetBuyerId(int id)
         }
 
         #region Status Changes
-        public void SetSubmitedStatus()
-        {
-            _orderStatusId = OrderStatus.Submited.Id;
-        }
 
         public void SetAwaitingValidationStatus()
         {
-            if (_orderStatusId != OrderStatus.Submited.Id)
+            if (_orderStatusId != OrderStatus.Submited.Id &&
+                _orderStatusId != OrderStatus.Cancelled.Id)
             {
                 StatusChangeException();
             }  
@@ -167,7 +164,7 @@ public void SetCancelledStatus()
         {
             if (_orderStatusId == OrderStatus.Submited.Id)
             {
-                _description = "The order was cancelled before the grace period was confirm.";
+                _description = "The order was cancelled before the grace period was confirmed.";
             }
             else if (_orderStatusId == OrderStatus.AwaitingValidation.Id)
             {
@@ -191,11 +188,6 @@ public void SetCancelledStatus()
 
         #endregion
 
-        public int GetOrderStatusId()
-        {
-            return _orderStatusId;
-        }
-
         private void AddOrderStartedDomainEvent(string userId, int cardTypeId, string cardNumber,
                 string cardSecurityNumber, string cardHolderName, DateTime cardExpiration)
         {
diff --git a/src/Services/SagaManager/SagaManager/IntegrationEvents/Events/ConfirmGracePeriodCommandMsg.cs b/src/Services/SagaManager/SagaManager/IntegrationEvents/Events/ConfirmGracePeriodCommandMsg.cs
@@ -2,13 +2,10 @@
 {
     using Microsoft.eShopOnContainers.BuildingBlocks.EventBus.Events;
 
-    // Integration Events notes: 
-    // An Event is “something that has happened in the past”, therefore its name has to be   
-    // An Integration Event is an event that can cause side effects to other microsrvices, Bounded-Contexts or external systems.
     public class ConfirmGracePeriodCommandMsg : IntegrationEvent
     {
         public int OrderId { get;}
 
         public ConfirmGracePeriodCommandMsg(int orderId) => OrderId = orderId;
     }
-}
+}
diff --git a/src/Services/SagaManager/SagaManager/IntegrationEvents/SagaManagerIntegrationEventService.cs b/src/Services/SagaManager/SagaManager/IntegrationEvents/SagaManagerIntegrationEventService.cs
@@ -9,13 +9,9 @@ public class SagaManagerIntegrationEventService : ISagaManagerIntegrationEventSe
         private readonly IEventBus _eventBus;
 
         public SagaManagerIntegrationEventService(IEventBus eventBus)
-        {
-            _eventBus = eventBus ?? throw new ArgumentNullException(nameof(eventBus));
-        }
+            => _eventBus = eventBus ?? throw new ArgumentNullException(nameof(eventBus));
 
-        public void PublishThroughEventBus(IntegrationEvent evt)
-        {
-            _eventBus.Publish(evt);
-        }
+
+        public void PublishThroughEventBus(IntegrationEvent evt) => _eventBus.Publish(evt);
     }
 }
diff --git a/src/Services/SagaManager/SagaManager/Program.cs b/src/Services/SagaManager/SagaManager/Program.cs
@@ -1,34 +1,27 @@
-﻿using System.Reflection;
-using Microsoft.eShopOnContainers.BuildingBlocks.EventBus;
-using Microsoft.eShopOnContainers.Services.Ordering.Infrastructure;
-using Microsoft.EntityFrameworkCore;
-using SagaManager.IntegrationEvents;
-
-namespace SagaManager
+﻿namespace SagaManager
 {
     using System.IO;
     using System;
+    using System.Threading.Tasks;
+    using Autofac.Extensions.DependencyInjection;
+    using Autofac;
     using Microsoft.Extensions.Configuration;
     using Microsoft.Extensions.DependencyInjection;
     using Microsoft.eShopOnContainers.BuildingBlocks.EventBus.Abstractions;
     using Microsoft.eShopOnContainers.BuildingBlocks.EventBusRabbitMQ;
+    using Microsoft.eShopOnContainers.BuildingBlocks.EventBus;
     using Microsoft.Extensions.Logging;
     using Microsoft.Extensions.Options;
     using RabbitMQ.Client;
     using Services;
-    using Autofac.Extensions.DependencyInjection;
-    using Autofac;
-    using System.Threading.Tasks;
+    using IntegrationEvents;
 
     public class Program
     {
         public static IConfigurationRoot Configuration { get; set; }
 
-        public static void Main(string[] args)
-        {
-            MainAsync().Wait();
-        }
-
+        public static void Main(string[] args) => MainAsync().Wait();
+        
         static async Task MainAsync()
         {
             StartUp();
@@ -45,7 +38,7 @@ static async Task MainAsync()
             while (true)
             {
                 sagaManagerService.CheckFinishedGracePeriodOrders();
-                await Task.Delay(30000);
+                await Task.Delay(300000);
             }
         }
 
@@ -66,8 +59,7 @@ public static IServiceProvider ConfigureServices(IServiceCollection services)
                 .Configure<SagaManagerSettings>(Configuration)
                 .AddSingleton<ISagaManagerService, SagaManagerService>()
                 .AddSingleton<ISagaManagerIntegrationEventService, SagaManagerIntegrationEventService>()
-                .AddSingleton<IEventBus, EventBusRabbitMQ>()
-                .AddSingleton<IEventBusSubscriptionsManager, InMemoryEventBusSubscriptionsManager>()
+
                 .AddSingleton<IRabbitMQPersistentConnection>(sp =>
                 {
                     var settings = sp.GetRequiredService<IOptions<SagaManagerSettings>>().Value;
@@ -78,8 +70,7 @@ public static IServiceProvider ConfigureServices(IServiceCollection services)
                     };
 
                     return new DefaultRabbitMQPersistentConnection(factory, logger);
-                })
-                .AddSingleton<IEventBus, EventBusRabbitMQ>();
+                });
 
                 RegisterServiceBus(services);
 
diff --git a/src/Services/SagaManager/SagaManager/Services/SagaManagerService.cs b/src/Services/SagaManager/SagaManager/Services/SagaManagerService.cs

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public async Task<bool> Handle(CreateOrderCommand message)`
`43`	`43`	`// make sure that consistency is preserved across the whole aggregate`
`44`	`44`	`var address = new Address(message.Street, message.City, message.State, message.Country, message.ZipCode);`
`45`	`45`	`var order = new Order(message.UserId, address, message.CardTypeId, message.CardNumber, message.CardSecurityNumber, message.CardHolderName, message.CardExpiration);`
`46`		`- order.SetSubmitedStatus();`
	`46`	`+`
`47`	`47`	`foreach (var item in message.OrderItems)`
`48`	`48`	`{`
`49`	`49`	`order.AddOrderItem(item.ProductId, item.ProductName, item.UnitPrice, item.Discount, item.PictureUrl, item.Units);`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,6 @@ public OrderStatusChangedToAwaitingValidationDomainEventHandler(`
`28`	`28`
`29`	`29`	`public async Task Handle(OrderStatusChangedToAwaitingValidationDomainEvent orderStatusChangedToAwaitingValidationDomainEvent)`
`30`	`30`	`{`
`31`		`- await _orderRepository.UnitOfWork.SaveEntitiesAsync();`
`32`		`-`
`33`	`31`	`_logger.CreateLogger(nameof(OrderStatusChangedToAwaitingValidationDomainEvent))`
`34`	`32`	`.LogTrace($"Order with Id: {orderStatusChangedToAwaitingValidationDomainEvent.OrderId} has been successfully updated with " +`
`35`	`33`	`$"a status order id: {OrderStatus.AwaitingValidation.Id}");`
Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,6 @@ public OrderStatusChangedToStockConfirmedDomainEventHandler(`
`27`	`27`
`28`	`28`	`public async Task Handle(OrderStatusChangedToStockConfirmedDomainEvent orderStatusChangedToStockConfirmedDomainEvent)`
`29`	`29`	`{`
`30`		`- await _orderRepository.UnitOfWork.SaveEntitiesAsync();`
`31`		`-`
`32`	`30`	`_logger.CreateLogger(nameof(OrderStatusChangedToStockConfirmedDomainEventHandler))`
`33`	`31`	`.LogTrace($"Order with Id: {orderStatusChangedToStockConfirmedDomainEvent.OrderId} has been successfully updated with " +`
`34`	`32`	`$"a status order id: {OrderStatus.StockConfirmed.Id}");`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public async Task Handle(OrderPaymentFailedIntegrationEvent @event)`
`21`	`21`
`22`	`22`	`orderToUpdate.SetCancelledStatus();`
`23`	`23`
`24`		`- await _orderRepository.UnitOfWork.SaveChangesAsync();`
	`24`	`+ await _orderRepository.UnitOfWork.SaveEntitiesAsync();`
`25`	`25`	`}`
`26`	`26`	`}`
`27`	`27`	`}`