Skip to content

Commit a1f4082

Browse files
committed
Minor copy updates
Added rename TODO suggestion for CatalogSettings
1 parent a0db135 commit a1f4082

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/Services/Basket/Basket.API/Controllers/BasketController.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
namespace Microsoft.eShopOnContainers.Services.Basket.API.Controllers
1010
{
1111
//TODO NOTE: Right now this is a very chunky API, as the app evolves it is possible we would
12-
//want to make the actions more fine graned, add basket item as an action for example.
12+
//want to make the actions more fine grained, add basket item as an action for example.
1313
//If this is the case we should also investigate changing the serialization format used for Redis,
1414
//using a HashSet instead of a simple string.
1515
[Route("/")]

src/Services/Catalog/Catalog.API/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ Sample reference containerized application, cross-platform and microservices arc
33
Powered by Microsoft
44

55
#Overview
6-
This sample runs a microservices oriented application and a .net core Mvc application that consumes this services. You can find more information about how to set up docker in your machine in the global directory solution.
6+
This sample runs a microservices oriented application and an ASP.NET Core MVC application that consumes these services. You can find more information about how to set up docker in your machine in the global directory solution.
77

88
#Deploy
9-
In the global directory you will find the scripts needed to run and deploy the demo into your local docker infraestructure.
9+
In the global directory you will find the scripts needed to run and deploy the demo into your local docker infrastructure.
1010

11-
- <a href='build-image-services-catalog.ps1'>build-image-services-catalog.ps1</a> <b>Build .net applications and docker images</b>: This power shell script that you will find in the <u>root directory of the solution</u> is the responsible of building .net applications and package in a pub folder and use docker commands to build the images needed to run the previously packaged .net applications.
11+
- <a href='build-image-services-catalog.ps1'>build-image-services-catalog.ps1</a> <b>Build .net applications and docker images</b>: This PowerShell script that you will find in the <u>root directory of the solution</u> is responsible for building .NET applications and package in a pub folder and use docker commands to build the images needed to run the previously packaged .NET applications.
1212

1313
- <b>Compose containers in your docker local VM</b>: Finally you have to open your favourite command tool pointing to the <u>root directory of this project</u> where docker-compose.yml file is located and run the command `docker-compose up`
1414

src/Services/Catalog/Catalog.API/settings.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
namespace Microsoft.eShopOnContainers.Services.Catalog.API
77
{
8+
// TODO: Rename CatalogSettings for consistency?
89
public class Settings
910
{
1011
public string ExternalCatalogBaseUrl {get;set;}

0 commit comments

Comments
 (0)