Merge pull request dotnet-architecture#122 from dotnet/bugs/dotnet-architecture#75-NoRetryLoginAtCatch

Removed the catch with retry logic from CatalogContextSeed

Author: CESARDELATORRE

src/Services/Catalog/Catalog.API/Infrastructure/CatalogContextSeed.cs

@@ -13,47 +13,33 @@ public class CatalogContextSeed
     {
         public static async Task SeedAsync(IApplicationBuilder applicationBuilder, ILoggerFactory loggerFactory, int? retry = 0)
         {
-            int retryForAvaiability = retry.Value;
-            try
-            {
-                var context = (CatalogContext)applicationBuilder
-                    .ApplicationServices.GetService(typeof(CatalogContext));
-
-                context.Database.Migrate();
+            var context = (CatalogContext)applicationBuilder
+                .ApplicationServices.GetService(typeof(CatalogContext));
 
-                if (!context.CatalogBrands.Any())
-                {
-                    context.CatalogBrands.AddRange(
-                        GetPreconfiguredCatalogBrands());
+            context.Database.Migrate();
 
-                    await context.SaveChangesAsync();
-                }
-
-                if (!context.CatalogTypes.Any())
-                {
-                    context.CatalogTypes.AddRange(
-                        GetPreconfiguredCatalogTypes());
+            if (!context.CatalogBrands.Any())
+            {
+                context.CatalogBrands.AddRange(
+                    GetPreconfiguredCatalogBrands());
 
-                    await context.SaveChangesAsync();
-                }
+                await context.SaveChangesAsync();
+            }
 
-                if (!context.CatalogItems.Any())
-                {
-                    context.CatalogItems.AddRange(
-                        GetPreconfiguredItems());
+            if (!context.CatalogTypes.Any())
+            {
+                context.CatalogTypes.AddRange(
+                    GetPreconfiguredCatalogTypes());
 
-                    await context.SaveChangesAsync();
-                }
+                await context.SaveChangesAsync();
             }
-            catch (Exception ex)
+
+            if (!context.CatalogItems.Any())
             {
-                if (retryForAvaiability < 10)
-                {
-                    retryForAvaiability++;
-                    var log = loggerFactory.CreateLogger("catalog seed");
-                    log.LogError(ex.Message);
-                    await SeedAsync(applicationBuilder, loggerFactory, retryForAvaiability);
-                }
+                context.CatalogItems.AddRange(
+                    GetPreconfiguredItems());
+
+                await context.SaveChangesAsync();
             }
         }
 

src/Services/Catalog/Catalog.API/Startup.cs

@@ -11,6 +11,7 @@
     using Microsoft.Extensions.DependencyInjection;
     using Microsoft.Extensions.Logging;
     using System;
+    using System.Data.SqlClient;
     using System.IO;
     using System.Reflection;
     using System.Threading;
@@ -95,11 +96,35 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerF
             app.UseSwagger()
               .UseSwaggerUi();
 
+            var context = (CatalogContext)app
+                        .ApplicationServices.GetService(typeof(CatalogContext));
+
+            WaitForSqlAvailability(context, loggerFactory);
             //Seed Data
             CatalogContextSeed.SeedAsync(app, loggerFactory)
-            .Wait();
+            .Wait();            
+        }
 
-            
+        private void WaitForSqlAvailability(CatalogContext ctx, ILoggerFactory loggerFactory, int? retry = 0)
+        {
+            int retryForAvailability = retry.Value;            
+            try
+            {
+                ctx.Database.OpenConnection();
+            }
+            catch(SqlException ex)
+            {
+                if (retryForAvailability < 10)
+                {
+                    retryForAvailability++;
+                    var log = loggerFactory.CreateLogger(nameof(Startup));
+                    log.LogError(ex.Message);
+                    WaitForSqlAvailability(ctx, loggerFactory, retryForAvailability);
+                }
+            }
+            finally {
+                ctx.Database.CloseConnection(); 
+            }
         }
     }
 }