Merge branch 'order-processflow-redesign' of https://github.com/dotnet-architecture/eShopOnContainers into order-processflow-redesign

Author: ramon-tomas-c

src/Services/Catalog/Catalog.API/IntegrationCommands/CommandHandlers/DecrementOrderStockCommandMsgHandler.cs

@@ -23,20 +23,11 @@ public async Task Handle(DecrementOrderStockCommandMsg @event)
             foreach (var orderStockItem in @event.OrderStockItems)
             {
                 var catalogItem = _catalogContext.CatalogItems.Find(orderStockItem.ProductId);
-                CheckValidcatalogItemId(catalogItem);
 
                 catalogItem.RemoveStock(orderStockItem.Units);
             }
 
             await _catalogContext.SaveChangesAsync();
         }
-
-        private void CheckValidcatalogItemId(CatalogItem catalogItem)
-        {
-            if (catalogItem is null)
-            {
-                throw new CatalogDomainException("Not able to process catalog event. Reason: no valid catalogItemId");
-            }
-        }
     }
 }

src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderPaymentFailedIntegrationEventHandler.cs

@@ -17,7 +17,9 @@ public OrderPaymentFailedIntegrationEventHandler(IOrderRepository orderRepositor
 
         public async Task Handle(OrderPaymentFailedIntegrationEvent @event)
         {
-            //TODO: Cancel Order
+            var orderToUpdate = await _orderRepository.GetAsync(@event.OrderId);
+
+            orderToUpdate.SetCancelledStatus();
         }
     }
 }

src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderPaymentSuccededIntegrationEventHandler.cs

@@ -3,7 +3,6 @@
     using Microsoft.eShopOnContainers.BuildingBlocks.EventBus.Abstractions;
     using Microsoft.eShopOnContainers.Services.Ordering.Domain.AggregatesModel.OrderAggregate;
     using Ordering.API.Application.IntegrationEvents.Events;
-    using Ordering.Domain.Exceptions;
     using System.Threading.Tasks;
 
     public class OrderPaymentSuccededIntegrationEventHandler : 
@@ -18,18 +17,9 @@ public OrderPaymentSuccededIntegrationEventHandler(IOrderRepository orderReposit
 
         public async Task Handle(OrderPaymentSuccededIntegrationEvent @event)
         {
-            var order = await _orderRepository.GetAsync(@event.OrderId);
-            CheckValidSagaId(order);
+            var orderToUpdate = await _orderRepository.GetAsync(@event.OrderId);
 
-            order.SetPaidStatus();
-        }
-
-        private void CheckValidSagaId(Order orderSaga)
-        {
-            if (orderSaga is null)
-            {
-                throw new OrderingDomainException("Not able to process order saga event. Reason: no valid orderId");
-            }
+            orderToUpdate.SetPaidStatus();
         }
     }
 }

src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderStockConfirmedIntegrationEventHandler.cs

@@ -4,8 +4,6 @@
     using System.Threading.Tasks;
     using Events;
     using Microsoft.eShopOnContainers.Services.Ordering.Domain.AggregatesModel.OrderAggregate;
-    using Ordering.API.Application.IntegrationCommands.Commands;
-    using Ordering.Domain.Exceptions;
 
     public class OrderStockConfirmedIntegrationEventHandler : 
         IIntegrationEventHandler<OrderStockConfirmedIntegrationEvent>
@@ -19,18 +17,9 @@ public OrderStockConfirmedIntegrationEventHandler(IOrderRepository orderReposito
 
         public async Task Handle(OrderStockConfirmedIntegrationEvent @event)
         {
-            var order = await _orderRepository.GetAsync(@event.OrderId);
-            CheckValidSagaId(order);
+            var orderToUpdate = await _orderRepository.GetAsync(@event.OrderId);
 
-            order.SetStockConfirmedStatus();
-        }
-
-        private void CheckValidSagaId(Order orderSaga)
-        {
-            if (orderSaga is null)
-            {
-                throw new OrderingDomainException("Not able to process order saga event. Reason: no valid orderId");
-            }
+            orderToUpdate.SetStockConfirmedStatus();
         }
     }
 }

src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/OrderStockNotConfirmedIntegrationEventHandler.cs

@@ -4,11 +4,9 @@
 namespace Ordering.API.Application.IntegrationEvents.EventHandling
 {
     using Microsoft.eShopOnContainers.BuildingBlocks.EventBus.Abstractions;
-    using System;
     using System.Threading.Tasks;
     using Events;
     using Microsoft.eShopOnContainers.Services.Ordering.Domain.AggregatesModel.OrderAggregate;
-    using Domain.Exceptions;
 
     public class OrderStockNotConfirmedIntegrationEventHandler : IIntegrationEventHandler<OrderStockNotConfirmedIntegrationEvent>
     {
@@ -22,21 +20,12 @@ public OrderStockNotConfirmedIntegrationEventHandler(IOrderRepository orderRepos
         public async Task Handle(OrderStockNotConfirmedIntegrationEvent @event)
         {
             var orderToUpdate = await _orderRepository.GetAsync(@event.OrderId);
-            CheckValidSagaId(orderToUpdate);
 
             var orderStockNotConfirmedItems = @event.OrderStockItems
                 .FindAll(c => !c.Confirmed)
                 .Select(c => c.ProductId);
 
             orderToUpdate.SetStockConfirmedStatus(orderStockNotConfirmedItems);
         }
-
-        private void CheckValidSagaId(Order orderSaga)
-        {
-            if (orderSaga is null)
-            {
-                throw new OrderingDomainException("Not able to process order saga event. Reason: no valid orderId");
-            }
-        }
     }
 }

src/Services/Ordering/Ordering.API/Application/Sagas/OrderProcessSaga.cs

@@ -73,7 +73,7 @@ public async Task<bool> Handle(CancelOrderCommand command)
             if (orderSaga.GetOrderStatusId() != OrderStatus.Cancelled.Id
                 || orderSaga.GetOrderStatusId() != OrderStatus.Shipped.Id)
             {
-                orderSaga.SetCancelStatus();
+                orderSaga.SetCancelledStatus();
                 result = await SaveChangesAsync();
             }
             return result;

src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs

@@ -166,14 +166,31 @@ public void SetShippedStatus()
             //Call Domain Event
         }
 
-        public void SetCancelStatus()
+        public void SetCancelledStatus()
         {
-            if (_orderStatusId == OrderStatus.Shipped.Id)
+            if (_orderStatusId == OrderStatus.Submited.Id)
             {
-                throw new OrderingDomainException("Not possible to change order status. Reason: cannot cancel order it is already shipped");
+                _description = "The order was cancelled before the grace period was confirm.";
             }
+            else if (_orderStatusId == OrderStatus.AwaitingValidation.Id)
+            {
+                _description = "The order was cancelled before to check the order stock items.";
+            }
+            else if (_orderStatusId == OrderStatus.StockConfirmed.Id)
+            {
+                _description = "The order was cancelled before to pay the order.";
+            }
+            else if (_orderStatusId == OrderStatus.Paid.Id)
+            {
+                _description = "The order was cancelled before to ship the order.";
+            }
+            else if(_orderStatusId == OrderStatus.Shipped.Id)
+            {
+                throw new OrderingDomainException("Not possible to change order status. Reason: cannot cancel order it is already shipped.");
+            }
+
             _orderStatusId = OrderStatus.Cancelled.Id;
-        }        
+        }
 
         #endregion
 

src/Services/Ordering/Ordering.Infrastructure/Repositories/OrderRepository.cs

@@ -1,6 +1,7 @@
 using Microsoft.EntityFrameworkCore;
 using Microsoft.eShopOnContainers.Services.Ordering.Domain.AggregatesModel.OrderAggregate;
 using Microsoft.eShopOnContainers.Services.Ordering.Domain.Seedwork;
+using Ordering.Domain.Exceptions;
 using System;
 using System.Threading.Tasks;
 

src/Services/Payment/Payment.API/IntegrationCommands/CommandHandlers/PayOrderCommandMsgHandler.cs

@@ -4,16 +4,25 @@
     using Payment.API.IntegrationCommands.Commands;
     using System.Threading.Tasks;
     using System;
+    using Payment.API.IntegrationEvents;
+    using Payment.API.IntegrationEvents.Events;
 
     public class PayOrderCommandMsgHandler : IIntegrationEventHandler<PayOrderCommandMsg>
     {
-        public PayOrderCommandMsgHandler()
-        {
-        }
+        private readonly IPaymentIntegrationEventService _paymentIntegrationEventService;
+
+        public PayOrderCommandMsgHandler(IPaymentIntegrationEventService paymentIntegrationEventService)
+            => _paymentIntegrationEventService = paymentIntegrationEventService;
 
         public async Task Handle(PayOrderCommandMsg @event)
         {
-            throw new NotImplementedException();
+            //PAYMENT SUCCESSED
+            var orderPaymentSuccededIntegrationEvent = new OrderPaymentSuccededIntegrationEvent(@event.OrderId);
+            _paymentIntegrationEventService.PublishThroughEventBus(orderPaymentSuccededIntegrationEvent);
+
+            //PAYMENT FAILED
+            //var orderPaymentFailedIntegrationEvent = new OrderPaymentFailedIntegrationEvent(@event.OrderId);
+            //_paymentIntegrationEventService.PublishThroughEventBus(orderPaymentFailedIntegrationEvent);
         }
     }
 }

src/Services/Payment/Payment.API/IntegrationEvents/IPaymentIntegrationEventService.cs

@@ -0,0 +1,9 @@
+namespace Payment.API.IntegrationEvents
+{
+    using Microsoft.eShopOnContainers.BuildingBlocks.EventBus.Events;
+
+    public interface IPaymentIntegrationEventService
+    {
+        void PublishThroughEventBus(IntegrationEvent evt);
+    }
+}