Skip to content

Commit e596926

Browse files
committed
add comment about known bug in .net core 1.1
1 parent 5fed56d commit e596926

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

src/Services/Ordering/Ordering.API/Infrastructure/Filters/HttpGlobalExceptionFilter.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ public void OnException(ExceptionContext context)
3232
Messages = new[] { context.Exception.Message }
3333
};
3434

35+
// Result asigned to a result object but in destiny the response is empty. This is a known bug of .net core 1.1
36+
//It will be fixed in .net core 1.1.2. See https://github.com/aspnet/Mvc/issues/5594 for more information
3537
context.Result = new BadRequestObjectResult(json);
3638
context.HttpContext.Response.StatusCode = (int)HttpStatusCode.BadRequest;
3739
}
@@ -47,6 +49,8 @@ public void OnException(ExceptionContext context)
4749
json.DeveloperMeesage = context.Exception;
4850
}
4951

52+
// Result asigned to a result object but in destiny the response is empty. This is a known bug of .net core 1.1
53+
// It will be fixed in .net core 1.1.2. See https://github.com/aspnet/Mvc/issues/5594 for more information
5054
context.Result = new InternalServerErrorObjectResult(json);
5155
context.HttpContext.Response.StatusCode = (int)HttpStatusCode.InternalServerError;
5256
}

0 commit comments

Comments
 (0)