Refactored code related to Idempotent CommandHandlers

Author: CESARDELATORRE

src/Services/Ordering/Ordering.API/Application/Commands/CancelOrderCommandHandler.cs

@@ -9,9 +9,10 @@
 
 namespace Ordering.API.Application.Commands
 {
-    public class CancelOrderCommandIdentifiedHandler : IdentifierCommandHandler<CancelOrderCommand, bool>
+    // Use for Idempotency in Command process
+    public class CancelOrderCommandIdempotentHandler : IdentifiedCommandHandler<CancelOrderCommand, bool>
     {
-        public CancelOrderCommandIdentifiedHandler(IMediator mediator, IRequestManager requestManager) : base(mediator, requestManager)
+        public CancelOrderCommandIdempotentHandler(IMediator mediator, IRequestManager requestManager) : base(mediator, requestManager)
         {
         }
 
@@ -21,6 +22,7 @@ protected override bool CreateResultForDuplicateRequest()
         }
     }
 
+    // Regular CommandHandler
     public class CancelOrderCommandHandler : IAsyncRequestHandler<CancelOrderCommand, bool>
     {
         private readonly IOrderRepository _orderRepository;

src/Services/Ordering/Ordering.API/Application/Commands/CreateOrderCommandHandler.cs

@@ -7,10 +7,10 @@
     using System;
     using System.Threading.Tasks;
 
-
-    public class CreateOrderCommandIdentifiedHandler : IdentifierCommandHandler<CreateOrderCommand, bool>
+    // Use for Idempotency in Command process
+    public class CreateOrderCommandIdempotentHandler : IdentifiedCommandHandler<CreateOrderCommand, bool>
     {
-        public CreateOrderCommandIdentifiedHandler(IMediator mediator, IRequestManager requestManager) : base(mediator, requestManager)
+        public CreateOrderCommandIdempotentHandler(IMediator mediator, IRequestManager requestManager) : base(mediator, requestManager)
         {
         }
 
@@ -20,6 +20,7 @@ protected override bool CreateResultForDuplicateRequest()
         }
     }
 
+    // Regular CommandHandler
     public class CreateOrderCommandHandler
         : IAsyncRequestHandler<CreateOrderCommand, bool>
     {

…ion/Commands/IdentifierCommandHandler.cs …ion/Commands/IdentifiedCommandHandler.cssrc/Services/Ordering/Ordering.API/Application/Commands/IdentifierCommandHandler.cs renamed to src/Services/Ordering/Ordering.API/Application/Commands/IdentifiedCommandHandler.cs src/Services/Ordering/Ordering.API/Application/Commands/IdentifierCommandHandler.cs renamed to src/Services/Ordering/Ordering.API/Application/Commands/IdentifiedCommandHandler.cs

@@ -10,13 +10,13 @@ namespace Microsoft.eShopOnContainers.Services.Ordering.API.Application.Commands
     /// </summary>
     /// <typeparam name="T">Type of the command handler that performs the operation if request is not duplicated</typeparam>
     /// <typeparam name="R">Return value of the inner command handler</typeparam>
-    public class IdentifierCommandHandler<T, R> : IAsyncRequestHandler<IdentifiedCommand<T, R>, R>
+    public class IdentifiedCommandHandler<T, R> : IAsyncRequestHandler<IdentifiedCommand<T, R>, R>
         where T : IRequest<R>
     {
         private readonly IMediator _mediator;
         private readonly IRequestManager _requestManager;
 
-        public IdentifierCommandHandler(IMediator mediator, IRequestManager requestManager)
+        public IdentifiedCommandHandler(IMediator mediator, IRequestManager requestManager)
         {
             _mediator = mediator;
             _requestManager = requestManager;
@@ -48,6 +48,7 @@ public async Task<R> Handle(IdentifiedCommand<T, R> message)
             {
                 await _requestManager.CreateRequestForCommandAsync<T>(message.Id);
 
+                // Send the embeded business command to mediator so it runs its related CommandHandler 
                 var result = await _mediator.Send(message.Command);
 
                 return result;

src/Services/Ordering/Ordering.API/Application/Commands/ShipOrderCommandHandler.cs

@@ -6,9 +6,10 @@
 
 namespace Ordering.API.Application.Commands
 {
-    public class ShipOrderCommandIdentifiedHandler : IdentifierCommandHandler<ShipOrderCommand, bool>
+    // Use for Idempotency in Command process
+    public class ShipOrderCommandIdempotentHandler : IdentifiedCommandHandler<ShipOrderCommand, bool>
     {
-        public ShipOrderCommandIdentifiedHandler(IMediator mediator, IRequestManager requestManager) : base(mediator, requestManager)
+        public ShipOrderCommandIdempotentHandler(IMediator mediator, IRequestManager requestManager) : base(mediator, requestManager)
         {
         }
 
@@ -18,6 +19,7 @@ protected override bool CreateResultForDuplicateRequest()
         }
     }
 
+    // Regular CommandHandler
     public class ShipOrderCommandHandler : IAsyncRequestHandler<ShipOrderCommand, bool>
     {        
         private readonly IOrderRepository _orderRepository;

…alidations/IdentifierCommandValidator.cs …alidations/IdentifiedCommandValidator.cssrc/Services/Ordering/Ordering.API/Application/Validations/IdentifierCommandValidator.cs renamed to src/Services/Ordering/Ordering.API/Application/Validations/IdentifiedCommandValidator.cs src/Services/Ordering/Ordering.API/Application/Validations/IdentifierCommandValidator.cs renamed to src/Services/Ordering/Ordering.API/Application/Validations/IdentifiedCommandValidator.cs

@@ -3,9 +3,9 @@
 
 namespace Ordering.API.Application.Validations
 {
-    public class IdentifierCommandValidator : AbstractValidator<IdentifiedCommand<CreateOrderCommand,bool>>
+    public class IdentifiedCommandValidator : AbstractValidator<IdentifiedCommand<CreateOrderCommand,bool>>
     {
-        public IdentifierCommandValidator()
+        public IdentifiedCommandValidator()
         {
             RuleFor(command => command.Id).NotEmpty();    
         }

…lication/IdentifierCommandHandlerTest.cs …lication/IdentifiedCommandHandlerTest.cstest/Services/UnitTest/Ordering/Application/IdentifierCommandHandlerTest.cs renamed to test/Services/UnitTest/Ordering/Application/IdentifiedCommandHandlerTest.cs test/Services/UnitTest/Ordering/Application/IdentifierCommandHandlerTest.cs renamed to test/Services/UnitTest/Ordering/Application/IdentifiedCommandHandlerTest.cs

@@ -13,12 +13,12 @@ namespace UnitTest.Ordering.Application
     using System.Collections.Generic;
     using System.Threading.Tasks;
     using Xunit;
-    public class IdentifierCommandHandlerTest
+    public class IdentifiedCommandHandlerTest
     {
         private readonly Mock<IRequestManager> _requestManager;
         private readonly Mock<IMediator> _mediator;
 
-        public IdentifierCommandHandlerTest()
+        public IdentifiedCommandHandlerTest()
         {
             _requestManager = new Mock<IRequestManager>();
             _mediator = new Mock<IMediator>();
@@ -38,7 +38,7 @@ public async Task Handler_sends_command_when_order_no_exists()
                .Returns(Task.FromResult(true));
 
             //Act
-            var handler = new IdentifierCommandHandler<CreateOrderCommand, bool>(_mediator.Object, _requestManager.Object);
+            var handler = new IdentifiedCommandHandler<CreateOrderCommand, bool>(_mediator.Object, _requestManager.Object);
             var result = await handler.Handle(fakeOrderCmd);
 
             //Assert
@@ -60,7 +60,7 @@ public async Task Handler_sends_no_command_when_order_already_exists()
                .Returns(Task.FromResult(true));
 
             //Act
-            var handler = new IdentifierCommandHandler<CreateOrderCommand, bool>(_mediator.Object, _requestManager.Object);
+            var handler = new IdentifiedCommandHandler<CreateOrderCommand, bool>(_mediator.Object, _requestManager.Object);
             var result = await handler.Handle(fakeOrderCmd);
 
             //Assert