Check when the user doesn't have any location in database

Author: christian147

src/Services/Marketing/Marketing.API/Controllers/CampaignsController.cs

@@ -7,12 +7,12 @@
     using AspNetCore.Mvc;
     using Infrastructure;
     using System.Threading.Tasks;
-    using Catalog.API.ViewModel;
     using Model;
     using EntityFrameworkCore;
     using Dto;
     using AspNetCore.Authorization;
     using Extensions.Options;
+    using Microsoft.eShopOnContainers.Services.Marketing.API.ViewModel;
 
     [Route("api/v1/[controller]")]
     [Authorize]
@@ -129,29 +129,27 @@ public async Task<IActionResult> GetCampaignsByUserId(Guid userId, int pageSize
         {
             var marketingData = await _marketingDataRepository.GetAsync(userId.ToString());
 
-            if (marketingData is null)
-            {
-                return NotFound();
-            }
-
             var campaignDtoList = new List<CampaignDTO>();
 
-            //Get User Location Campaign
-            foreach (var userLocation in marketingData.Locations)
+            if (marketingData != null)
             {
-                var userCampaignList = await _context.Rules
-                    .OfType<UserLocationRule>()
-                    .Include(c => c.Campaign)
-                    .Where(c => c.Campaign.From <= DateTime.Now
-                    && c.Campaign.To >= DateTime.Now
-                    && c.LocationId == userLocation.LocationId)
-                    .Select(c => c.Campaign)
-                    .ToListAsync();
-
-                if (userCampaignList != null && userCampaignList.Any())
+                //Get User Location Campaign
+                foreach (var userLocation in marketingData.Locations)
                 {
-                    var userCampaignDtoList = MapCampaignModelListToDtoList(userCampaignList);
-                    campaignDtoList.AddRange(userCampaignDtoList);
+                    var userCampaignList = await _context.Rules
+                        .OfType<UserLocationRule>()
+                        .Include(c => c.Campaign)
+                        .Where(c => c.Campaign.From <= DateTime.Now
+                        && c.Campaign.To >= DateTime.Now
+                        && c.LocationId == userLocation.LocationId)
+                        .Select(c => c.Campaign)
+                        .ToListAsync();
+
+                    if (userCampaignList != null && userCampaignList.Any())
+                    {
+                        var userCampaignDtoList = MapCampaignModelListToDtoList(userCampaignList);
+                        campaignDtoList.AddRange(userCampaignDtoList);
+                    }
                 }
             }
 

src/Services/Marketing/Marketing.API/ViewModel/PaginatedItemsViewModel.cs

@@ -1,8 +1,7 @@
-namespace Microsoft.eShopOnContainers.Services.Catalog.API.ViewModel
+namespace Microsoft.eShopOnContainers.Services.Marketing.API.ViewModel
 {
     using System.Collections.Generic;
 
-
     public class PaginatedItemsViewModel<TEntity> where TEntity : class
     {
         public int PageIndex { get; private set; }
@@ -21,4 +20,4 @@ public PaginatedItemsViewModel(int pageIndex, int pageSize, long count, IEnumera
             this.Data = data;
         }
     }
-}
+}

src/Web/WebMVC/Controllers/CampaignsController.cs

@@ -1,6 +1,3 @@
-using Microsoft.EntityFrameworkCore.Query.Internal;
-using WebMVC.ViewModels;
-
 namespace Microsoft.eShopOnContainers.WebMVC.Controllers
 {
     using AspNetCore.Authorization;
@@ -10,6 +7,7 @@ namespace Microsoft.eShopOnContainers.WebMVC.Controllers
     using System.Threading.Tasks;
     using System;
     using ViewModels.Pagination;
+    using global::WebMVC.ViewModels;
 
     [Authorize]
     public class CampaignsController : Controller