Fix issue identityService.getuseridentity fails when called from integration event

Author: ramon-tomas-c

src/Services/Ordering/Ordering.API/Application/Commands/CreateOrderCommand.cs

@@ -23,6 +23,9 @@ public class CreateOrderCommand
         [DataMember]
         private readonly List<OrderItemDTO> _orderItems;
 
+        [DataMember]
+        public string UserId { get; private set; }
+
         [DataMember]
         public string City { get; private set; }
 
@@ -61,11 +64,12 @@ public CreateOrderCommand()
             _orderItems = new List<OrderItemDTO>();
         }
 
-        public CreateOrderCommand(List<BasketItem> basketItems, string city, string street, string state, string country, string zipcode,
+        public CreateOrderCommand(List<BasketItem> basketItems, string userId, string city, string street, string state, string country, string zipcode,
             string cardNumber, string cardHolderName, DateTime cardExpiration,
             string cardSecurityNumber, int cardTypeId) : this()
         {
             _orderItems = MapToOrderItems(basketItems);
+            UserId = userId;
             City = city;
             Street = street;
             State = state;

src/Services/Ordering/Ordering.API/Application/Commands/CreateOrderCommandHandler.cs

@@ -42,7 +42,7 @@ public async Task<bool> Handle(CreateOrderCommand message)
             // methods and constructor so validations, invariants and business logic 
             // make sure that consistency is preserved across the whole aggregate
             var address = new Address(message.Street, message.City, message.State, message.Country, message.ZipCode);
-            var order = new Order(address , message.CardTypeId, message.CardNumber, message.CardSecurityNumber, message.CardHolderName, message.CardExpiration);
+            var order = new Order(message.UserId, address, message.CardTypeId, message.CardNumber, message.CardSecurityNumber, message.CardHolderName, message.CardExpiration);
             order.SetOrderStatusId(OrderStatus.Submited.Id);
             foreach (var item in message.OrderItems)
             {

src/Services/Ordering/Ordering.API/Application/DomainEventHandlers/OrderStartedEvent/ValidateOrAddBuyerAggregateWhenOrderStartedDomainEventHandler.cs

@@ -26,14 +26,14 @@ public async Task Handle(OrderStartedDomainEvent orderStartedEvent)
         {
             var cardTypeId = (orderStartedEvent.CardTypeId != 0) ? orderStartedEvent.CardTypeId : 1;
 
-            var userGuid = _identityService.GetUserIdentity();
+            //var userGuid = _identityService.GetUserIdentity();
 
-            var buyer = await _buyerRepository.FindAsync(userGuid);
+            var buyer = await _buyerRepository.FindAsync(orderStartedEvent.UserId);
             bool buyerOriginallyExisted = (buyer == null) ? false : true;
 
             if (!buyerOriginallyExisted)
             {                
-                buyer = new Buyer(userGuid);
+                buyer = new Buyer(orderStartedEvent.UserId);
             }
 
             buyer.VerifyOrAddPaymentMethod(cardTypeId,

src/Services/Ordering/Ordering.API/Application/IntegrationEvents/EventHandling/UserCheckoutAcceptedIntegrationEventHandler.cs

@@ -14,7 +14,6 @@ public class UserCheckoutAcceptedIntegrationEventHandler : IIntegrationEventHand
         private readonly ILoggerFactory _logger;
 
         public UserCheckoutAcceptedIntegrationEventHandler(IMediator mediator,
-            IOrderingIntegrationEventService orderingIntegrationEventService,
             ILoggerFactory logger)
         {
             _mediator = mediator ?? throw new ArgumentNullException(nameof(mediator));
@@ -35,7 +34,7 @@ public async Task Handle(UserCheckoutAcceptedIntegrationEvent eventMsg)
             var result = false;
             if (eventMsg.RequestId != Guid.Empty)
             {
-                var createOrderCommand = new CreateOrderCommand(eventMsg.Basket.Items, eventMsg.City, eventMsg.Street, 
+                var createOrderCommand = new CreateOrderCommand(eventMsg.Basket.Items, eventMsg.UserId, eventMsg.City, eventMsg.Street, 
                     eventMsg.State, eventMsg.Country, eventMsg.ZipCode,
                     eventMsg.CardNumber, eventMsg.CardHolderName, eventMsg.CardExpiration,
                     eventMsg.CardSecurityNumber, eventMsg.CardTypeId);

src/Services/Ordering/Ordering.API/Startup.cs

@@ -125,13 +125,12 @@ public IServiceProvider ConfigureServices(IServiceCollection services)
                 return new DefaultRabbitMQPersistentConnection(factory, logger);
             });
 
-
-            services.AddSingleton<IEventBusSubscriptionsManager, InMemoryEventBusSubscriptionsManager>();
             services.AddSingleton<IEventBus, EventBusRabbitMQ>();
-            services.AddTransient<IIntegrationEventHandler, UserCheckoutAcceptedIntegrationEventHandler>();
+            services.AddSingleton<IEventBusSubscriptionsManager, InMemoryEventBusSubscriptionsManager>();
+            services.AddTransient<IIntegrationEventHandler<UserCheckoutAcceptedIntegrationEvent>>();
             services.AddTransient<IIntegrationEventHandler<ConfirmGracePeriodCommandMsg>, OrderProcessSaga>();
-            services.AddTransient<OrderStockConfirmedIntegrationEventHandler>();
-            services.AddTransient<OrderStockNotConfirmedIntegrationEventHandler>();
+            services.AddTransient<IIntegrationEventHandler<OrderStockConfirmedIntegrationEvent>>();
+            services.AddTransient<IIntegrationEventHandler<OrderStockNotConfirmedIntegrationEvent>>();
             services.AddOptions();
 
             //configure autofac
@@ -176,13 +175,13 @@ private void ConfigureEventBus(IApplicationBuilder app)
         {
             var eventBus = app.ApplicationServices.GetRequiredService<IEventBus>();
 
-            eventBus.Subscribe<UserCheckoutAcceptedIntegrationEvent,IIntegrationEventHandler<UserCheckoutAcceptedIntegrationEvent>>();
+            eventBus.Subscribe<UserCheckoutAcceptedIntegrationEvent, IIntegrationEventHandler<UserCheckoutAcceptedIntegrationEvent>>();
 
             eventBus.Subscribe<ConfirmGracePeriodCommandMsg, IIntegrationEventHandler<ConfirmGracePeriodCommandMsg>>();
 
-            eventBus.Subscribe<OrderStockConfirmedIntegrationEvent, OrderStockConfirmedIntegrationEventHandler>();
+            eventBus.Subscribe<OrderStockConfirmedIntegrationEvent, IIntegrationEventHandler<OrderStockConfirmedIntegrationEvent>>();
 
-            eventBus.Subscribe<OrderStockNotConfirmedIntegrationEvent, OrderStockNotConfirmedIntegrationEventHandler>();
+            eventBus.Subscribe<OrderStockNotConfirmedIntegrationEvent, IIntegrationEventHandler<OrderStockNotConfirmedIntegrationEvent>>();
         }
 
         protected virtual void ConfigureAuth(IApplicationBuilder app)

src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs

@@ -40,7 +40,7 @@ public class Order
 
         protected Order() { _orderItems = new List<OrderItem>(); }
 
-        public Order(Address address, int cardTypeId, string cardNumber, string cardSecurityNumber,
+        public Order(string userId, Address address, int cardTypeId, string cardNumber, string cardSecurityNumber,
                 string cardHolderName, DateTime cardExpiration, int? buyerId = null, int? paymentMethodId = null)
         {
             _orderItems = new List<OrderItem>();
@@ -52,7 +52,7 @@ public Order(Address address, int cardTypeId, string cardNumber, string cardSecu
 
             // Add the OrderStarterDomainEvent to the domain events collection 
             // to be raised/dispatched when comitting changes into the Database [ After DbContext.SaveChanges() ]
-            AddOrderStartedDomainEvent(cardTypeId, cardNumber,
+            AddOrderStartedDomainEvent(userId, cardTypeId, cardNumber,
                                        cardSecurityNumber, cardHolderName, cardExpiration);
         }
 
@@ -113,11 +113,11 @@ public void SetOrderStockConfirmed(bool confirmed)
             }
         }
 
-        private void AddOrderStartedDomainEvent(int cardTypeId, string cardNumber,
+        private void AddOrderStartedDomainEvent(string userId, int cardTypeId, string cardNumber,
                 string cardSecurityNumber, string cardHolderName, DateTime cardExpiration)
         {
             var orderStartedDomainEvent = new OrderStartedDomainEvent(
-                this, cardTypeId, cardNumber, cardSecurityNumber,
+                this, userId, cardTypeId, cardNumber, cardSecurityNumber,
                 cardHolderName, cardExpiration);
 
             this.AddDomainEvent(orderStartedDomainEvent);

src/Services/Ordering/Ordering.Domain/Events/OrderStartedDomainEvent.cs

@@ -12,19 +12,21 @@ namespace Ordering.Domain.Events
     public class OrderStartedDomainEvent
         : IAsyncNotification
     {
+        public string UserId { get; private set; }
         public int CardTypeId { get; private set; }
         public string CardNumber { get; private set; }
         public string CardSecurityNumber { get; private set; }
         public string CardHolderName { get; private set; }
         public DateTime CardExpiration { get; private set; }
         public Order Order { get; private set; }
 
-        public OrderStartedDomainEvent(Order order,
+        public OrderStartedDomainEvent(Order order, string userId,
             int cardTypeId, string cardNumber, 
             string cardSecurityNumber, string cardHolderName, 
             DateTime cardExpiration)
         {
             Order = order;
+            UserId = userId;
             CardTypeId = cardTypeId;
             CardNumber = cardNumber;
             CardSecurityNumber = cardSecurityNumber;

src/Web/WebMVC/Services/OrderingService.cs

@@ -98,6 +98,8 @@ public void OverrideUserInfoIntoOrder(Order original, Order destination)
 
         public BasketDTO MapOrderToBasket(Order order)
         {
+            order.CardExpirationApiFormat();
+
             return new BasketDTO()
             {
                 City = order.City,
@@ -109,7 +111,7 @@ public BasketDTO MapOrderToBasket(Order order)
                 CardHolderName = order.CardHolderName,
                 CardExpiration = order.CardExpiration,
                 CardSecurityNumber = order.CardSecurityNumber,
-                CardTypeId = order.CardTypeId,
+                CardTypeId = 1,
                 Buyer = order.Buyer,
                 RequestId = order.RequestId
             };