Skip to content

Commit 0966b2f

Browse files
committed
removed eq switching carousel, was annoying
1 parent ef8b589 commit 0966b2f

3 files changed

Lines changed: 15 additions & 56 deletions

File tree

ui/src/app/modules/eqmac-components/components/knob/knob.component.html

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,6 @@
2626
<div class="slot"></div>
2727
<div class="body"></div>
2828
<div class="cap">
29-
<!-- <svg width="58px" height="58px">
30-
<defs>
31-
<clipPath [id]="'large-knob-cap-clip-path-' + id" clipPathUnits="objectBoundingBox" width="58px" height="58px"
32-
[ngStyle]="largeCapClipPathStyle">
33-
<path
34-
d="M0.95,0.28C0.93,0.36,0.95,0.43,1,0.5c0,0,0,0,0,0c0,0.08-0.02,0.15-0.05,0.22C0.88,0.75,0.83,0.81,0.81,0.89
35-
C0.75,0.94,0.68,0.97,0.6,0.99c-0.07-0.03-0.13-0.03-0.2,0c-0.08-0.02-0.15-0.05-0.21-0.1C0.17,0.81,0.12,0.75,0.05,0.72
36-
C0.02,0.65,0,0.58,0,0.5c0,0,0,0,0,0c0.05-0.06,0.07-0.14,0.05-0.22C0.09,0.21,0.14,0.14,0.2,0.1c0.07,0,0.13-0.03,0.17-0.08
37-
C0.42,0.01,0.46,0,0.5,0c0.04,0,0.09,0.01,0.12,0.02C0.67,0.07,0.73,0.1,0.8,0.1C0.86,0.14,0.91,0.21,0.95,0.28z" />
38-
</clipPath>
39-
</defs>
40-
</svg> -->
4129
<div class="cap-body" [ngStyle]="largeCapBodyStyle"></div>
4230
<div class="indicator" [ngStyle]="largeCapIndicatorStyle">
4331
<svg class="inner-line" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px"

ui/src/app/sections/effects/equalizers/equalizers.component.html

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,15 @@
4545
></eqm-equalizer-presets>
4646
</div>
4747
<eqm-loading *ngIf="!loaded"></eqm-loading>
48-
<eqm-carousel class="equalizers" #equalizersCarousel [hidden]="!loaded"
49-
[selectedItemId]="type" (selectedItemIdChange)="typeSwitched($event)" (itemCameIntoView)="equalizerCameIntoView($event)"
50-
(heightDiff)="carouselHeightChanged($event)"
51-
[animationDuration]="animationDuration"
52-
>
53-
<eqm-basic-equalizer #basicEqualizer *eqmCarouselItem="'Basic'"
54-
[enabled]="enabled" class="equalizer"
55-
(presetsChange)="presets = $event" (selectedPresetChange)="selectedPreset = $event"
56-
[animationDuration]="animationDuration" [animationFps]="animationFps"
57-
[settingsDialog]="settingsDialog"
58-
></eqm-basic-equalizer>
59-
<eqm-advanced-equalizer #advancedEqualizer *eqmCarouselItem="'Advanced'"
60-
[enabled]="enabled" class="equalizer"
61-
(presetsChange)="presets = $event" (selectedPresetChange)="selectedPreset = $event"
62-
[animationDuration]="animationDuration" [animationFps]="animationFps"
63-
[settingsDialog]="settingsDialog"
64-
></eqm-advanced-equalizer>
65-
</eqm-carousel>
48+
<eqm-basic-equalizer fxFill *ngIf="loaded && type === 'Basic'" #basicEqualizer
49+
[enabled]="enabled" class="equalizer"
50+
(presetsChange)="presets = $event" (selectedPresetChange)="selectedPreset = $event"
51+
[animationDuration]="animationDuration" [animationFps]="animationFps"
52+
[settingsDialog]="settingsDialog"
53+
></eqm-basic-equalizer>
54+
<eqm-advanced-equalizer *ngIf="loaded && type === 'Advanced'" #advancedEqualizer
55+
[enabled]="enabled" class="equalizer"
56+
(presetsChange)="presets = $event" (selectedPresetChange)="selectedPreset = $event"
57+
[animationDuration]="animationDuration" [animationFps]="animationFps"
58+
[settingsDialog]="settingsDialog"
59+
></eqm-advanced-equalizer>

ui/src/app/sections/effects/equalizers/equalizers.component.ts

Lines changed: 3 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { EqualizersService, EqualizerType } from './equalizers.service'
33
import { BasicEqualizerComponent } from './basic-equalizer/basic-equalizer.component'
44
import { AdvancedEqualizerComponent } from './advanced-equalizer/advanced-equalizer.component'
55
import { EqualizerComponent } from './equalizer.component'
6-
import { CarouselComponent } from 'src/app/modules/eqmac-components/components/carousel/carousel.component'
76
import { FadeInOutAnimation } from 'src/app/modules/animations'
87
import { MatDialog, MatDialogRef } from '@angular/material/dialog'
98
import { OptionsDialogComponent } from '../../../components/options-dialog/options-dialog.component'
@@ -21,7 +20,6 @@ export class EqualizersComponent implements OnInit {
2120
@Input() animationFps = 30
2221

2322
@Output() visibilityToggled = new EventEmitter()
24-
@ViewChild('equalizersCarousel', { static: false }) equalizersCarousel: CarouselComponent
2523
@ViewChild('basicEqualizer', { static: false }) basicEqualizer: BasicEqualizerComponent
2624
@ViewChild('advancedEqualizer', { static: false }) advancedEqualizer: AdvancedEqualizerComponent
2725

@@ -43,11 +41,6 @@ export class EqualizersComponent implements OnInit {
4341

4442
gain: number = 0
4543

46-
typeSwitched (newType: EqualizerType) {
47-
this.type = newType
48-
this.equalizersService.setType(newType)
49-
}
50-
5144
public settingsDialog: MatDialogRef<OptionsDialogComponent>
5245

5346
constructor (
@@ -91,26 +84,10 @@ export class EqualizersComponent implements OnInit {
9184
this.equalizersService.setEnabled(this.enabled)
9285
}
9386

94-
previousType () {
95-
this.equalizersCarousel.prev()
96-
}
97-
98-
nextType () {
99-
this.equalizersCarousel.next()
100-
}
101-
102-
setType (type: EqualizerType) {
87+
async setType (type: EqualizerType) {
10388
this.type = type
104-
this.typeSwitched(type)
105-
}
106-
107-
equalizerCameIntoView (type: EqualizerType) {
108-
const equalizer = this.getEqualizerFromType(type)
109-
equalizer && equalizer.selected()
110-
}
111-
112-
carouselHeightChanged (heightDiff: number) {
113-
this.ui.dimensionsChanged.next({ heightDiff })
89+
await this.equalizersService.setType(type)
90+
this.ui.dimensionsChanged.next()
11491
}
11592

11693
public getEqualizerFromType (type: EqualizerType): EqualizerComponent {

0 commit comments

Comments
 (0)