Skip to content

Commit 3e0ac98

Browse files
committed
unused deps cleanup
1 parent f50c29e commit 3e0ac98

5 files changed

Lines changed: 26 additions & 96 deletions

File tree

ui/package-lock.json

Lines changed: 0 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ui/package.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,8 @@
2020
"@angular/material": "^11.2.3",
2121
"@angular/platform-browser": "^11.2.4",
2222
"@angular/platform-browser-dynamic": "^11.2.4",
23-
"@angular/router": "^11.2.4",
2423
"@webcomponents/custom-elements": "^1.4.2",
2524
"core-js": "^3.2.1",
26-
"js-cookie": "^2.2.1",
27-
"ng-click-outside": "^7.0.1",
2825
"rxjs": "^6.6.6",
2926
"web-animations-js": "^2.3.2",
3027
"zone.js": "^0.11.4"
@@ -35,7 +32,6 @@
3532
"@angular/compiler-cli": "^11.2.4",
3633
"@angular/language-service": "^11.2.4",
3734
"@types/google.analytics": "0.0.41",
38-
"@types/js-cookie": "^2.2.6",
3935
"@types/node": "^14.14.32",
4036
"cloudflare": "^2.7.0",
4137
"dotenv": "^8.2.0",

ui/src/app/services/bridge.service.ts

Lines changed: 21 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -29,22 +29,19 @@ interface JSBridge {
2929
* Class Bridge class that connect JavaScript runtime to Swift if page is rendered in WKWebView<br>
3030
* Under the hood uses [WebViewJavascriptBridge](https://github.com/marcuswestin/WebViewJavascriptBridge)
3131
*/
32-
@Injectable({
33-
providedIn: 'root'
34-
})
35-
export class BridgeService {
36-
public static bridgeLoadTimeout = 10000
37-
public static bridgeLoadPromise: Promise<JSBridge> = null
32+
export class Bridge {
33+
public static loadTimeout = 10000
34+
public static loadPromise: Promise<JSBridge> = null
3835
private static didSpeedUp = false
3936
private static readonly handlers: {
4037
[event: string]: EventHandler[]
4138
} = {}
4239

43-
public get bridge () {
44-
if (BridgeService.bridgeLoadPromise) {
45-
return BridgeService.bridgeLoadPromise
40+
public static get bridge () {
41+
if (Bridge.loadPromise) {
42+
return Bridge.loadPromise
4643
}
47-
BridgeService.bridgeLoadPromise = new Promise(async (resolve, reject) => {
44+
Bridge.loadPromise = new Promise(async (resolve, reject) => {
4845
const bridgeKey = 'WebViewJavascriptBridge'
4946
if (window[bridgeKey]) {
5047
return resolve(window[bridgeKey])
@@ -64,17 +61,17 @@ export class BridgeService {
6461

6562
setTimeout(() => {
6663
reject(new Error('Bridge loading timed out'))
67-
}, BridgeService.bridgeLoadTimeout)
64+
}, Bridge.loadTimeout)
6865
})
6966

70-
return BridgeService.bridgeLoadPromise
67+
return Bridge.loadPromise
7168
}
7269

73-
async call (handler: string, data?: JSONData): Promise<any> {
70+
static async call (handler: string, data?: JSONData): Promise<any> {
7471
return new Promise(async (resolve, reject) => {
7572
const bridge = await this.bridge
76-
if (!BridgeService.didSpeedUp) {
77-
BridgeService.didSpeedUp = true
73+
if (!Bridge.didSpeedUp) {
74+
Bridge.didSpeedUp = true
7875
bridge.disableJavscriptAlertBoxSafetyTimeout()
7976
}
8077
bridge.callHandler(handler, data, res => {
@@ -84,15 +81,15 @@ export class BridgeService {
8481
})
8582
}
8683

87-
async on (event: string, handler: EventHandler) {
84+
static async on (event: string, handler: EventHandler) {
8885
const bridge = await this.bridge
8986
let shouldRegister = false
90-
if (!(event in BridgeService.handlers)) {
91-
BridgeService.handlers[event] = []
87+
if (!(event in Bridge.handlers)) {
88+
Bridge.handlers[event] = []
9289
shouldRegister = true
9390
}
9491

95-
BridgeService.handlers[event].push(handler)
92+
Bridge.handlers[event].push(handler)
9693

9794
if (shouldRegister) {
9895
bridge.registerHandler(event, async (data, cb) => {
@@ -102,7 +99,7 @@ export class BridgeService {
10299
cb({ error: err.toString() })
103100
}
104101

105-
for (const handler of BridgeService.handlers[event]) {
102+
for (const handler of Bridge.handlers[event]) {
106103
try {
107104
await handler(data, {
108105
send: (data) => cb({ data }),
@@ -116,14 +113,14 @@ export class BridgeService {
116113
}
117114
}
118115

119-
async off (event: string, handler: EventHandler) {
120-
if (!BridgeService.handlers[event]?.length) {
116+
static async off (event: string, handler: EventHandler) {
117+
if (!Bridge.handlers[event]?.length) {
121118
console.error(`Trying to unsubscribe from event: "${event}" when there are no handlers registered`)
122119
return
123120
}
124-
const index = BridgeService.handlers[event]?.indexOf(handler)
121+
const index = Bridge.handlers[event]?.indexOf(handler)
125122
if (index > -1) {
126-
BridgeService.handlers[event].splice(index, 1)
123+
Bridge.handlers[event].splice(index, 1)
127124
} else {
128125
console.error(`Trying to unsubscribe from event: "${event}" with a handler that is not registered`)
129126
}

ui/src/app/services/cookies.service.ts

Lines changed: 0 additions & 30 deletions
This file was deleted.

ui/src/app/services/data.service.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { Injectable } from '@angular/core'
2-
import { BridgeService } from './bridge.service'
3-
import { CookiesService } from './cookies.service'
2+
import { Bridge } from './bridge.service'
43

54
export type JSONEncodable = null | boolean | number | string | JSONData
65
export interface JSONData {
@@ -20,14 +19,13 @@ export class DataService {
2019
route = ''
2120

2221
constructor (
23-
public bridge: BridgeService,
24-
public cookies: CookiesService
22+
public bridge: Bridge
2523
) {}
2624

2725
async request (opts: RequestOptions): Promise<any> {
2826
if (opts.endpoint && opts.endpoint[0] !== '/') opts.endpoint = `/${opts.endpoint}`
2927
const args: [string, any?] = [ `${opts.method} ${this.route}${opts.endpoint || ''}`, opts.data ]
30-
const resp = await this.bridge.call(...args)
28+
const resp = await Bridge.call(...args)
3129
return resp
3230
}
3331

@@ -41,13 +39,13 @@ export class DataService {
4139
async on (event: string, callback: EventCallback)
4240
async on (eventOrCallback: string | EventCallback, cb?: EventCallback) {
4341
const { event, callback } = this.normalizeEventCallback(eventOrCallback, cb)
44-
this.bridge.on(`${this.route}${event}`, callback)
42+
Bridge.on(`${this.route}${event}`, callback)
4543
}
4644

4745
async off (callback: EventCallback)
4846
async off (event: string, callback: EventCallback)
4947
async off (eventOrCallback: string | EventCallback, cb?: EventCallback) {
5048
const { event, callback } = this.normalizeEventCallback(eventOrCallback, cb)
51-
this.bridge.off(`${this.route}${event}`, callback)
49+
Bridge.off(`${this.route}${event}`, callback)
5250
}
5351
}

0 commit comments

Comments
 (0)