Skip to content

Commit ed36e7c

Browse files
committed
handling some ui errors
1 parent b037963 commit ed36e7c

5 files changed

Lines changed: 15 additions & 6 deletions

File tree

native/app/Source/Audio/Sources/System/Driver.swift

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,11 @@ class Driver {
118118
mElement: kAudioObjectPropertyElementMaster
119119
)
120120

121-
let size = sizeof(UInt32.self)
122-
var latency: UInt32 = newValue
121+
let size = sizeof(CFNumber.self)
122+
123+
var newLatency = newValue
124+
var latency: CFNumber = CFNumberCreate(kCFAllocatorDefault, CFNumberType.sInt32Type, &newLatency)
125+
123126
checkErr(AudioObjectSetPropertyData(Driver.device!.id, &address, 0, nil, size, &latency))
124127
}
125128
}

native/driver/Source/EQMDevice.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ class EQMDevice: EQMObject {
143143
case kAudioDevicePropertyIcon: return sizeof(CFURL.self)
144144

145145
case kAudioObjectPropertyCustomPropertyInfoList: return sizeof(AudioServerPlugInCustomPropertyInfo.self) * EQMDeviceCustom.properties.count
146-
case EQMDeviceCustom.properties.latency: return sizeof(UInt32.self)
146+
case EQMDeviceCustom.properties.latency: return sizeof(CFNumber.self)
147147
case EQMDeviceCustom.properties.shown: return sizeof(CFBoolean.self)
148148
case EQMDeviceCustom.properties.version: return sizeof(CFString.self)
149149
case EQMDeviceCustom.properties.name: return sizeof(CFString.self)
@@ -444,7 +444,9 @@ class EQMDevice: EQMObject {
444444
// Only allow eqMac app to set this property
445445
guard client?.bundleId == APP_BUNDLE_ID else { return noErr }
446446

447-
let newLatency = data.load(as: UInt32.self)
447+
let newLatencyRef = data.load(as: CFNumber.self)
448+
var newLatency: Int32 = 0
449+
CFNumberGetValue(newLatencyRef, .sInt32Type, &newLatency)
448450

449451
if latency != newLatency {
450452
latency = UInt32(newLatency)

ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ui",
3-
"version": "2.1.0",
3+
"version": "2.1.1",
44
"scripts": {
55
"lint": "npx eslint .",
66
"start": "ng serve --port 8080 --host 0.0.0.0 --disable-host-check",

ui/src/app/services/analytics.service.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ export class AnalyticsService {
3838
})
3939
this.injected = true
4040

41+
while (!window.ga || typeof window.ga !== 'function') {
42+
await this.utils.waitForProperty(window, 'ga')
43+
}
44+
4145
window.ga('create', 'UA-96287398-6')
4246
this.send()
4347

ui/src/app/services/ui.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export class UIService extends DataService {
4343
route = `${this.route}/ui`
4444
dimensionsChanged = new Subject<UIDimensions>()
4545
settingsChanged = new Subject<UISettings>()
46-
settings: UISettings
46+
settings: UISettings = {}
4747

4848
readonly colors = {
4949
accent: '#4f8d71',

0 commit comments

Comments
 (0)