Skip to content

Commit 4673ba7

Browse files
Omranicbestlong
authored andcommitted
Fix minor typos and clarify few documentation phrases (laradock#1629)
1 parent 154249a commit 4673ba7

4 files changed

Lines changed: 15 additions & 15 deletions

File tree

DOCUMENTATION/content/contributing/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ To update the sidebar or add a new section to it, you can edit this `DOCUMENTATI
7373

7474
* Add the environment variables to the `env-example` if you have any.
7575

76-
* **MOST IMPORTANTLY** updated the `Documentation`, add as much information.
76+
* **MOST IMPORTANTLY** update the `Documentation`, add as much information.
7777

7878
* Submit a Pull Request, to the `master` branch.
7979

@@ -100,7 +100,7 @@ To update the sidebar or add a new section to it, you can edit this `DOCUMENTATI
100100

101101
* Search for the image in the [Docker Hub](https://hub.docker.com/search/) and find the source..
102102

103-
*Most of the image in Laradock are offical images, these projects live in other repositories and maintainer by other orgnizations.*
103+
*Most of the image in Laradock are offical images, these projects live in other repositories and maintainer by other organizations.*
104104

105105
**Note:** Laradock has two base images for (`Workspace` and `php-fpm`, mainly made to speed up the build time on your machine.
106106

DOCUMENTATION/content/documentation/index.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ More [options](https://docs.docker.com/compose/reference/logs/)
201201
<a name="Install-PHP-Extensions"></a>
202202
## Install PHP Extensions
203203

204-
Before installing PHP extensions, you have to decide whether you need for the `FPM` or `CLI` because each lives on a different container, if you need it for both you have to edit both containers.
204+
Before installing PHP extensions, you have to decide first whether you need `FPM` or `CLI`, because each of them has it's own different container, if you need it for both, you have to edit both containers.
205205

206206
The PHP-FPM extensions should be installed in `php-fpm/Dockerfile-XX`. *(replace XX with your default PHP version number)*.
207207
<br>
@@ -428,7 +428,7 @@ To learn more about how Docker publishes ports, please read [this excellent post
428428

429429
1) Boot the container `docker-compose up -d jenkins`. To enter the container type `docker-compose exec jenkins bash`.
430430

431-
2) Go to `http://localhost:8090/` (if you didn't chanhed your default port mapping)
431+
2) Go to `http://localhost:8090/` (if you didn't change your default port mapping)
432432

433433
3) Authenticate from the web app.
434434

@@ -971,7 +971,7 @@ docker-compose up -d aws
971971

972972
3 - Access the aws container with `docker-compose exec aws bash`
973973

974-
4 - To start using eb cli inside the container, initiaze your project first by doing 'eb init'. Read the [aws eb cli](http://docs.aws.amazon.com/elasticbeanstalk/latest/dg/eb-cli3-configuration.html) docs for more details.
974+
4 - To start using eb cli inside the container, initialize your project first by doing 'eb init'. Read the [aws eb cli](http://docs.aws.amazon.com/elasticbeanstalk/latest/dg/eb-cli3-configuration.html) docs for more details.
975975

976976

977977

@@ -989,7 +989,7 @@ docker-compose up -d grafana
989989

990990
3 - Open your browser and visit the localhost on port **3000** at the following URL: `http://localhost:3000`
991991

992-
4 - Login using the credentials User = `admin` Passwort = `admin`. Change the password in the webinterface if you want to.
992+
4 - Login using the credentials User = `admin`, Password = `admin`. Change the password in the web interface if you want to.
993993

994994

995995

@@ -1525,7 +1525,7 @@ Quick Setup giude, (we recommend you check their docs)
15251525
<a name="Docker-Sync"></a>
15261526
### Workaround B: using d4m-nfs
15271527

1528-
You can use the d4m-nfs solution in 2 ways, one is using the Laradock built it integration, and the other is using the tool separatly. Below is show case of both methods:
1528+
You can use the d4m-nfs solution in 2 ways, the first is by using the built-in Laradock integration, and the second is using the tool separately. Below is show case of both methods:
15291529

15301530

15311531
### B.1: using the built in d4m-nfs integration
@@ -1630,7 +1630,7 @@ Click on the Docker Icon > Preferences > (remove everything form the list except
16301630
git clone https://github.com/IFSight/d4m-nfs ~/d4m-nfs
16311631
```
16321632

1633-
4) Create (or edit) the file `~/d4m-nfs/etc/d4m-nfs-mounts.txt`, and write the follwing configuration in it:
1633+
4) Create (or edit) the file `~/d4m-nfs/etc/d4m-nfs-mounts.txt`, and write the following configuration in it:
16341634

16351635
```txt
16361636
/Users:/Users

DOCUMENTATION/content/getting-started/index.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -161,21 +161,21 @@ We recommend using a Docker version which is newer than 1.13.
161161
cp env-example .env
162162
```
163163

164-
You can edit the `.env` file to choose which software's you want to be installed in your environment. You can always refer to the `docker-compose.yml` file to see how those variables are been used.
164+
You can edit the `.env` file to choose which software you want to be installed in your environment. You can always refer to the `docker-compose.yml` file to see how those variables have been used.
165165

166166
Depending on the host's operating system you may need to change the value given to `COMPOSE_FILE`. When you are running Laradock on Mac OS the correct file separator to use is `:`. When running Laradock from a Windows environment multiple files must be separated with `;`.
167167

168-
By default the containers that will be created have the current directory name as suffix (e.g. `laradock_workspace_1`). This can cause mixture of data inside the container volumes if you use laradock in multiple project. In this case, either read the guide for [multiple projects](#B) or change the variable `COMPOSE_PROJECT_NAME` to something unique like your project name.
168+
By default the containers that will be created have the current directory name as suffix (e.g. `laradock_workspace_1`). This can cause mixture of data inside the container volumes if you use laradock in multiple projects. In this case, either read the guide for [multiple projects](#B) or change the variable `COMPOSE_PROJECT_NAME` to something unique like your project name.
169169

170-
2 - Build the enviroment and run it using `docker-compose`
170+
2 - Build the environment and run it using `docker-compose`
171171

172172
In this example we'll see how to run NGINX (web server) and MySQL (database engine) to host a PHP Web Scripts:
173173

174174
```bash
175175
docker-compose up -d nginx mysql
176176
```
177177

178-
**Note**: The web servers `nginx`, `apache`.. all depend on `php-fpm`, means if you just run, them they will automatically run the `php-fpm` for you, so no need to specify them in the `up` command. If you don't see them running then you may need run them as follow: `docker-compose up -d nginx php-fpm mysql...`.
178+
**Note**: All the web server containers `nginx`, `apache` ..etc depends on `php-fpm`, which means if you run any of them, they will automatically launch the `php-fpm` container for you, so no need to explicitly specify it in the `up` command. If you have to do so, you may need to run them as follows: `docker-compose up -d nginx php-fpm mysql`.
179179

180180

181181
You can select your own combination of containers from [this list](http://laradock.io/introduction/#supported-software-images).
@@ -205,7 +205,7 @@ docker-compose exec --user=laradock workspace bash
205205
*You can change the PUID (User id) and PGID (group id) variables from the `.env` file)*
206206

207207
<br>
208-
4 - Update your project configurations to use the database host
208+
4 - Update your project configuration to use the database host
209209

210210
Open your PHP project's `.env` file or whichever configuration file you are reading from, and set the database host `DB_HOST` to `mysql`:
211211

jenkins/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ docker run --name myjenkins -p 8080:8080 -p 50000:50000 --env JAVA_OPTS="-Djava.
9393
```
9494

9595
# Configuring reverse proxy
96-
If you want to install Jenkins behind a reverse proxy with prefix, example: mysite.com/jenkins, you need to add environnement variable `JENKINS_OPTS="--prefix=/jenkins"` and then follow the below procedures to configure your reverse proxy, which will depend if you have Apache ou Nginx:
96+
If you want to install Jenkins behind a reverse proxy with prefix, example: mysite.com/jenkins, you need to add environment variable `JENKINS_OPTS="--prefix=/jenkins"` and then follow the below procedures to configure your reverse proxy, which will depend if you have Apache ou Nginx:
9797
- [Apache](https://wiki.jenkins-ci.org/display/JENKINS/Running+Jenkins+behind+Apache)
9898
- [Nginx](https://wiki.jenkins-ci.org/display/JENKINS/Jenkins+behind+an+NGinX+reverse+proxy)
9999

@@ -154,7 +154,7 @@ COPY custom.groovy /usr/share/jenkins/ref/init.groovy.d/custom.groovy
154154
## Preinstalling plugins
155155

156156
You can rely on the `install-plugins.sh` script to pass a set of plugins to download with their dependencies.
157-
Use plugin artifact ID, whithout `-plugin` extension, and append the version if needed separated by `:`.
157+
Use plugin artifact ID, without `-plugin` extension, and append the version if needed separated by `:`.
158158
Dependencies that are already included in the Jenkins war will only be downloaded if their required version is newer than the one included.
159159

160160
```

0 commit comments

Comments
 (0)