Skip to content

Commit 61168cb

Browse files
Merge pull request laradock#887 from winfried-van-loon/792-v8js
Fixing V8JS
2 parents 5761690 + da58d2e commit 61168cb

3 files changed

Lines changed: 2 additions & 19 deletions

File tree

workspace/Dockerfile-56

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -299,23 +299,6 @@ RUN if [ ${INSTALL_AEROSPIKE_EXTENSION} = false ]; then \
299299
rm /etc/php/5.6/cli/conf.d/aerospike.ini \
300300
;fi
301301

302-
#####################################
303-
# PHP V8JS:
304-
#####################################
305-
USER root
306-
307-
ARG INSTALL_V8JS_EXTENSION=false
308-
ENV INSTALL_V8JS_EXTENSION ${INSTALL_V8JS_EXTENSION}
309-
310-
RUN if [ ${INSTALL_V8JS_EXTENSION} = true ]; then \
311-
# Install the php V8JS extension
312-
add-apt-repository -y ppa:pinepain/libv8-5.4 \
313-
&& apt-get update \
314-
&& apt-get install -y php-dev php-pear libv8-5.4 \
315-
&& pecl install v8js \
316-
&& echo "extension=v8js.so" >> /etc/php/5.6/cli/php.ini \
317-
;fi
318-
319302
#####################################
320303
# Non-root user : PHPUnit path
321304
#####################################

workspace/Dockerfile-70

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ RUN if [ ${INSTALL_V8JS_EXTENSION} = true ]; then \
311311
# Install the php V8JS extension
312312
add-apt-repository -y ppa:pinepain/libv8-5.4 \
313313
&& apt-get update \
314-
&& apt-get install -y php-dev php-pear libv8-5.4 \
314+
&& apt-get install -y php7.0-xml php7.0-dev php-pear libv8-5.4 \
315315
&& pecl install v8js \
316316
&& echo "extension=v8js.so" >> /etc/php/7.0/cli/php.ini \
317317
;fi

workspace/Dockerfile-71

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ RUN if [ ${INSTALL_V8JS_EXTENSION} = true ]; then \
307307
# Install the php V8JS extension
308308
add-apt-repository -y ppa:pinepain/libv8-5.4 \
309309
&& apt-get update \
310-
&& apt-get install -y php-dev php-pear libv8-5.4 \
310+
&& apt-get install -y php-xml php-dev php-pear libv8-5.4 \
311311
&& pecl install v8js \
312312
&& echo "extension=v8js.so" >> /etc/php/7.1/cli/php.ini \
313313
;fi

0 commit comments

Comments
 (0)