You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+15-3Lines changed: 15 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -54,9 +54,21 @@ Help us to maximize the effort we can spend fixing issues and adding new
54
54
features, by not reporting duplicate issues.
55
55
56
56
57
+
### Before Submitting a Pull Request (PR)
57
58
58
-
### Submitting a Pull Request (PR)
59
-
Before you submit your pull request consider the following guidelines:
59
+
Always Test everything and make sure its working:
60
+
61
+
- Pull the latest updates (or fork of you don’t have permission)
62
+
- Before editing anything:
63
+
- Test building the container (docker-compose build --no-cache container-name) build with no cache first.
64
+
- Test running the container with some other containers in real app and see of everything is working fine.
65
+
- Now edit the container (edit section by section and test rebuilding the container after every edited section)
66
+
- Testing building the container (docker-compose build container-name) with no errors.
67
+
- Test it in real App.
68
+
69
+
70
+
### Submitting a PR
71
+
Consider the following guidelines:
60
72
61
73
* Search [GitHub](https://github.com/LaraDock/laradock/pulls) for an open or closed Pull Request that relates to your submission. You don't want to duplicate effort.
0 commit comments