Skip to content

Commit e856227

Browse files
committed
update the readme: update contributing giude
1 parent 1614f0f commit e856227

1 file changed

Lines changed: 15 additions & 3 deletions

File tree

CONTRIBUTING.md

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,21 @@ Help us to maximize the effort we can spend fixing issues and adding new
5454
features, by not reporting duplicate issues.
5555

5656

57+
### Before Submitting a Pull Request (PR)
5758

58-
### Submitting a Pull Request (PR)
59-
Before you submit your pull request consider the following guidelines:
59+
Always Test everything and make sure its working:
60+
61+
- Pull the latest updates (or fork of you don’t have permission)
62+
- Before editing anything:
63+
- Test building the container (docker-compose build --no-cache container-name) build with no cache first.
64+
- Test running the container with some other containers in real app and see of everything is working fine.
65+
- Now edit the container (edit section by section and test rebuilding the container after every edited section)
66+
- Testing building the container (docker-compose build container-name) with no errors.
67+
- Test it in real App.
68+
69+
70+
### Submitting a PR
71+
Consider the following guidelines:
6072

6173
* Search [GitHub](https://github.com/LaraDock/laradock/pulls) for an open or closed Pull Request that relates to your submission. You don't want to duplicate effort.
6274

@@ -93,7 +105,7 @@ git push origin my-fix-branch -f
93105

94106

95107

96-
### After your pull request is merged
108+
### After your PR is merged
97109

98110
After your pull request is merged, you can safely delete your branch and pull the changes
99111
from the main (upstream) repository:

0 commit comments

Comments
 (0)