Skip to content

Commit eeee143

Browse files
committed
Move Chrome Driver Version to Env
This will allow us to upgrade chrome driver easily. Set the default chrome driver to 2.32. Also remove the comment and empty line to avoid getting below warning: ``` [WARNING]: Empty continuation lines will become errors in a future release. ```
1 parent a2edf57 commit eeee143

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

docker-compose.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ services:
4343
- INSTALL_DUSK_DEPS=${WORKSPACE_INSTALL_DUSK_DEPS}
4444
- PUID=${WORKSPACE_PUID}
4545
- PGID=${WORKSPACE_PGID}
46+
- CHROME_DRIVER_VERSION=${WORKSPACE_CHROME_DRIVER_VERSION}
4647
- NODE_VERSION=${WORKSPACE_NODE_VERSION}
4748
- YARN_VERSION=${WORKSPACE_YARN_VERSION}
4849
- TZ=${WORKSPACE_TIMEZONE}

env-example

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ WORKSPACE_INSTALL_TERRAFORM=false
5656
WORKSPACE_INSTALL_DUSK_DEPS=false
5757
WORKSPACE_PUID=1000
5858
WORKSPACE_PGID=1000
59+
WORKSPACE_CHROME_DRIVER_VERSION=2.32
5960
WORKSPACE_NODE_VERSION=stable
6061
WORKSPACE_YARN_VERSION=latest
6162
WORKSPACE_TIMEZONE=UTC

workspace/Dockerfile-71

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -628,26 +628,23 @@ RUN if [ ${INSTALL_TERRAFORM} = true ]; then \
628628
# Dusk Dependencies:
629629
#####################################
630630
USER root
631+
ARG CHROME_DRIVER_VERSION=stable
632+
ENV CHROME_DRIVER_VERSION ${CHROME_DRIVER_VERSION}
631633
ARG INSTALL_DUSK_DEPS=false
632634
ENV INSTALL_DUSK_DEPS ${INSTALL_DUSK_DEPS}
633635
RUN if [ ${INSTALL_DUSK_DEPS} = true ]; then \
634-
# Install required packages
635636
add-apt-repository ppa:ondrej/php \
636637
&& apt-get update \
637638
&& apt-get -y install zip wget unzip xdg-utils \
638639
libxpm4 libxrender1 libgtk2.0-0 libnss3 libgconf-2-4 xvfb \
639640
gtk2-engines-pixbuf xfonts-cyrillic xfonts-100dpi xfonts-75dpi \
640641
xfonts-base xfonts-scalable x11-apps \
641-
642-
# Install Google Chrome
643642
&& wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb \
644643
&& dpkg -i --force-depends google-chrome-stable_current_amd64.deb \
645644
&& apt-get -y -f install \
646645
&& dpkg -i --force-depends google-chrome-stable_current_amd64.deb \
647646
&& rm google-chrome-stable_current_amd64.deb \
648-
649-
# Install Chrome Driver
650-
&& wget https://chromedriver.storage.googleapis.com/2.31/chromedriver_linux64.zip \
647+
&& wget https://chromedriver.storage.googleapis.com/${CHROME_DRIVER_VERSION}/chromedriver_linux64.zip \
651648
&& unzip chromedriver_linux64.zip \
652649
&& mv chromedriver /usr/local/bin/ \
653650
&& rm chromedriver_linux64.zip \

0 commit comments

Comments
 (0)