Skip to content

Commit 0639673

Browse files
author
Kai Willadsen
committed
Refactor startup, reorganising imports and bumping (py)gtk requirement to 2.8
svn path=/trunk/; revision=1025
1 parent a0d7541 commit 0639673

9 files changed

Lines changed: 25 additions & 35 deletions

File tree

dirdiff.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
import math
2525
import misc
2626
import os
27+
from gettext import gettext as _
28+
from gettext import ngettext
2729
import shutil
2830
import melddoc
2931
import tree

filediff.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import codecs
2020
import math
2121
import os
22+
from gettext import gettext as _
2223
import re
2324
import difflib
2425
import struct

meld

Lines changed: 16 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -33,55 +33,36 @@ sys.path += [ #LIBDIR#
3333
]
3434
import paths
3535
import gettext
36+
from gettext import gettext as _
3637

37-
try:
38-
gettext.bindtextdomain("meld", paths.locale_dir())
39-
gettext.textdomain("meld")
40-
gettext.install("meld", paths.locale_dir(), unicode=1)
41-
except IOError, e:
42-
# fake gettext until translations in place
43-
print "(meld): WARNING **: %s" % e
44-
__builtins__.__dict__["_"] = lambda x : x
45-
__builtins__.__dict__["ngettext"] = gettext.ngettext
46-
47-
#
48-
# python version
49-
#
38+
gettext.bindtextdomain("meld", paths.locale_dir())
39+
gettext.textdomain("meld")
5040

41+
# Check requirements: Python 2.3, pygtk 2.8
5142
pyver = (2,3)
52-
pygtkver = (2,6,0)
43+
pygtkver = (2,8,0)
5344

54-
def ver2str(ver):
55-
return ".".join(map(str,ver))
45+
def missing_reqs(mod, ver):
46+
modver = mod + " " + ".".join(map(str, ver))
47+
print _("Meld requires %s or higher.") % modver
48+
sys.exit(1)
5649

5750
if sys.version_info[:2] < pyver:
58-
print _("Meld requires %s or higher.") % ("python%s"%ver2str(pyver))
59-
sys.exit(1)
51+
missing_reqs("Python", pyver)
6052

61-
#
62-
# pygtk 2
63-
#
6453
try:
6554
import pygtk
55+
pygtk.require("2.0")
56+
import gtk
57+
import gtk.glade
6658
except ImportError, e:
6759
print e
68-
print _("Meld requires %s or higher.") % ("pygtk%s"%ver2str(pygtkver))
69-
sys.exit(1)
70-
else:
71-
pygtk.require("2.0")
60+
missing_reqs("pygtk", pygtkver)
7261

73-
#
74-
# pygtk version
75-
#
76-
import gtk
77-
import gtk.glade
7862
if gtk.pygtk_version < pygtkver:
79-
print _("Meld requires %s or higher.") % ("pygtk%s"%ver2str(pygtkver))
80-
print _("Due to incompatible API changes some functions may not operate as expected.")
63+
missing_reqs("pygtk", pygtkver)
8164

82-
#
83-
# We target pygtk 2.6
84-
#
65+
# Ignore deprecation warnings from pygtk > 2.6
8566
if gtk.pygtk_version >= (2,8,0):
8667
import warnings
8768
warnings.filterwarnings("ignore", category=DeprecationWarning)

meldapp.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
# system
1818
import sys
1919
import os
20+
from gettext import gettext as _
2021

2122
# gnome
2223
import gtk

melddoc.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import undo
2020
import gtk
2121
import os
22+
from gettext import gettext as _
2223

2324
# Use these to ensure consistent return values.
2425
RESULT_OK, RESULT_ERROR = (0,1)

misc.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
from __future__ import generators
2222
import copy
2323
import os
24+
from gettext import gettext as _
2425
import select
2526
import popen2
2627
import errno

vc/_vc.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
### THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2323

2424
import os
25+
from gettext import gettext as _
2526

2627
# ignored, new, normal, ignored changes,
2728
# error, placeholder, vc added

vc/cvs.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
### THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2323

2424
import os
25+
from gettext import gettext as _
2526
import re
2627
import time
2728
import misc

vcview.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import shutil
2121
import gtk
2222
import os
23+
from gettext import gettext as _
2324
import re
2425

2526
import tree

0 commit comments

Comments
 (0)