Skip to content

Commit 3693f94

Browse files
committed
meldwindow: Move realize signal handling to vfunc override
1 parent 9b44bb7 commit 3693f94

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

meld/meldwindow.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,6 @@ def __init__(self):
226226
self.ui.ensure_update()
227227
self.diff_handler = None
228228
self.undo_handlers = tuple()
229-
self.connect('realize', self.on_realize)
230229
self.connect('focus_in_event', self.on_focus_change)
231230
self.connect('focus_out_event', self.on_focus_change)
232231

@@ -238,10 +237,11 @@ def __init__(self):
238237
shortcut_window = builder.get_object("shortcuts-meld")
239238
self.set_help_overlay(shortcut_window)
240239

241-
def on_realize(self, user_data):
242-
# FIXME: Ideally this would be in do_realize, and we'd get the menu
243-
# from resources, but MeldWindow would need to be a real GtkWindow
244-
# subclass, and we'd need to... have resources.
240+
def do_realize(self):
241+
Gtk.ApplicationWindow.do_realize(self)
242+
243+
# FIXME: Ideally we'd get the menu from resources, but we'd need to...
244+
# have resources.
245245
builder = meld.ui.util.get_builder("application.ui")
246246
menu = builder.get_object("gear-menu")
247247
self.gear_menu_button.set_popover(

0 commit comments

Comments
 (0)