refactor(nestjs) remove uncessary map calls

Author: kamilmysliwiec

packages/common/interfaces/nest-express-application.interface.ts

@@ -1,4 +1,3 @@
-import * as express from 'express';
 import { ServeStaticOptions } from './external/serve-static-options.interface';
 
 export interface INestExpressApplication {
@@ -41,9 +40,7 @@ export interface INestExpressApplication {
    * @returns {this}
    */
   useStaticAssets(options: any): this;
-  useStaticAssets(path: string, options?: ServeStaticOptions);
-  // tslint:disable-next-line:unified-signatures
-  useStaticAssets(pathOrOptions: any, options?: ServeStaticOptions): this;
+  useStaticAssets(path: string, options?: ServeStaticOptions): this;
 
   /**
    * Sets a base directory for templates (views).

packages/core/middleware/container.ts

@@ -25,7 +25,7 @@ export class MiddlewareContainer {
     const currentConfig = this.getCurrentConfig(module);
 
     const configurations = configList || [];
-    configurations.map(config => {
+    configurations.forEach(config => {
       [].concat(config.middleware).map(metatype => {
         const token = metatype.name;
         middleware.set(token, {

packages/core/router/router-explorer.ts

@@ -127,7 +127,7 @@ export class RouterExplorer {
     module: string,
     basePath: string,
   ) {
-    (routePaths || []).map(pathProperties => {
+    (routePaths || []).forEach(pathProperties => {
       const { path, requestMethod } = pathProperties;
       this.applyCallbackToRouter(
         router,

packages/core/scanner.ts

@@ -128,7 +128,7 @@ export class DependenciesScanner {
         metadata.PROVIDERS as 'providers',
       ),
     ];
-    components.map(component => {
+    components.forEach(component => {
       this.storeComponent(component, token);
       this.reflectComponentMetadata(component, token);
       this.reflectDynamicMetadata(component, token);
@@ -147,7 +147,7 @@ export class DependenciesScanner {
         metadata.CONTROLLERS as 'controllers',
       ),
     ];
-    routes.map(route => {
+    routes.forEach(route => {
       this.storeRoute(route, token);
       this.reflectDynamicMetadata(route, token);
     });
@@ -172,14 +172,14 @@ export class DependenciesScanner {
         metadata.EXPORTS as 'exports',
       ),
     ];
-    exports.map(exportedComponent =>
+    exports.forEach(exportedComponent =>
       this.storeExportedComponent(exportedComponent, token),
     );
   }
 
   public reflectGatewaysMiddleware(component: Type<Injectable>, token: string) {
     const middleware = this.reflectMetadata(component, GATEWAY_MIDDLEWARES);
-    middleware.map(ware => this.storeComponent(ware, token));
+    middleware.forEach(ware => this.storeComponent(ware, token));
   }
 
   public reflectInjectables(
@@ -202,7 +202,7 @@ export class DependenciesScanner {
       ...flattenMethodsInjectables,
     ].filter(isFunction);
 
-    mergedInjectables.map(injectable =>
+    mergedInjectables.forEach(injectable =>
       this.storeInjectable(injectable, token),
     );
   }

packages/testing/testing-module.builder.ts

@@ -90,7 +90,7 @@ export class TestingModuleBuilder {
   }
 
   private applyOverloadsMap() {
-    [...this.overloadsMap.entries()].map(([component, options]) => {
+    [...this.overloadsMap.entries()].forEach(([component, options]) => {
       this.container.replace(component, options);
     });
   }