docs(core): add comment to the replacer function

Author: kamilmysliwiec

packages/core/injector/module-token-factory.ts

@@ -10,22 +10,25 @@ export class ModuleTokenFactory {
     scope: Type<any>[],
     dynamicModuleMetadata?: Partial<DynamicModule> | undefined,
   ): string {
-    const reflectedScope = this.reflectScope(metatype);
-    const isSingleScoped = reflectedScope === true;
+    const moduleScope = this.reflectScope(metatype);
+    const isSingleScoped = moduleScope === true;
     const opaqueToken = {
       module: this.getModuleName(metatype),
       dynamic: this.getDynamicMetadataToken(dynamicModuleMetadata),
-      scope: isSingleScoped ? this.getScopeStack(scope) : reflectedScope,
+      scope: isSingleScoped ? this.getScopeStack(scope) : moduleScope,
     };
     return hash(opaqueToken);
   }
 
   public getDynamicMetadataToken(
     dynamicModuleMetadata: Partial<DynamicModule> | undefined,
   ): string {
-    // Uses safeStringify instead of JSON.stringify
-    // to support circular dynamic modules
-    return dynamicModuleMetadata ? stringify(dynamicModuleMetadata, this.replacer) : '';
+    // Uses safeStringify instead of JSON.stringify to support circular dynamic modules
+    // The replacer function is also required in order to obtain real class names
+    // instead of the unified "Function" key
+    return dynamicModuleMetadata
+      ? stringify(dynamicModuleMetadata, this.replacer)
+      : '';
   }
 
   public getModuleName(metatype: Type<any>): string {
@@ -54,8 +57,7 @@ export class ModuleTokenFactory {
   private replacer(key: string, value: any) {
     if (typeof value === 'function') {
       return value.name;
-    } else {
-      return value;
     }
+    return value;
   }
 }

packages/core/scanner.ts

@@ -194,6 +194,7 @@ export class DependenciesScanner {
       (a: any[], b: any[]) => a.concat(b),
       initialValue,
     ) as any[];
+
     const combinedInjectables = [
       ...controllerInjectables,
       ...flattenMethodsInjectables,