tests(): fix integration tests

Author: kamilmysliwiec

integration/hooks/e2e/on-app-shutdown.spec.ts

@@ -1,9 +1,9 @@
+import { Injectable, OnApplicationShutdown } from '@nestjs/common';
 import { Test } from '@nestjs/testing';
 import { expect } from 'chai';
-import * as Sinon from 'sinon';
-import { Injectable, OnApplicationShutdown, ShutdownSignal } from '@nestjs/common';
-import { spawn, spawnSync } from 'child_process';
+import { spawnSync } from 'child_process';
 import { join } from 'path';
+import * as Sinon from 'sinon';
 
 @Injectable()
 class TestInjectable implements OnApplicationShutdown {
@@ -23,26 +23,41 @@ describe('OnApplicationShutdown', () => {
   });
 
   it('should call onApplicationShutdown if any shutdown signal gets invoked', done => {
-    const result = spawnSync('ts-node', [join(__dirname, '../src/main.ts'), 'SIGHUP']);
-    expect(result.stdout.toString().trim()).to.be.eq('Signal SIGHUP');
+    const result = spawnSync('ts-node', [
+      join(__dirname, '../src/main.ts'),
+      'SIGHUP',
+    ]);
+    expect(result.stdout.toString().trim() === 'Signal SIGHUP').to.be.true;
     done();
-  });
+  }).timeout(5000);
 
   it('should call onApplicationShutdown if a specific shutdown signal gets invoked', done => {
-    const result = spawnSync('ts-node', [join(__dirname, '../src/main.ts'), 'SIGINT', 'SIGINT']);
+    const result = spawnSync('ts-node', [
+      join(__dirname, '../src/main.ts'),
+      'SIGINT',
+      'SIGINT',
+    ]);
     expect(result.stdout.toString().trim()).to.be.eq('Signal SIGINT');
     done();
-  });
+  }).timeout(5000);
 
   it('should ignore system signals which are not specified', done => {
-    const result = spawnSync('ts-node', [join(__dirname, '../src/main.ts'), 'SIGINT', 'SIGHUP']);
+    const result = spawnSync('ts-node', [
+      join(__dirname, '../src/main.ts'),
+      'SIGINT',
+      'SIGHUP',
+    ]);
     expect(result.stdout.toString().trim()).to.be.eq('');
     done();
-  });
+  }).timeout(5000);
 
   it('should ignore system signals if "enableShutdownHooks" was not called', done => {
-    const result = spawnSync('ts-node', [join(__dirname, '../src/main.ts'), 'SIGINT', 'NONE']);
+    const result = spawnSync('ts-node', [
+      join(__dirname, '../src/main.ts'),
+      'SIGINT',
+      'NONE',
+    ]);
     expect(result.stdout.toString().trim()).to.be.eq('');
     done();
-  });
+  }).timeout(5000);
 });

integration/microservices/src/disconnected.controller.ts

@@ -16,16 +16,17 @@ export class DisconnectedClientController {
     const client = ClientProxyFactory.create(options);
     return client.send<number, number[]>({ cmd: 'none' }, [1, 2, 3]).pipe(
       /*tap(
-          console.log.bind(console, 'data'),
-          console.error.bind(console, 'error'),
-        ),*/
-      catchError(({ code }) =>
-        throwError(
+        console.log.bind(console, 'data'),
+        console.error.bind(console, 'error'),
+      ),*/
+      catchError(error => {
+        const { code } = error || { code: 'CONN_ERR' };
+        return throwError(
           code === 'ECONNREFUSED' || code === 'CONN_ERR'
             ? new RequestTimeoutException('ECONNREFUSED')
             : new InternalServerErrorException(),
-        ),
-      ),
+        );
+      }),
     );
   }
 }