tests(@nestjs) fix broken stubs, flush out exceptions

Author: kamilmysliwiec

packages/core/test/guards/guards-consumer.spec.ts

@@ -49,10 +49,10 @@ describe('GuardsConsumer', () => {
   });
   describe('pickResult', () => {
     describe('when result is Observable', () => {
-      it('should returns promise', () => {
+      it('should returns result', async () => {
         expect(
-          consumer.pickResult(of(true)),
-        ).to.eventually.instanceOf(Promise);
+          await consumer.pickResult(of(true)),
+        ).to.be.true;
       });
     });
     describe('when result is Promise', () => {

packages/core/test/helpers/external-context-creator.spec.ts

@@ -57,7 +57,7 @@ describe('ExternalContextCreator', () => {
         describe('when can not activate', () => {
           it('should throw exception when "tryActivate" returns false', () => {
             sinon.stub(guardsConsumer, 'tryActivate', () => false);
-            expect(proxyContext(1, 2, 3)).to.eventually.throw();
+            expect(proxyContext(1, 2, 3)).to.eventually.throw;
           });
         });
         describe('when can activate', () => {
@@ -86,7 +86,7 @@ describe('ExternalContextCreator', () => {
 
         modules.set(moduleKey, {});
         (contextCreator as any).modulesContainer = modules;
-        sinon.stub(contextCreator, 'findComponentByClassName', () => true);
+        sinon.stub(contextCreator, 'findComponentByClassName').callsFake(() => true);
 
         expect(
           contextCreator.findContextModuleName({ name: componentKey } as any),
@@ -95,7 +95,7 @@ describe('ExternalContextCreator', () => {
     });
     describe('when component does not exists', () => {
       it('should return empty string', () => {
-        sinon.stub(contextCreator, 'findComponentByClassName', () => false);
+        sinon.stub(contextCreator, 'findComponentByClassName').callsFake(() => false);
         expect(contextCreator.findContextModuleName({} as any)).to.be.eql('');
       });
     });

packages/core/test/router/router-execution-context.spec.ts

@@ -117,7 +117,7 @@ describe('RouterExecutionContext', () => {
             });
           });
           it('should throw exception when "tryActivate" returns false', () => {
-            sinon.stub(guardsConsumer, 'tryActivate', () => false);
+            sinon.stub(guardsConsumer, 'tryActivate').callsFake(() => false);
             expect(proxyContext(request, response, next)).to.eventually.throw();
           });
         });
@@ -326,7 +326,7 @@ describe('RouterExecutionContext', () => {
   describe('createGuardsFn', () => {
     it('should throw exception when "tryActivate" returns false', () => {
       const guardsFn = contextCreator.createGuardsFn([null], null, null);
-      sinon.stub(guardsConsumer, 'tryActivate', () => false);
+      sinon.stub(guardsConsumer, 'tryActivate').callsFake(() => false);
       expect(guardsFn([])).to.eventually.throw();
     });
   });

packages/microservices/test/server/server-mqtt.spec.ts

@@ -76,9 +76,11 @@ describe('ServerMqtt', () => {
     });
     describe('handler', () => {
       it('should call "handleMessage"', async () => {
-        const spy = sinon.spy(server, 'handleMessage');
+        const handleMessageStub = sinon
+          .stub(server, 'handleMessage')
+          .callsFake(() => null);
         (await server.getMessageHandler((server as any).mqttClient))(null);
-        expect(spy.called).to.be.true;
+        expect(handleMessageStub.called).to.be.true;
       });
     });
   });

packages/microservices/test/server/server-nats.spec.ts

@@ -73,10 +73,12 @@ describe('ServerNats', () => {
     });
     describe('handler', () => {
       it('should call "handleMessage"', async () => {
-        const spy = sinon.spy(server, 'handleMessage');
-        (await server.getMessageHandler(null, (server as any).natsClient))(null);
-        expect(spy.called).to.be.true;
-      })
+        const handleMessageStub = sinon
+          .stub(server, 'handleMessage')
+          .callsFake(() => null);
+        (await server.getMessageHandler('', (server as any).natsClient))('');
+        expect(handleMessageStub.called).to.be.true;
+      });
     });
   });
   describe('handleMessage', () => {
@@ -130,12 +132,8 @@ describe('ServerNats', () => {
     it(`should call "publish" with expected arguments`, () => {
       const respond = 'test';
       publisher({ respond, id });
-      expect(
-        publisherSpy.calledWith(
-          `${pattern}_res`,
-          { respond, id },
-        ),
-      ).to.be.true;
+      expect(publisherSpy.calledWith(`${pattern}_res`, { respond, id })).to.be
+        .true;
     });
   });
   describe('getAckPatternName', () => {