feat(microservice): hybrid microservice can inherit config

Author: 2Kable

packages/common/index.ts

@@ -35,6 +35,7 @@ export {
   NestInterceptor,
   NestMiddleware,
   NestModule,
+  NestHybridOptions,
   OnApplicationBootstrap,
   OnApplicationShutdown,
   OnModuleDestroy,

packages/common/interfaces/index.ts

@@ -28,3 +28,4 @@ export * from './nest-microservice.interface';
 export * from './scope-options.interface';
 export * from './type.interface';
 export * from './websockets/web-socket-adapter.interface';
+export * from './microservices/nest-hybrid-options.interface';

packages/common/interfaces/microservices/nest-hybrid-options.interface.ts

@@ -0,0 +1,3 @@
+export interface NestHybridOptions {
+  inheritAppConfig?: boolean;
+}

packages/common/interfaces/nest-application.interface.ts

@@ -2,7 +2,12 @@ import { CorsOptions } from './external/cors-options.interface';
 import { CanActivate } from './features/can-activate.interface';
 import { NestInterceptor } from './features/nest-interceptor.interface';
 import { HttpServer } from './http/http-server.interface';
-import { ExceptionFilter, INestMicroservice, PipeTransform } from './index';
+import {
+  ExceptionFilter,
+  INestMicroservice,
+  NestHybridOptions,
+  PipeTransform,
+} from './index';
 import { INestApplicationContext } from './nest-application-context.interface';
 import { WebSocketAdapter } from './websockets/web-socket-adapter.interface';
 
@@ -80,9 +85,13 @@ export interface INestApplication extends INestApplicationContext {
    * to a hybrid instance.
    *
    * @param  {T} options Microservice options object
+   * @param  {NestHybridOptions} hybridOptions Hybrid options object
    * @returns {INestMicroservice}
    */
-  connectMicroservice<T extends object = any>(options: T): INestMicroservice;
+  connectMicroservice<T extends object = any>(
+    options: T,
+    hybridOptions?: NestHybridOptions,
+  ): INestMicroservice;
 
   /**
    * Returns array of the microservices connected to the NestApplication.

packages/core/nest-application.ts

@@ -7,6 +7,7 @@ import {
   NestInterceptor,
   PipeTransform,
   WebSocketAdapter,
+  NestHybridOptions,
 } from '@nestjs/common';
 import { CorsOptions } from '@nestjs/common/interfaces/external/cors-options.interface';
 import { NestApplicationOptions } from '@nestjs/common/interfaces/nest-application-options.interface';
@@ -170,14 +171,19 @@ export class NestApplication extends NestApplicationContext
     this.routesResolver.registerExceptionHandler();
   }
 
-  public connectMicroservice<T extends object>(options: T): INestMicroservice {
+  public connectMicroservice<T extends object>(
+    options: T,
+    hybridOptions: NestHybridOptions = {},
+  ): INestMicroservice {
     const { NestMicroservice } = loadPackage(
       '@nestjs/microservices',
       'NestFactory',
       () => require('@nestjs/microservices'),
     );
-
-    const applicationConfig = new ApplicationConfig();
+    const { inheritAppConfig } = hybridOptions;
+    const applicationConfig = inheritAppConfig
+      ? this.config
+      : new ApplicationConfig();
     const instance = new NestMicroservice(
       this.container,
       options,

packages/core/test/nest-application.spec.ts

@@ -0,0 +1,54 @@
+import { expect } from 'chai';
+import { NestApplication } from '../nest-application';
+import { ApplicationConfig } from '../application-config';
+import { NestContainer } from '../injector';
+import { NoopHttpAdapter } from './utils/noop-adapter.spec';
+
+describe('NestApplication', () => {
+  describe('Hybrid Application', () => {
+    class Interceptor {
+      public intercept(context, next) {
+        return next();
+      }
+    }
+    it('default should use new ApplicationConfig', () => {
+      const applicationConfig = new ApplicationConfig();
+      const container = new NestContainer(applicationConfig);
+      const instance = new NestApplication(
+        container,
+        new NoopHttpAdapter({}),
+        applicationConfig,
+        {},
+      );
+      instance.useGlobalInterceptors(new Interceptor());
+      const microservice = instance.connectMicroservice({});
+      expect((instance as any).config.getGlobalInterceptors().length).to.equal(
+        1,
+      );
+      expect(
+        (microservice as any).applicationConfig.getGlobalInterceptors().length,
+      ).to.equal(0);
+    });
+    it('should inherit existing ApplicationConfig', () => {
+      const applicationConfig = new ApplicationConfig();
+      const container = new NestContainer(applicationConfig);
+      const instance = new NestApplication(
+        container,
+        new NoopHttpAdapter({}),
+        applicationConfig,
+        {},
+      );
+      instance.useGlobalInterceptors(new Interceptor());
+      const microservice = instance.connectMicroservice(
+        {},
+        { inheritAppConfig: true },
+      );
+      expect((instance as any).config.getGlobalInterceptors().length).to.equal(
+        1,
+      );
+      expect(
+        (microservice as any).applicationConfig.getGlobalInterceptors().length,
+      ).to.equal(1);
+    });
+  });
+});