Merge branch 'oschweitzer-parseInt-pipe-improvement'

Author: kamilmysliwiec

src/common/pipes/parse-int.pipe.ts

@@ -1,14 +1,17 @@
 import { BadRequestException } from '../exceptions/bad-request.exception';
 import { PipeTransform } from '../interfaces/pipe-transform.interface';
-import { Pipe, ArgumentMetadata } from '../index';
+import { ArgumentMetadata, Pipe } from '../index';
 
 @Pipe()
 export class ParseIntPipe implements PipeTransform<string> {
-  public async transform(value: string, metadata: ArgumentMetadata) {
-    const val = parseInt(value, 10);
-    if (isNaN(val)) {
-      throw new BadRequestException('Validation failed');
+  async transform(value: string, metadata: ArgumentMetadata): Promise<number> {
+    const isNumeric =
+      'string' === typeof value &&
+      !isNaN(parseFloat(value)) &&
+      isFinite(value as any);
+    if (!isNumeric) {
+      throw new BadRequestException('Numeric string is expected');
     }
-    return val;
+    return parseInt(value, 10);
   }
 }

src/common/test/pipes/parse-int.pipe.spec.ts

@@ -17,9 +17,9 @@ describe('ParseIntPipe', () => {
         );
       });
     });
-    describe('when validation vails', () => {
+    describe('when validation fails', () => {
       it('should throw an error', async () => {
-        return expect(target.transform('notanumber!', {} as any)).to.be
+        return expect(target.transform('123abc', {} as any)).to.be
           .rejected;
       });
     });