Skip to content

Commit 21be3f8

Browse files
author
Patrick Housley
committed
fix(common): removing duplicated axios interfaces
- Removed the deprecated package @types/axios. - Removed the duplicated axios interfaces. - Updated the HttpService to use the interfaces provided by axios.
1 parent eda82af commit 21be3f8

4 files changed

Lines changed: 3 additions & 143 deletions

File tree

package-lock.json

Lines changed: 1 addition & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"@nestjs/microservices": "^4.0.0",
2525
"@nestjs/testing": "^4.0.0",
2626
"@nestjs/websockets": "^4.0.0",
27-
"@types/axios": "^0.14.0",
2827
"axios": "^0.17.1",
2928
"class-transformer": "^0.1.8",
3029
"class-validator": "^0.8.1",

src/common/http/http.service.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
1-
import axios from 'axios';
1+
import axios, { AxiosRequestConfig, AxiosResponse } from 'axios';
22
import { Observable } from 'rxjs/Observable';
3-
import {
4-
AxiosRequestConfig,
5-
AxiosResponse,
6-
} from './interfaces/axios.interfaces';
73
import 'rxjs/add/observable/fromPromise';
84

95
export class HttpService {
106
request<T = any>(config: AxiosRequestConfig): Observable<AxiosResponse<T>> {
117
return Observable.fromPromise(axios.request<T>(config));
128
}
13-
9+
1410
get<T = any>(
1511
url: string,
1612
config?: AxiosRequestConfig,

src/common/http/interfaces/axios.interfaces.ts

Lines changed: 0 additions & 127 deletions
This file was deleted.

0 commit comments

Comments
 (0)