Skip to content

Commit 23760fe

Browse files
chore(deps): update ws package to v8
1 parent 521f586 commit 23760fe

4 files changed

Lines changed: 68 additions & 45 deletions

File tree

integration/websockets/e2e/ws-gateway.spec.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ async function createNestApp(...gateways): Promise<INestApplication> {
1414
const testingModule = await Test.createTestingModule({
1515
providers: gateways,
1616
}).compile();
17-
const app = await testingModule.createNestApplication();
17+
const app = testingModule.createNestApplication();
1818
app.useWebSocketAdapter(new WsAdapter(app) as any);
1919
return app;
2020
}
@@ -40,6 +40,7 @@ describe('WebSocketGateway (WsAdapter)', () => {
4040
await new Promise<void>(resolve =>
4141
ws.on('message', data => {
4242
expect(JSON.parse(data).data.test).to.be.eql('test');
43+
ws.close();
4344
resolve();
4445
}),
4546
);
@@ -63,6 +64,7 @@ describe('WebSocketGateway (WsAdapter)', () => {
6364
await new Promise<void>(resolve =>
6465
ws.on('message', data => {
6566
expect(JSON.parse(data).data.test).to.be.eql('test');
67+
ws.close();
6668
resolve();
6769
}),
6870
);
@@ -89,6 +91,7 @@ describe('WebSocketGateway (WsAdapter)', () => {
8991
await new Promise<void>(resolve =>
9092
ws.on('message', data => {
9193
expect(JSON.parse(data).data.test).to.be.eql('test');
94+
ws.close();
9295
resolve();
9396
}),
9497
);
@@ -113,6 +116,7 @@ describe('WebSocketGateway (WsAdapter)', () => {
113116
ws.on('open', () => {
114117
ws.on('message', data => {
115118
expect(JSON.parse(data).data.test).to.be.eql('test');
119+
ws.close();
116120
resolve();
117121
});
118122
ws.send(
@@ -129,6 +133,7 @@ describe('WebSocketGateway (WsAdapter)', () => {
129133
await new Promise<void>(resolve => {
130134
ws2.on('message', data => {
131135
expect(JSON.parse(data).data.test).to.be.eql('test');
136+
ws2.close();
132137
resolve();
133138
});
134139
ws2.send(
@@ -158,6 +163,7 @@ describe('WebSocketGateway (WsAdapter)', () => {
158163
ws.on('open', () => {
159164
ws.on('message', data => {
160165
expect(JSON.parse(data).data.test).to.be.eql('test');
166+
ws.close();
161167
resolve();
162168
});
163169
ws.send(
@@ -174,6 +180,7 @@ describe('WebSocketGateway (WsAdapter)', () => {
174180
await new Promise<void>(resolve => {
175181
ws2.on('message', data => {
176182
expect(JSON.parse(data).data.test).to.be.eql('test');
183+
ws2.close();
177184
resolve();
178185
});
179186
ws2.send(
@@ -187,5 +194,7 @@ describe('WebSocketGateway (WsAdapter)', () => {
187194
});
188195
});
189196

190-
afterEach(() => app.close());
197+
afterEach(async function () {
198+
await app.close();
199+
});
191200
});

package-lock.json

Lines changed: 50 additions & 40 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@
168168
"typeorm": "0.2.45",
169169
"typescript": "4.6.4",
170170
"wrk": "1.2.1",
171-
"ws": "7.5.6"
171+
"ws": "8.6.0"
172172
},
173173
"engines": {
174174
"node": ">= 10.13.0"
@@ -227,7 +227,11 @@
227227
"instrument": true
228228
},
229229
"mocha": {
230-
"require": ["ts-node/register", "node_modules/reflect-metadata/Reflect.js", "hooks/mocha-init-hook.ts"],
230+
"require": [
231+
"ts-node/register",
232+
"node_modules/reflect-metadata/Reflect.js",
233+
"hooks/mocha-init-hook.ts"
234+
],
231235
"exit": true
232236
}
233237
}

packages/platform-ws/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
},
1919
"dependencies": {
2020
"tslib": "2.4.0",
21-
"ws": "7.5.6"
21+
"ws": "8.6.0"
2222
},
2323
"peerDependencies": {
2424
"@nestjs/common": "^8.0.0",

0 commit comments

Comments
 (0)