Skip to content

Commit 26929c8

Browse files
committed
tests(): improvement
1 parent 9711141 commit 26929c8

6 files changed

Lines changed: 17 additions & 13 deletions

File tree

sample/07-sequelize/src/app.module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { Module } from '@nestjs/common';
22
import { SequelizeModule } from '@nestjs/sequelize';
3+
import { User } from './users/models/user.model';
34
import { UsersModule } from './users/users.module';
45

56
@Module({
@@ -13,6 +14,7 @@ import { UsersModule } from './users/users.module';
1314
database: 'test',
1415
autoLoadModels: true,
1516
synchronize: true,
17+
models: [User],
1618
}),
1719
UsersModule,
1820
],

sample/07-sequelize/src/users/user.model.ts renamed to sample/07-sequelize/src/users/models/user.model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Column, Model, Table } from 'sequelize-typescript';
22

33
@Table
4-
export class User extends Model<User> {
4+
export class User extends Model {
55
@Column
66
firstName: string;
77

sample/07-sequelize/src/users/users.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Body, Controller, Delete, Get, Param, Post } from '@nestjs/common';
22
import { CreateUserDto } from './dto/create-user.dto';
3-
import { User } from './user.model';
3+
import { User } from './models/user.model';
44
import { UsersService } from './users.service';
55

66
@Controller('users')
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
import { Module } from '@nestjs/common';
22
import { SequelizeModule } from '@nestjs/sequelize';
3-
import { User } from './user.model';
3+
import { User } from './models/user.model';
44
import { UsersController } from './users.controller';
55
import { UsersService } from './users.service';
66

77
@Module({
88
imports: [SequelizeModule.forFeature([User])],
99
providers: [UsersService],
1010
controllers: [UsersController],
11+
exports: [SequelizeModule],
1112
})
1213
export class UsersModule {}

sample/07-sequelize/src/users/users.service.spec.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Test, TestingModule } from '@nestjs/testing';
2-
import { User } from './user.model';
2+
import { User } from './models/user.model';
33
import { UsersService } from './users.service';
44
import { getModelToken } from '@nestjs/sequelize';
55

@@ -32,7 +32,7 @@ describe('UserService', () => {
3232
useValue: {
3333
findAll: jest.fn(() => userArray),
3434
findOne: jest.fn(),
35-
save: jest.fn(),
35+
create: jest.fn(() => oneUser),
3636
remove: jest.fn(),
3737
destroy: jest.fn(() => oneUser),
3838
},
@@ -50,11 +50,16 @@ describe('UserService', () => {
5050

5151
describe('create()', () => {
5252
it('should successfully insert a user', () => {
53-
const user = {
53+
const oneUser = {
5454
firstName: 'firstName #1',
5555
lastName: 'lastName #1',
5656
};
57-
expect(user).toEqual(user);
57+
expect(
58+
service.create({
59+
firstName: 'firstName #1',
60+
lastName: 'lastName #1',
61+
}),
62+
).toEqual(oneUser);
5863
});
5964
});
6065

sample/07-sequelize/src/users/users.service.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Injectable } from '@nestjs/common';
22
import { InjectModel } from '@nestjs/sequelize';
33
import { CreateUserDto } from './dto/create-user.dto';
4-
import { User } from './user.model';
4+
import { User } from './models/user.model';
55

66
@Injectable()
77
export class UsersService {
@@ -11,11 +11,7 @@ export class UsersService {
1111
) {}
1212

1313
create(createUserDto: CreateUserDto): Promise<User> {
14-
const user = new User();
15-
user.firstName = createUserDto.firstName;
16-
user.lastName = createUserDto.lastName;
17-
18-
return user.save();
14+
return this.userModel.create(createUserDto);
1915
}
2016

2117
async findAll(): Promise<User[]> {

0 commit comments

Comments
 (0)