fix(core): inquirer injection by property-injection fix

Author: kamilmysliwiec

integration/scopes/src/inject-inquirer/hello-request/hello-request.service.ts

@@ -1,11 +1,15 @@
-import { Injectable, Scope } from '@nestjs/common';
+import { Inject, Injectable, Scope } from '@nestjs/common';
+import { INQUIRER } from '@nestjs/core';
 import { RequestLogger } from './request-logger.service';
 
 @Injectable({ scope: Scope.REQUEST })
 export class HelloRequestService {
   static logger = { feature: 'request' };
 
-  constructor(private readonly logger: RequestLogger) {}
+  constructor(
+    private readonly logger: RequestLogger,
+    @Inject(INQUIRER) private readonly inquirer,
+  ) {}
 
   greeting() {
     this.logger.log('Hello request!');

integration/scopes/src/inject-inquirer/hello-request/request-logger.service.ts

@@ -1,5 +1,5 @@
-import { Inject, Logger, Injectable, Scope } from '@nestjs/common';
-import { REQUEST, INQUIRER } from '@nestjs/core';
+import { Inject, Injectable, Logger, Scope } from '@nestjs/common';
+import { INQUIRER, REQUEST } from '@nestjs/core';
 
 @Injectable({ scope: Scope.TRANSIENT })
 export class RequestLogger {

integration/scopes/src/inject-inquirer/hello-transient/transient-logger.service.ts

@@ -3,14 +3,15 @@ import { INQUIRER } from '@nestjs/core';
 
 @Injectable({ scope: Scope.TRANSIENT })
 export class TransientLogger {
-  // @Inject(INQUIRER) inquirer: any;
+  @Inject(INQUIRER) inquirer: any = null;
   config: object;
 
   constructor(
-    @Inject(INQUIRER) { constructor },
+    @Inject(INQUIRER) private readonly inquirerInCtor,
     private readonly logger: Logger,
   ) {
-    this.config = (constructor && constructor.logger) || {};
+    this.config =
+      (inquirerInCtor.constructor && inquirerInCtor.constructor.logger) || {};
   }
 
   log(message: string) {

packages/core/injector/injector.ts

@@ -201,6 +201,7 @@ export class Injector {
         inject,
         contextId,
         wrapper,
+        inquirer,
       );
       const instance = await this.instantiateClass(
         instances,
@@ -531,6 +532,7 @@ export class Injector {
     inject?: InjectorDependency[],
     contextId = STATIC_CONTEXT,
     inquirer?: InstanceWrapper,
+    parentInquirer?: InstanceWrapper,
   ): Promise<PropertyDependency[]> {
     if (!isNil(inject)) {
       return [];
@@ -547,6 +549,9 @@ export class Injector {
             key: item.key,
             name: item.name as string,
           };
+          if (this.isInquirer(item.name, parentInquirer)) {
+            return parentInquirer && parentInquirer.instance;
+          }
           const paramWrapper = await this.resolveSingleParam<T>(
             wrapper,
             item.name,

packages/core/injector/inquirer/inquirer-constants.ts

@@ -1 +1 @@
-export const INQUIRER = 'INQUIRER';
+export const INQUIRER = Symbol('INQUIRER');