refactor(): adjust to the codebase guidelines

Author: kamilmysliwiec

packages/common/exceptions/http.exception.ts

@@ -1,3 +1,5 @@
+import { isString } from '../utils/shared.utils';
+
 export class HttpException extends Error {
   public readonly message: any;
 
@@ -31,17 +33,12 @@ export class HttpException extends Error {
     return this.status;
   }
 
-  private getErrorString(target: string | object): string{
-    if (typeof target === 'string') {
-      return target;
-    }
-
-    return JSON.stringify(target);
-  }
-
   public toString(): string {
     const message = this.getErrorString(this.message);
-
     return `Error: ${message}`;
   }
+
+  private getErrorString(target: string | object): string {
+    return isString(target) ? target : JSON.stringify(target);
+  }
 }

packages/core/application-config.ts

@@ -8,15 +8,19 @@ import {
 import { InstanceWrapper } from './injector/instance-wrapper';
 
 export class ApplicationConfig {
+  private globalPrefix = '';
   private globalPipes: PipeTransform[] = [];
-  private globalRequestPipes: InstanceWrapper<PipeTransform>[] = [];
   private globalFilters: ExceptionFilter[] = [];
-  private globalRequestFilters: InstanceWrapper<ExceptionFilter>[] = [];
   private globalInterceptors: NestInterceptor[] = [];
-  private globalRequestInterceptors: InstanceWrapper<NestInterceptor>[] = [];
   private globalGuards: CanActivate[] = [];
-  private globalRequestGuards: InstanceWrapper<CanActivate>[] = [];
-  private globalPrefix = '';
+  private readonly globalRequestPipes: InstanceWrapper<PipeTransform>[] = [];
+  private readonly globalRequestFilters: InstanceWrapper<
+    ExceptionFilter
+  >[] = [];
+  private readonly globalRequestInterceptors: InstanceWrapper<
+    NestInterceptor
+  >[] = [];
+  private readonly globalRequestGuards: InstanceWrapper<CanActivate>[] = [];
 
   constructor(private ioAdapter: WebSocketAdapter | null = null) {}
 

packages/microservices/exceptions/rpc-exception.ts

@@ -1,3 +1,5 @@
+import { isString } from '@nestjs/common/utils/shared.utils';
+
 export class RpcException extends Error {
   public readonly message: any;
   constructor(private readonly error: string | object) {
@@ -9,17 +11,12 @@ export class RpcException extends Error {
     return this.error;
   }
 
-  private getErrorString(target: string | object): string {
-    if (typeof target === 'string') {
-      return target;
-    }
-
-    return JSON.stringify(target);
-  }
-
   public toString(): string {
     const message = this.getErrorString(this.message);
-
     return `Error: ${message}`;
   }
+
+  private getErrorString(target: string | object): string {
+    return isString(target) ? target : JSON.stringify(target);
+  }
 }

packages/websockets/errors/ws-exception.ts

@@ -1,3 +1,5 @@
+import { isString } from '@nestjs/common/utils/shared.utils';
+
 export class WsException extends Error {
   public readonly message: any;
 
@@ -10,17 +12,12 @@ export class WsException extends Error {
     return this.error;
   }
 
-  private getErrorString(target: string | object): string {
-    if (typeof target === 'string') {
-      return target;
-    }
-
-    return JSON.stringify(target);
-  }
-
   public toString(): string {
     const message = this.getErrorString(this.message);
-
     return `Error: ${message}`;
   }
+
+  private getErrorString(target: string | object): string {
+    return isString(target) ? target : JSON.stringify(target);
+  }
 }