Merge pull request nestjs#3741 from lafeuil/master

kamilmysliwiec · web-flow · commit 4e90c6cd643e · 2020-01-05T11:58:27.000+01:00
fix(platform): return a promise in close function (express)
diff --git a/packages/platform-express/adapters/express-adapter.ts b/packages/platform-express/adapters/express-adapter.ts
@@ -59,7 +59,10 @@ export class ExpressAdapter extends AbstractHttpAdapter {
   }
 
   public close() {
-    return this.httpServer ? this.httpServer.close() : undefined;
+    if (!this.httpServer) {
+      return undefined;
+    }
+    return new Promise(resolve => this.httpServer.close(resolve));
   }
 
   public set(...args: any[]) {

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,10 @@ export class ExpressAdapter extends AbstractHttpAdapter {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`public close() {`
`62`		`- return this.httpServer ? this.httpServer.close() : undefined;`
	`62`	`+ if (!this.httpServer) {`
	`63`	`+ return undefined;`
	`64`	`+ }`
	`65`	`+ return new Promise(resolve => this.httpServer.close(resolve));`
`63`	`66`	`}`
`64`	`67`
`65`	`68`	`public set(...args: any[]) {`