test(microservices) fix unit tests

Author: kamilmysliwiec

packages/microservices/server/server-nats.ts

@@ -41,20 +41,20 @@ export class ServerNats extends Server implements CustomTransportStrategy {
 
   public bindEvents(client: Client) {
     const queue = this.getOptionsProp<NatsOptions>(this.options, 'queue');
-    const subscribe = (channel: string) => {
-      if (queue) {
-        return client.subscribe(
-          channel,
-          { queue },
-          this.getMessageHandler(channel, client).bind(this),
-        );
-      }
-      client.subscribe(
-        channel,
-        this.getMessageHandler(channel, client).bind(this),
-      );
-    };
-    const registeredPatterns = Object.keys(this.messageHandlers);
+    const subscribe = queue
+      ? (channel: string) =>
+          client.subscribe(
+            channel,
+            { queue },
+            this.getMessageHandler(channel, client).bind(this),
+          )
+      : (channel: string) =>
+          client.subscribe(
+            channel,
+            this.getMessageHandler(channel, client).bind(this),
+          );
+
+    const registeredPatterns = [...this.messageHandlers.keys()];
     registeredPatterns.forEach(channel => subscribe(channel));
   }
 

packages/microservices/test/server/server-nats.spec.ts

@@ -52,7 +52,7 @@ describe('ServerNats', () => {
         subscribe: subscribeSpy,
       };
     });
-    it('should subscribe each acknowledge patterns', () => {
+    it('should subscribe to each acknowledge patterns', () => {
       const pattern = 'test';
       const handler = sinon.spy();
 

packages/microservices/test/server/server-rmq.spec.ts

@@ -93,9 +93,12 @@ describe('ServerRMQ', () => {
     });
     it('should call handler if exists in handlers object', async () => {
       const handler = sinon.spy();
-      (server as any).messageHandlers = {
+      const objectToMap = obj =>
+        new Map(Object.keys(obj).map(key => [key, obj[key]]) as any);
+
+      (server as any).messageHandlers = objectToMap({
         [JSON.stringify(pattern)]: handler as any,
-      };
+      });
       await server.handleMessage(msg);
       expect(handler.calledOnce).to.be.true;
     });

packages/microservices/test/server/server-tcp.spec.ts

@@ -72,7 +72,7 @@ describe('ServerTCP', () => {
         new Map(Object.keys(obj).map(key => [key, obj[key]]) as any);
 
       (server as any).messageHandlers = objectToMap({
-        [JSON.stringify(msg.pattern)]: handler as any,
+        [msg.pattern]: handler as any,
       });
       server.handleMessage(socket, msg);
       expect(handler.calledOnce).to.be.true;